coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4517 discussions

Change in coreboot[master]: payloads/libpayload: add MTK_TIMER_V2 config
by Rex-BC Chen (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56845 to look at the new patch set (#2). Change subject: payloads/libpayload: add MTK_TIMER_V2 config ...................................................................... payloads/libpayload: add MTK_TIMER_V2 config Offset of timer is changed on MT8195. BUG=b:195274787 Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: Ifd6ff65a825c4309c47f3b115b80a8ecd42fedac --- M payloads/libpayload/drivers/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/56845/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd6ff65a825c4309c47f3b115b80a8ecd42fedac Gerrit-Change-Number: 56845 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variant/taeko: Update devicetree settings
by Joey Peng (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Joey Peng, Nick Vaccaro, YH Lin. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56802 to look at the new patch set (#5). Change subject: mb/google/brya/variant/taeko: Update devicetree settings ...................................................................... mb/google/brya/variant/taeko: Update devicetree settings Based on schematic and gpio table of taeko, generate overridetree.cb settings for taeko. BUG=b:195494281 TEST=FW_NAME=taeko emerge-brya coreboot chromeos-bootimage Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 --- M src/mainboard/google/brya/variants/taeko/overridetree.cb 1 file changed, 258 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/56802/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 Gerrit-Change-Number: 56802 Gerrit-PatchSet: 5 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: playloads/libpayload: add MTK_TIMER_V2 config
by Rex-BC Chen (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56845 ) Change subject: playloads/libpayload: add MTK_TIMER_V2 config ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56845/comment/8d2830c0_3931f133 PS1, Line 11: 195274787 > How does this patch improve boot time? this patch is not for improving boot time. It's for correcting boot time in depthcharge. -- To view, visit https://review.coreboot.org/c/coreboot/+/56845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd6ff65a825c4309c47f3b115b80a8ecd42fedac Gerrit-Change-Number: 56845 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 06 Aug 2021 03:04:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: playloads/libpayload: add MTK_TIMER_V2 config
by Yu-Ping Wu (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56845 ) Change subject: playloads/libpayload: add MTK_TIMER_V2 config ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56845/comment/fd536b18_e6904741 PS1, Line 7: playloads payloads https://review.coreboot.org/c/coreboot/+/56845/comment/d1558e13_5118bca2 PS1, Line 9: chaged changed https://review.coreboot.org/c/coreboot/+/56845/comment/2c338d92_75312406 PS1, Line 11: 195274787 How does this patch improve boot time? -- To view, visit https://review.coreboot.org/c/coreboot/+/56845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd6ff65a825c4309c47f3b115b80a8ecd42fedac Gerrit-Change-Number: 56845 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 06 Aug 2021 03:02:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/lint: Show an error if a symbol is created in two choice blocks
by Martin Roth (Code Review) 06 Aug '21

06 Aug '21

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18970 ) Change subject: util/lint: Show an error if a symbol is created in two choice blocks ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > This also prevents such constructs, where Kconfig does *not* warn and which do work (I use such in m […] ack. -- To view, visit https://review.coreboot.org/c/coreboot/+/18970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0acce1d40a6ca2b212c638bdb1ec65de5bd4d726 Gerrit-Change-Number: 18970 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 06 Aug 2021 03:00:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Improve boot time by raising little CPU frequency
by Yu-Ping Wu (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56844 ) Change subject: mb/google/cherry: Improve boot time by raising little CPU frequency ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56844/comment/10257dc9_b85c67c5 PS1, Line 9: . by xxms or "from xxms to xxms" -- To view, visit https://review.coreboot.org/c/coreboot/+/56844 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id6aac8f9db86a6c1e61ea94863f2cbde12c0482e Gerrit-Change-Number: 56844 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 06 Aug 2021 03:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
by Martin Roth (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 ) Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > haven't checked the details yet, but i do like the approach. […] My thought was to print the SPI speed and mode when the console is initialized. I can also do the comparison again at that point though and print out that it was skipped. File src/soc/amd/common/block/spi/fch_spi.c: https://review.coreboot.org/c/coreboot/+/56818/comment/9d3cc39c_a0482530 PS2, Line 25: spi_speed_offset > Can this be offset be defined as a config item i.e. CONFIG_EFS_SPI_SPEED_OFFSET with default as -1. […] Sure, though I'd really prefer to do it with the precompiler and not add another "config" variable that isn't really a variable. I'll make an EFS header file and put all of the EFS header information in there. -- To view, visit https://review.coreboot.org/c/coreboot/+/56818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e Gerrit-Change-Number: 56818 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 06 Aug 2021 02:58:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: add mt6359p vcore support
by Yu-Ping Wu (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56843 ) Change subject: soc/mediatek/mt8195: add mt6359p vcore support ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56843/comment/082509d9_5194cc6f PS1, Line 9: Add mt6359p vcore set/get support. Please explain why we need this. -- To view, visit https://review.coreboot.org/c/coreboot/+/56843 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf49390ba78870b834c6d0b64e3f0f30f3494f18 Gerrit-Change-Number: 56843 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 06 Aug 2021 02:54:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: early-init eMMC
by Yu-Ping Wu (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56842 ) Change subject: mb/google/cherry: early-init eMMC ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/cherry/mainboard.c: https://review.coreboot.org/c/coreboot/+/56842/comment/e7e07593_8c4a3203 PS1, Line 43: tab -- To view, visit https://review.coreboot.org/c/coreboot/+/56842 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idc86f9121fa4a34f09a683f7a81087c13ea3dd42 Gerrit-Change-Number: 56842 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 06 Aug 2021 02:53:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: select mmc storage config
by Yu-Ping Wu (Code Review) 06 Aug '21

06 Aug '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56841 ) Change subject: mb/google/cherry: select mmc storage config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67c8795b6e6fc121e8fe61c40da05593faa02d94 Gerrit-Change-Number: 56841 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 06 Aug 2021 02:51:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021