Attention is currently required from: Henry Sun, Aseda Aboagye, Karthik Ramasubramanian.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56798 )
Change subject: mb/google/dedede: Create driblee variant
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
Hi Karthik,
I appreciate your comment.
The missing items are updated.
File src/mainboard/google/dedede/variants/driblee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56798/comment/a4d5fc03_787aa795
PS2, Line 30:
> register "SerialIoGSpiMode[PchSerialIoIndexGSPI0]" = "PchSerialIoDisabled" # Disable GSPI0 […]
Done
https://review.coreboot.org/c/coreboot/+/56798/comment/961f7488_16a00075
PS2, Line 37: end # PCH eSPI
> Disable GSPI0 device to CR50.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
Gerrit-Change-Number: 56798
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 02:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Aseda Aboagye, Karthik Ramasubramanian.
Frank Wu has uploaded a new patch set (#5) to the change originally created by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/56796 )
Change subject: mb/google/dedede: Create corori variant
......................................................................
mb/google/dedede: Create corori variant
Create the corori variant of the waddledee reference board by
copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:194356176
BRANCH=None
TEST=util/abuild/abuild -p none -t google/dedede -x -a
make sure the build includes GOOGLE_CORORI
Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Change-Id: I8380d5aab61c99d545625789ff1251ec1caa84a2
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/corori/include/variant/ec.h
A src/mainboard/google/dedede/variants/corori/include/variant/gpio.h
A src/mainboard/google/dedede/variants/corori/memory/Makefile.inc
A src/mainboard/google/dedede/variants/corori/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/corori/memory/mem_parts_used.txt
A src/mainboard/google/dedede/variants/corori/overridetree.cb
8 files changed, 83 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/56796/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8380d5aab61c99d545625789ff1251ec1caa84a2
Gerrit-Change-Number: 56796
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Henry Sun, Aseda Aboagye.
Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, EricR Lai, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56798
to look at the new patch set (#3).
Change subject: mb/google/dedede: Create driblee variant
......................................................................
mb/google/dedede: Create driblee variant
Create the driblee variant of the waddledee reference board by
copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:191732473
BRANCH=None
TEST=util/abuild/abuild -p none -t google/dedede -x -a
make sure the build includes GOOGLE_DRIBLEE
Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/driblee/include/variant/ec.h
A src/mainboard/google/dedede/variants/driblee/include/variant/gpio.h
A src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc
A src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt
A src/mainboard/google/dedede/variants/driblee/overridetree.cb
8 files changed, 83 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/56798/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
Gerrit-Change-Number: 56798
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Weimin Wu, Karthik Ramasubramanian.
Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56795 )
Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for multi audio codec
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/dedede/variants/cappy2/gpio.c:
https://review.coreboot.org/c/coreboot/+/56795/comment/3aff9eaf_6184c5da
PS6, Line 25: PAD_NC(GPP_D18, NONE),
> What is in D18?
The gpio that control the main frequency signal to Realtek
https://review.coreboot.org/c/coreboot/+/56795/comment/b83076f1_6617eafe
PS6, Line 36: BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);
> I believe the change here works well with CB:56616 i.e. both the changes are taking effect.
Yes,i made the modification according to the cert projecct.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
Gerrit-Change-Number: 56795
Gerrit-PatchSet: 8
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 06 Aug 2021 02:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sunwei Li, Henry Sun, Weimin Wu.
Hello build bot (Jenkins), Henry Sun, Weimin Wu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56795
to look at the new patch set (#8).
Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for multi audio codec
......................................................................
mb/google/dedede/var/cappy2: Add fw_config probe for multi audio codec
Compatible headphone codec "Realtek ALC5682I-VD" and "cirrus CS42L42"
Compatible AMP codec "ALC1015Q-VB" and "MAX98360"
BUG=b:193373320
BRANCH=dedede
TEST=Both realtek and cirrus audio codec can work normally
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/variants/cappy2/gpio.c
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
3 files changed, 63 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/56795/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/56795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
Gerrit-Change-Number: 56795
Gerrit-PatchSet: 8
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sunwei Li, Henry Sun, Weimin Wu.
Hello build bot (Jenkins), Henry Sun, Weimin Wu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56795
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/cappy2: Probe SSFC and setup audio codec
......................................................................
mb/google/dedede/var/cappy2: Probe SSFC and setup audio codec
Compatible audio codec "Realtek RT5682" and "cirrus CS42L42"
BUG=b:193373320
BRANCH=dedede
TEST=Both realtek and cirrus audio can work normally
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/variants/cappy2/gpio.c
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
3 files changed, 63 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/56795/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/56795
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
Gerrit-Change-Number: 56795
Gerrit-PatchSet: 7
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset