Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49767
to look at the new patch set (#53).
Change subject: soc/qualcomm: move aop firmware loading changes to common
......................................................................
soc/qualcomm: move aop firmware loading changes to common
Add AOP firmware support
Developer/Reviewer, be aware of this patch from Napali:
https://review.coreboot.org/c/coreboot/+/25210/85
BUG=b:182963902
TEST=Validated on qualcomm sc7280 development board
Change-Id: I90b0f48e15df390970e027bff2065b7a89b14cec
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
---
R src/soc/qualcomm/common/aop_load_reset.c
A src/soc/qualcomm/common/include/soc/aop_common.h
M src/soc/qualcomm/common/mmu.c
M src/soc/qualcomm/sc7180/Makefile.inc
D src/soc/qualcomm/sc7180/include/soc/aop.h
M src/soc/qualcomm/sc7180/mmu.c
M src/soc/qualcomm/sc7180/soc.c
M src/soc/qualcomm/sc7280/Makefile.inc
M src/soc/qualcomm/sc7280/memlayout.ld
M src/soc/qualcomm/sc7280/soc.c
10 files changed, 35 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/49767/53
--
To view, visit https://review.coreboot.org/c/coreboot/+/49767
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90b0f48e15df390970e027bff2065b7a89b14cec
Gerrit-Change-Number: 49767
Gerrit-PatchSet: 53
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52131
to look at the new patch set (#27).
Change subject: sc7280: Enable bootblock compression
......................................................................
sc7280: Enable bootblock compression
This patch enables bootblock compression on SC7280. In my tests, that
makes it boot roughly 10ms faster (which isn't much, but... might as
well take it).
Ref link: https://review.coreboot.org/c/coreboot/+/45855
BUG=b:182963902
TEST=Validated on qualcomm sc7180 and sc7280 development board.
Change-Id: I3564a7e531d769c8df16a1592ea98133d83b07b0
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
---
M src/soc/qualcomm/sc7280/Kconfig
M src/soc/qualcomm/sc7280/Makefile.inc
A src/soc/qualcomm/sc7280/decompressor.c
3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/52131/27
--
To view, visit https://review.coreboot.org/c/coreboot/+/52131
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3564a7e531d769c8df16a1592ea98133d83b07b0
Gerrit-Change-Number: 52131
Gerrit-PatchSet: 27
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55963
to look at the new patch set (#4).
Change subject: sc7280: Refactor UART driver
......................................................................
sc7280: Refactor UART driver
Refactor UART driver by separating
common and SoC specific driver code.
BUG=b:182963902
TEST=Validated on qualcomm sc7280 development board
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I015e21081391bfe85edf667685bf117401a9ec00
---
M src/soc/qualcomm/sc7280/Kconfig
M src/soc/qualcomm/sc7280/Makefile.inc
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/55963/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55963
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I015e21081391bfe85edf667685bf117401a9ec00
Gerrit-Change-Number: 55963
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55961
to look at the new patch set (#4).
Change subject: sc7280: Refactor I2C driver
......................................................................
sc7280: Refactor I2C driver
Refactor I2C driver by separating
common and SoC specific driver code.
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I58c2b79ea2feeab0ad4c2b7cdaa041984160a7ae
---
M src/soc/qualcomm/sc7280/Makefile.inc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/55961/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55961
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58c2b79ea2feeab0ad4c2b7cdaa041984160a7ae
Gerrit-Change-Number: 55961
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55960
to look at the new patch set (#4).
Change subject: sc7280: Refactor QUP driver
......................................................................
sc7280: Refactor QUP driver
Refactor QUP driver by separating
common and SoC specific driver code
BUG=b:182963902
TEST=Validated on qualcomm sc7280 development board
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I0e9049557ff63898037210e72333e1739ab62413
---
M src/soc/qualcomm/sc7280/Makefile.inc
M src/soc/qualcomm/sc7280/bootblock.c
M src/soc/qualcomm/sc7280/include/soc/addressmap.h
A src/soc/qualcomm/sc7280/include/soc/qcom_qup_se.h
A src/soc/qualcomm/sc7280/qcom_qup_se.c
5 files changed, 229 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/55960/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55960
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e9049557ff63898037210e72333e1739ab62413
Gerrit-Change-Number: 55960
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Taniya Das, Julius Werner, mturney mturney.
Hello Shelley Chen, build bot (Jenkins), Taniya Das, Julius Werner, mturney mturney,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55079
to look at the new patch set (#12).
Change subject: sc7180: Add target specific GPIO pin definitions
......................................................................
sc7180: Add target specific GPIO pin definitions
The common gpio driver can be re-used for SC7180,
thus remove the existing gpio driver support and
also cleanup the common macro definitions.
Add GPIO pin details specific to SC7180 chipset
for the consumers to be able to request for the
gpio functionality as per their requirement.
BUG=b:182963902
TEST=Validated on qualcomm sc7180 development board
Signed-off-by: Taniya Das <tdas(a)codeaurora.org>
Change-Id: Ifd206e6bc9a549706e7a2c4bde0b7d5527ca6268
---
M src/soc/qualcomm/sc7180/Makefile.inc
D src/soc/qualcomm/sc7180/gpio.c
M src/soc/qualcomm/sc7180/include/soc/gpio.h
3 files changed, 4 insertions(+), 214 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/55079/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/55079
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd206e6bc9a549706e7a2c4bde0b7d5527ca6268
Gerrit-Change-Number: 55079
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner, mturney mturney.
Hello Shelley Chen, build bot (Jenkins), Julius Werner, mturney mturney,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55959
to look at the new patch set (#4).
Change subject: trogdor: sc7180: Rename header files as per common QUP driver changes
......................................................................
trogdor: sc7180: Rename header files as per common QUP driver changes
As part of code clean up, renaming the header files for QUP driver.
BUG=b:182963902
TEST=Validated on qualcomm sc7280 development board
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I36a4f28b77e3942a4c6069b1785b0c6ac5b7e0a2
---
M src/mainboard/google/trogdor/bootblock.c
M src/mainboard/google/trogdor/mainboard.c
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/55959/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55959
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a4f28b77e3942a4c6069b1785b0c6ac5b7e0a2
Gerrit-Change-Number: 55959
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55957
to look at the new patch set (#4).
Change subject: sc7180: Refactor SPI driver
......................................................................
sc7180: Refactor SPI driver
Refactor SPI driver by separating common and
SoC specific code
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I0c57f8650271287a1b3ccce9bd62fce6987d785e
---
M src/soc/qualcomm/sc7180/Makefile.inc
D src/soc/qualcomm/sc7180/include/soc/qupv3_spi.h
D src/soc/qualcomm/sc7180/qupv3_spi.c
3 files changed, 0 insertions(+), 234 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/55957/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55957
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c57f8650271287a1b3ccce9bd62fce6987d785e
Gerrit-Change-Number: 55957
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55954
to look at the new patch set (#4).
Change subject: soc/qualcomm/common/uart: Add support for UART common driver
......................................................................
soc/qualcomm/common/uart: Add support for UART common driver
This implements UART driver for QCOM SoC's
BUG=b:182963902
TEST=Validated on qualcomm sc7180 and sc7280 development board.
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I7bc2d3765f956e04bae3e45c3a9b9e2ad424c7b1
---
A src/soc/qualcomm/common/qupv3_uart.c
1 file changed, 154 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/55954/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bc2d3765f956e04bae3e45c3a9b9e2ad424c7b1
Gerrit-Change-Number: 55954
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55952
to look at the new patch set (#4).
Change subject: soc/qualcomm/common/i2c: Add support for I2C common driver
......................................................................
soc/qualcomm/common/i2c: Add support for I2C common driver
This implements i2c driver for qualcomm chipsets
BUG=b:182963902
TEST=Validated on qualcomm sc7180 and sc7280 development board
Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org>
Change-Id: I16e6fc2c1c24b9814d1803bffd5cfbb657201cfb
---
A src/soc/qualcomm/common/include/soc/qupv3_i2c_common.h
A src/soc/qualcomm/common/qupv3_i2c.c
2 files changed, 163 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/55952/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55952
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16e6fc2c1c24b9814d1803bffd5cfbb657201cfb
Gerrit-Change-Number: 55952
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset