coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: soc/qualcomm/common/qspi: Add support for common QSPI driver
by Ravi kumar (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Shelley Chen, Ravi kumar, Roja Rani Yarubandi, mturney mturney, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Roja Rani Yarubandi, mturney mturney, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55323 to look at the new patch set (#10). Change subject: soc/qualcomm/common/qspi: Add support for common QSPI driver ...................................................................... soc/qualcomm/common/qspi: Add support for common QSPI driver Add common QSPI functionalities for qualcomm SoC targets. This common QSPI driver works in master mode and provides read/write operation for the slave devices like Flash. BUG=b:182963902 TEST=Validated on qualcomm sc7180 and sc7280 development board Signed-off-by: Rajesh Patil <rajpat(a)codeaurora.org> Change-Id: I5b3816b823e14db1dd13f1eb4a6761c7a61604b9 --- A src/soc/qualcomm/common/include/soc/qspi_common.h A src/soc/qualcomm/common/qspi.c A src/soc/qualcomm/common/spi.c 3 files changed, 440 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/55323/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/55323 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b3816b823e14db1dd13f1eb4a6761c7a61604b9 Gerrit-Change-Number: 55323 Gerrit-PatchSet: 10 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: herobrine: get boardid from GPIO configuration
by Ravi kumar (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Ravi kumar. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55950 to look at the new patch set (#4). Change subject: herobrine: get boardid from GPIO configuration ...................................................................... herobrine: get boardid from GPIO configuration Getting boardid information for the different SKU variants BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Change-Id: I2b7625f9b98563438d1ac20e6f29411ef1058cf4 --- M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/boardid.c 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/55950/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/55950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b7625f9b98563438d1ac20e6f29411ef1058cf4 Gerrit-Change-Number: 55950 Gerrit-PatchSet: 4 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbfstool: Remove legacy cbfs support
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56001 to look at the new patch set (#8). Change subject: util/cbfstool: Remove legacy cbfs support ...................................................................... util/cbfstool: Remove legacy cbfs support FMAP has been there for quite some time and the coreboot code itself cannot handle legacy images anymore so it makes sense to drop support in cbfstool itself. Change-Id: I2f34a25dae1ec1924cabe392dcd1480d7b4fbf49 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbfstool/cbfs_image.c M util/cbfstool/cbfs_image.h M util/cbfstool/cbfstool.c M util/cbfstool/ifittool.c 4 files changed, 38 insertions(+), 295 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/56001/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/56001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f34a25dae1ec1924cabe392dcd1480d7b4fbf49 Gerrit-Change-Number: 56001 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbfstool: Remove legacy cbfs support
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56001 to look at the new patch set (#7). Change subject: util/cbfstool: Remove legacy cbfs support ...................................................................... util/cbfstool: Remove legacy cbfs support FMAP has been there for quite some time and the coreboot code itself cannot handle legacy images anymore so it makes sense to drop support in cbfstool itself. Change-Id: I2f34a25dae1ec1924cabe392dcd1480d7b4fbf49 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbfstool/cbfs_image.c M util/cbfstool/cbfs_image.h M util/cbfstool/cbfstool.c M util/cbfstool/ifittool.c 4 files changed, 38 insertions(+), 294 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/56001/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/56001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f34a25dae1ec1924cabe392dcd1480d7b4fbf49 Gerrit-Change-Number: 56001 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbfstool: Remove legacy cbfs support
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56001 to look at the new patch set (#6). Change subject: util/cbfstool: Remove legacy cbfs support ...................................................................... util/cbfstool: Remove legacy cbfs support FMAP has been there for quite some time and the coreboot code itself cannot handle legacy images anymore so it makes sense to drop support in cbfstool itself. Change-Id: I2f34a25dae1ec1924cabe392dcd1480d7b4fbf49 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M util/cbfstool/cbfs_image.c M util/cbfstool/cbfs_image.h M util/cbfstool/cbfstool.c M util/cbfstool/ifittool.c 4 files changed, 38 insertions(+), 294 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/56001/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/56001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f34a25dae1ec1924cabe392dcd1480d7b4fbf49 Gerrit-Change-Number: 56001 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: [TESTONLY]See if Jenkins reacts differently.
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56040 ) Change subject: [TESTONLY]See if Jenkins reacts differently. ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/56040 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia4fe574f114dac80b2eda77553dafb5b2a1b7049 Gerrit-Change-Number: 56040 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: cpu/intel/common: Add CAR debug Kconfig CPU_CAR_DEBUG
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Subrata Banik, Patrick Rudolph, EricR Lai. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55653 ) Change subject: cpu/intel/common: Add CAR debug Kconfig CPU_CAR_DEBUG ...................................................................... Patch Set 2: (1 comment) File src/cpu/intel/common/common_init.c: https://review.coreboot.org/c/coreboot/+/55653/comment/deb3c4a5_8a1c2462 PS2, Line 369: 4ULL * GiB - 64 * KiB > > I guess you are trying to avoid the bootblock here, while you're calling this inside the bootblock? > > Make this explicit? > > 1) Don't run this !ENV_BOOTBLOCK > > won't earlier comment will take care of this as well? > > Arthur Heymans > Jun 29 > Return if not ENV_CACHE_AS_RAM? > No, don't assume ENV_CACHE_AS_RAM == ENV_BOOTBLOCK. You explicitly want to avoid you current program. (_program, _eprogram) could work for both romstage and bootblock (ENV_CACHE_AS_RAM) but some extra care needs to be taken for bootblock since _eprogram does not quite cover the full bootblock. > > 2) explicitly avoid addresses inside _bootblock/_ebootblock instead of making the hardcoded assumption on a 64K bootblock, which btw is simply not the case anymore in coreboot. -- To view, visit https://review.coreboot.org/c/coreboot/+/55653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb1e644f154b8f8d8da41ba8084e99827e7eff23 Gerrit-Change-Number: 55653 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 05 Jul 2021 17:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: configs: Build test x86_64 on Sandy Bridge
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55472 ) Change subject: configs: Build test x86_64 on Sandy Bridge ...................................................................... configs: Build test x86_64 on Sandy Bridge Add defconfig to build test x86_64 code on Sandy Bridge. Change-Id: I2c18af8bfa87636c68741e4759059276c287d052 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55472 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrik Tesarik <depate(a)das-labor.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- A configs/config.hp_compaq_8200_elite_sff_pc.x86_64 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Patrik Tesarik: Looks good to me, but someone else must approve diff --git a/configs/config.hp_compaq_8200_elite_sff_pc.x86_64 b/configs/config.hp_compaq_8200_elite_sff_pc.x86_64 new file mode 100644 index 0000000..9bb5e38 --- /dev/null +++ b/configs/config.hp_compaq_8200_elite_sff_pc.x86_64 @@ -0,0 +1,3 @@ +CONFIG_VENDOR_HP=y +CONFIG_BOARD_HP_COMPAQ_8200_ELITE_SFF_PC=y +CONFIG_USE_EXP_X86_64_SUPPORT=y -- To view, visit https://review.coreboot.org/c/coreboot/+/55472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c18af8bfa87636c68741e4759059276c287d052 Gerrit-Change-Number: 55472 Gerrit-PatchSet: 12 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrik Tesarik <depate(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: configs: Build test x86_64 on Sandy Bridge
by Arthur Heymans (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Patrick Rudolph, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55472 ) Change subject: configs: Build test x86_64 on Sandy Bridge ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c18af8bfa87636c68741e4759059276c287d052 Gerrit-Change-Number: 55472 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrik Tesarik <depate(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Jul 2021 16:49:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: configs: Build test x86_64 on Sandy Bridge
by Patrik Tesarik (Code Review) 05 Jul '21

05 Jul '21

Attention is currently required from: Patrick Rudolph, Angel Pons, Arthur Heymans. Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55472 ) Change subject: configs: Build test x86_64 on Sandy Bridge ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c18af8bfa87636c68741e4759059276c287d052 Gerrit-Change-Number: 55472 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrik Tesarik <depate(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 05 Jul 2021 16:32:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021