Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Angel Pons, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50996 )
Change subject: mb/adlrvp: Fix DDR5 Boot issue
......................................................................
Patch Set 14:
(22 comments)
File src/soc/intel/alderlake/meminit.c:
Robot Comment from …
[View More]checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/cd5419c1_03d67ea1
PS14, Line 222: static const int spd_array[] = { 0xA0, 0xA2, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xA4, 0xA6,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/a0d99870_01f73c1d
PS14, Line 223: 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 };
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/e9fdc8f3_b445d5f9
PS14, Line 225: for (int i = 0; i < 16; i++)
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/71c401fb_5128d542
PS14, Line 225: for (int i = 0; i < 16; i++)
suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/1a818022_baa3171d
PS14, Line 226: mem_cfg->SpdAddressTable[i] = spd_array[i];
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/d9272dfe_827c14ae
PS14, Line 226: mem_cfg->SpdAddressTable[i] = spd_array[i];
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/4c6b5faf_23011023
PS14, Line 266: if (!smbus_address_valid) {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/ef3ef5bd_08f68e16
PS14, Line 266: if (!smbus_address_valid) {
suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/faa7f597_988d2c9a
PS14, Line 267: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/4e7298c1_6f5720ac
PS14, Line 267: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/8bd68f9f_803cee68
PS14, Line 267: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/4f494712_14c2fdd3
PS14, Line 268: mem_init_spd_upds(mem_cfg, &data);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/def993d9_6bc950a9
PS14, Line 268: mem_init_spd_upds(mem_cfg, &data);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/17d1aa39_891abc84
PS14, Line 269: } else {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/fec9a130_baf9db2c
PS14, Line 269: } else {
suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/ca8c4398_5103cde0
PS14, Line 270: mem_init_smbus_fill_upd(mem_cfg);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/0a2efb80_34c52761
PS14, Line 270: mem_init_smbus_fill_upd(mem_cfg);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/f1c97014_50540783
PS14, Line 271: mem_init_dq_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/d6eca2a6_4f658000
PS14, Line 271: mem_init_dq_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/9722b579_41b54d03
PS14, Line 272: mem_init_dqs_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/c4c1ab2c_fd2f945f
PS14, Line 272: mem_init_dqs_upds(mem_cfg, &data, mb_cfg, dq_dqs_auto_detect);
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123628):
https://review.coreboot.org/c/coreboot/+/50996/comment/66ba295a_c555caad
PS14, Line 273: }
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/50996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9998bfcd12b81c11fcc9f791da2a27d3c788e48a
Gerrit-Change-Number: 50996
Gerrit-PatchSet: 14
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 08 Jul 2021 06:25:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Paul Menzel, Subrata Banik, Angel Pons.
Hello Bora Guvendik, build bot (Jenkins), Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50996
to look at the new patch set (#14).
Change subject: mb/adlrvp: Fix DDR5 Boot issue
................................................................…
[View More]......
mb/adlrvp: Fix DDR5 Boot issue
The coreboot SMBus driver requires additional changes
to accomodate the DDR5 EEPROM read which has resulted in a
broken code flow for boot.
This CL serves as a temp WA to let FSP perform the SPD read
for DDR5 and pass SPD addresses to FSP UPD array.
BUG=b:180458099
TEST=Build and boot DDR5 adlrvp to OS
Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com>
Change-Id: I9998bfcd12b81c11fcc9f791da2a27d3c788e48a
---
M src/mainboard/intel/adlrvp/romstage_fsp_params.c
M src/soc/intel/alderlake/meminit.c
2 files changed, 25 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/50996/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/50996
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9998bfcd12b81c11fcc9f791da2a27d3c788e48a
Gerrit-Change-Number: 50996
Gerrit-PatchSet: 14
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, John Zhao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/c4c8cc1f_6e70d967
PS4, Line 129: static …
[View More]struct acpi_pld pld;
> True Furquan... […]
We can't just remove `static` keyword. Instead, the caller will have to pass in a structure that will be filled by this function. Else, `pld` lives on the stack which gets destroyed on return from this function and the caller ends up referencing an invalid object.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 06:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, John Zhao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55946
to look at the new patch set (#9).
Change subject: mb/google/brya,primus,voxel: Update controller field for tbt_dma entries
......................................................................
mb/google/brya,primus,voxel: Update controller field …
[View More]for tbt_dma entries
We need to reference correct USB port number for driver to
identify type-C port number correctly.
BUG=b:189476816
BRANCH=None
TEST=Check the transactions are happening on correct port. Also checked
retimer firmware update on both the ports.
Change-Id: I20c088ee81610155067abad086eba8d72f73ad60
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/volteer/variants/voxel/overridetree.cb
3 files changed, 12 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/55946/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/55946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20c088ee81610155067abad086eba8d72f73ad60
Gerrit-Change-Number: 55946
Gerrit-PatchSet: 9
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com>
Gerrit-CC: Deepti Deshatty <deepti.deshatty(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-MessageType: newpatchset
[View Less]
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, John Zhao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123622):
https://review.…
[View More]coreboot.org/c/coreboot/+/56024/comment/87a4cff2_bb5904f3
PS5, Line 135: if (config->use_custom_pld)
trailing whitespace
--
To view, visit https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 05:57:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, John Zhao.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 5:
(2 comments)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/ad66fefb_954e7cfb
PS4, Line 129: static …
[View More]struct acpi_pld pld;
> If `usb_acpi_get_pld()` gets called for multiple ports back to back, then the information will get o […]
True Furquan...Let me remove static since anyone calling this function is passing usb_device reference anyway, so we should get information everytime from usb_device.
https://review.coreboot.org/c/coreboot/+/56024/comment/0442281e_6ec5d304
PS4, Line 135: if (config->use_custom_pld) {
: /* Use board defined PLD */
: memcpy(&pld, &config->custom_pld, sizeof(pld));
: } else {
: /* Fill PLD strucutre based on port type */
: acpi_pld_fill_usb(&pld, config->type, &config->group);
: }
> nit: I don't think the braces or comments are necessary
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 5
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 05:57:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
[View Less]
Attention is currently required from: Maulik V Vaghela, John Zhao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/53e01472_90e27f6f
PS4, Line 129: static struct acpi_pld pld;
…
[View More]If `usb_acpi_get_pld()` gets called for multiple ports back to back, then the information will get overwritten.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaf140ce1965dce3a812aa2701ce0e29b34ab3e7
Gerrit-Change-Number: 56024
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Abhijeet Rao <abhijeet.rao(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 05:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
[View Less]