John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52714 )
Change subject: mb/google/volteer: Update mainboard properties
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52714
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18f29ce5f8450a8b0f8208a60b8b607f9f0d8817
Gerrit-Change-Number: 52714
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 May 2021 17:03:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52713 )
Change subject: ec/google/chromeec: Provide EC access for Retimer firmware upgrade
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib937d8bd72fc39487854773573b435bf2add672a
Gerrit-Change-Number: 52713
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 May 2021 17:03:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 )
Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
......................................................................
Patch Set 3:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52712
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406
Gerrit-Change-Number: 52712
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 May 2021 17:03:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52711 )
Change subject: mb/google/volteer: Remove power_gpio from baseboard
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2437ab20d283d080752a80aa4514aa9af6897e
Gerrit-Change-Number: 52711
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 May 2021 17:03:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52710 )
Change subject: ec/google/chromeec: Remove ec_retimer_fw_update
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52710
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d074b84fb3cb87b443871104b72b6c316af5279
Gerrit-Change-Number: 52710
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 04 May 2021 17:02:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52866 )
Change subject: drivers/intel/fsp2_0: Add mb hooks before & after FSP calls
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/intel/fsp2_0/include/fsp/api.h:
https://review.coreboot.org/c/coreboot/+/52866/comment/aa83078f_95790d93
PS1, Line 75: save and restore registers
> Sure, but this is being done on the mainboard level, not the platform level. […]
I think the workarounds that are required would generally be applicable to all mainboards for a platform. If FSP absolutely cannot be fixed, I think it is better to apply it at the SoC level so that all mainboards benefit from it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc6eb95fa8a1114234cfd7467507992c25669f1
Gerrit-Change-Number: 52866
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 04 May 2021 16:51:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52763 )
Change subject: soc/amd/common: Add placeholder GPIO macro, PAD_UNCHANGED
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52763/comment/191219cd_91182a03
PS1, Line 9: GPIOs can only be updated in gpio_configure_pads_with_override() if they
: are present in the base table. If they are not there, the override
: does not work. This allows them to be in the base table so that they can
: be overridden without changing the existing configuration.
> How about instead of requiring that everything be programmed in romstage, we add a check at finalize […]
What do you compare against to determine if all GPIOs are programmed as we want it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/52763
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e5e7b7d30f2c89fa1db375ddba394e6914d97b9
Gerrit-Change-Number: 52763
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 04 May 2021 16:49:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment