Attention is currently required from: Sam McNally, Tony Huang, Tim Wawrzynczak, Edward O'Callaghan, Wisley Chen.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52725/comment/bb3baade_f7df73f5
PS10, Line 9: Follow touchpad to set interrupt gpio to PAD_CFG_GPI_IRQ_WAKE.
> Can you please rephrase this as: […]
Done. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 11
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 05 May 2021 04:36:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sam McNally, Tim Wawrzynczak, Edward O'Callaghan, Wisley Chen.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52725/comment/d1ca2893_f44fda5d
PS10, Line 9: Follow touchpad to set interrupt gpio to PAD_CFG_GPI_IRQ_WAKE.
> Can you please rephrase this as: […]
Done, thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 11
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 05 May 2021 04:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sam McNally, Tony Huang, Tim Wawrzynczak, Edward O'Callaghan, Wisley Chen.
Hello Sam McNally, build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Edward O'Callaghan, Keith Tzeng, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52725
to look at the new patch set (#11).
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
mb/google/puff/var/dooly: enable touchscreen wakeup
Configure GPP_A20 as PAD_CFG_GPI_IRQ_WAKE to enable interrupt and wake routes for touchscreen device.
BUG=b:186070097
BRANCH=puff
TEST=Build and make sure TS works to wakeup suspend/resume.
Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/hatch/variants/dooly/gpio.c
M src/mainboard/google/hatch/variants/dooly/overridetree.cb
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/52725/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 11
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rocky Phagura.
Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52918 )
Change subject: src/console: add interrupt enable and status methods
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/52918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e6fe8b82dd6b4d10f84ef4ac28c7cddc71c1bc9
Gerrit-Change-Number: 52918
Gerrit-PatchSet: 2
Gerrit-Owner: Rocky Phagura
Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com>
Gerrit-Comment-Date: Wed, 05 May 2021 04:14:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sam McNally, Tony Huang, Tim Wawrzynczak, Edward O'Callaghan, Wisley Chen.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52725/comment/11d95d9d_bb6027f2
PS10, Line 9: Follow touchpad to set interrupt gpio to PAD_CFG_GPI_IRQ_WAKE.
Can you please rephrase this as:
Configure GPP_A20 as PAD_CFG_GPI_IRQ_WAKE to enable interrupt and wake routes for touchscreen device.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 10
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 05 May 2021 04:04:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sam McNally, Furquan Shaikh, Tony Huang, Tim Wawrzynczak, Edward O'Callaghan, Wisley Chen.
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52725 )
Change subject: mb/google/puff/var/dooly: enable touchscreen wakeup
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
please help review. thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bbaab56924849a22a4d05ce53bf5bdcf00265dd
Gerrit-Change-Number: 52725
Gerrit-PatchSet: 10
Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sam McNally <sammc(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 05 May 2021 03:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment