Attention is currently required from: Nico Huber, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Marcello Sylvester Bauer.
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Michael Niewöhner, Marcello Sylvester Bauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50194
to look at the new patch set (#18).
Change subject: [RFC] util/liveiso: Add NixOS config for a testing live system
......................................................................
[RFC] util/liveiso: Add NixOS config for a testing live system
Add a NixOS configuration for a bootable live system containing a set of
tools which might be useful for working on firmware in general and
coreboot.
It can be built using build-console.sh, which requires Nix utilities to
be installed.
After building, the resulting iso image can be found in
`result/iso/nixos.iso` and its size is about 700MB.
An additional configuration for a variant with Gnome Shell as window
manager installed is WIP.
Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M MAINTAINERS
A util/liveiso/.gitignore
A util/liveiso/build-console.sh
A util/liveiso/build-graphical.sh
A util/liveiso/console.nix
A util/liveiso/description.md
A util/liveiso/graphical.nix
7 files changed, 200 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/50194/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/50194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Gerrit-Change-Number: 50194
Gerrit-PatchSet: 18
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-MessageType: newpatchset
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54020 )
Change subject: src/security/intel/stm: Add warning for non-reproducible build
......................................................................
src/security/intel/stm: Add warning for non-reproducible build
Because the STM build doesn't use the coreboot toolchain it's not
reproducible. Make sure that's displayed during the build.
Signed-off-by: Martin Roth <martin(a)coreboot.org>
Change-Id: I3f0101400dc221eca09c928705f30d30492f171f
---
M src/security/intel/stm/Makefile
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/54020/1
diff --git a/src/security/intel/stm/Makefile b/src/security/intel/stm/Makefile
index 1493869..31e5bdd 100644
--- a/src/security/intel/stm/Makefile
+++ b/src/security/intel/stm/Makefile
@@ -18,6 +18,8 @@
build:
echo "STM - Build"
+ echo "-- WARNING: This uses the system toolchain instead of"
+ echo " the coreboot toolchain, so is not reproducible."
cd $(project_dir)/Stm; \
mkdir -p build; \
cd build; \
--
To view, visit https://review.coreboot.org/c/coreboot/+/54020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0101400dc221eca09c928705f30d30492f171f
Gerrit-Change-Number: 54020
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Michael Niewöhner, Patrick Rudolph, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )
Change subject: [RFC] device: Introduce new method for setting device states
......................................................................
Patch Set 22:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52493/comment/c79160d9_88d27d54
PS22, Line 7: [RFC]
I think everyone likes this enough you can drop the RFC 😊
File src/include/device/devenmap.h:
https://review.coreboot.org/c/coreboot/+/52493/comment/87b1ce73_6bf46af4
PS22, Line 12: option
what about naming this one `upd` ?
https://review.coreboot.org/c/coreboot/+/52493/comment/c6aba323_b0a98577
PS22, Line 13: pci_devfn_t
`PCH_DEVFN` and friends are `unsigned int`, *not* `pci_devfn_t`; `PCI_DEV` creates a `pci_devfn_t`... I mess this up all of the time 😊
https://review.coreboot.org/c/coreboot/+/52493/comment/0a2cbe2d_42ebd07c
PS22, Line 14: hook
maybe `enable_cb` (enable callback) or similar? `hook` seems kinda generic
https://review.coreboot.org/c/coreboot/+/52493/comment/78f587f1_240fa40c
PS22, Line 18: set_dev_state_by_devicetree
I think the name of this function should include `fsp` or `upd` to make it a little more clear what's going on.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52493
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70fde306c65a8881f565c5f923be20f380ea64d3
Gerrit-Change-Number: 52493
Gerrit-PatchSet: 22
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 10 May 2021 17:07:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/53939
to look at the new patch set (#5).
Change subject: mb/clevo/n130wu: Use device alias names in devicetree
......................................................................
mb/clevo/n130wu: Use device alias names in devicetree
Switch to device alias names in devicetree. Remove unnecessary comments
since the names are self-explanatory.
Change-Id: Id486d9bd44bd7ba6a93a5f757af487b211e58efa
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/53939/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/53939
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id486d9bd44bd7ba6a93a5f757af487b211e58efa
Gerrit-Change-Number: 53939
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53939 )
Change subject: mb/clevo/n130wu: Use device alias names in devicetree
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/53939
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id486d9bd44bd7ba6a93a5f757af487b211e58efa
Gerrit-Change-Number: 53939
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Mon, 10 May 2021 16:45:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53937 )
Change subject: mb/clevo/n130wu: Remove host bridge from devicetree
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/53937/comment/819a0ca0_26d5983e
PS1, Line 47: device pci 00.0 on end # Host Bridge
well, we started moving fsp upds from above down to the devicetrees. Probably we should first move all of them down and then start dropping what is left without options. `SaGv` would go to this one
--
To view, visit https://review.coreboot.org/c/coreboot/+/53937
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44d5ee82ce8b8d5c092feca2562f763a3fbb3cae
Gerrit-Change-Number: 53937
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Mon, 10 May 2021 16:45:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Sheng-Liang Pan, YH Lin.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53907 )
Change subject: mb/google/volteer: Create chronicler variant
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/53907
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018
Gerrit-Change-Number: 53907
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Mon, 10 May 2021 16:45:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Angel Pons, Arthur Heymans, Michael Niewöhner.
Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Patrick Georgi, Tim Wawrzynczak, Paul Menzel, Angel Pons, Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52297
to look at the new patch set (#7).
Change subject: docs: add recommendation for gpios regarding soft straps
......................................................................
docs: add recommendation for gpios regarding soft straps
Soft straps, that can be configured by the vendor in the Intel Flash
Image Tool (FIT), can influence some pads' default state. It is possible
to select either a native function or GPIO mode for some pads on
non-server SoCs, while on server SoCs most pads can be controlled.
Thus, add a recommendation to always configure all pads for a board to
guarantee integrity between different board or vendor firmware revisions
where the soft straps might have been changed.
Change-Id: I33063a3f6a1c9cd5267d85f7da84deb554489a26
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
---
M Documentation/getting_started/gpio.md
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/52297/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/52297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33063a3f6a1c9cd5267d85f7da84deb554489a26
Gerrit-Change-Number: 52297
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: newpatchset