coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: [DO NOT SUBMIT YET] vc/amd/pi/00630F01: Remove unused directory and code
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Michał Żygowski, Marshall Dawson, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53994 ) Change subject: [DO NOT SUBMIT YET] vc/amd/pi/00630F01: Remove unused directory and code ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/53994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f990e44e0f769219a6f80cf1369f6a3c94b3509 Gerrit-Change-Number: 53994 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 10 May 2021 20:05:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/amd/pi/00630F01: Remove unused directory and code
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Michał Żygowski, Marshall Dawson, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53993 ) Change subject: cpu/amd/pi/00630F01: Remove unused directory and code ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/53993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If270c2a979346029748230952caba78a5e763d75 Gerrit-Change-Number: 53993 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 10 May 2021 20:05:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Fix typo
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53926 ) Change subject: cpu/x86/smm: Fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/53926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28f262078cf7f5ec4ed707639e845710a8cc56ea Gerrit-Change-Number: 53926 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 10 May 2021 20:05:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/releases: Fill in coreboot 4.14 release notes
by Angel Pons (Code Review) 10 May '21

10 May '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54003 ) Change subject: Documentation/releases: Fill in coreboot 4.14 release notes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79530c91424112247e485a5a41debc666e0072d4 Gerrit-Change-Number: 54003 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 May 2021 20:03:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/relnotes/4.14: add Intel Xeon-SP support status change
by Angel Pons (Code Review) 10 May '21

10 May '21

Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Stefan Reinauer, David Hendricks, Subrata Banik, ron minnich. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52735 ) Change subject: doc/relnotes/4.14: add Intel Xeon-SP support status change ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibead1c75bb4e41fedc2799366b5b006d76fc8f4e Gerrit-Change-Number: 52735 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 10 May 2021 20:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: doc/relnotes/4.14: add Intel Xeon-SP support status change
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Stefan Reinauer, David Hendricks, Angel Pons, Subrata Banik, ron minnich. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52735 ) Change subject: doc/relnotes/4.14: add Intel Xeon-SP support status change ...................................................................... Patch Set 7: (2 comments) File Documentation/releases/coreboot-4.14-relnotes.md: https://review.coreboot.org/c/coreboot/+/52735/comment/327a5047_1e6b9fb5 PS6, Line 69: soc > sorry, here too Done https://review.coreboot.org/c/coreboot/+/52735/comment/7f7270f1_bee20fb2 PS6, Line 76: [1] https://www.intel.in/content/www/in/en/products/details/processors/xeon/sca… > nit: I'd use the en_US page: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibead1c75bb4e41fedc2799366b5b006d76fc8f4e Gerrit-Change-Number: 52735 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Mon, 10 May 2021 20:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/releases: Fill in coreboot 4.14 release notes
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54003 to look at the new patch set (#2). Change subject: Documentation/releases: Fill in coreboot 4.14 release notes ...................................................................... Documentation/releases: Fill in coreboot 4.14 release notes Change-Id: I79530c91424112247e485a5a41debc666e0072d4 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/releases/coreboot-4.14-relnotes.md 1 file changed, 67 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/54003/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79530c91424112247e485a5a41debc666e0072d4 Gerrit-Change-Number: 54003 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: doc/relnotes/4.14: add Intel Xeon-SP support status change
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Christian Walter, Stefan Reinauer, David Hendricks, Subrata Banik, ron minnich. Patrick Georgi has uploaded a new patch set (#7) to the change originally created by Jonathan Zhang. ( https://review.coreboot.org/c/coreboot/+/52735 ) Change subject: doc/relnotes/4.14: add Intel Xeon-SP support status change ...................................................................... doc/relnotes/4.14: add Intel Xeon-SP support status change Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com> Change-Id: Ibead1c75bb4e41fedc2799366b5b006d76fc8f4e --- M Documentation/releases/coreboot-4.14-relnotes.md 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/52735/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/52735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibead1c75bb4e41fedc2799366b5b006d76fc8f4e Gerrit-Change-Number: 52735 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbfstool: several fixes to build on OpenBSD
by Idwer Vollering (Code Review) 10 May '21

10 May '21

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54022 ) Change subject: util/cbfstool: several fixes to build on OpenBSD ...................................................................... util/cbfstool: several fixes to build on OpenBSD This was done on OpenBSD 6.8 Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> Change-Id: I69ca92175abef8d38c7bad2b2e9ed40f5cdd1d32 --- M util/cbfstool/Makefile.inc M util/cbfstool/swab.h 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/54022/1 diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 5b49fe8..89f0a06 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -113,6 +113,10 @@ TOOLLDFLAGS ?= HOSTCFLAGS += -fms-extensions +ifeq ($(shell uname -s 2>/dev/null), OpenBSD) +TOOLLDFLAGS += -Wl,-z,notext +endif + ifeq ($(shell uname -s | cut -c-7 2>/dev/null), MINGW32) TOOLCFLAGS += -mno-ms-bitfields endif diff --git a/util/cbfstool/swab.h b/util/cbfstool/swab.h index a45a767..2ab9922 100644 --- a/util/cbfstool/swab.h +++ b/util/cbfstool/swab.h @@ -15,7 +15,7 @@ * */ -#if !defined(__APPLE__) && !defined(__NetBSD__) +#if !defined(__APPLE__) && !defined(__NetBSD__) && !defined(__OpenBSD__) #define ntohl(x) (is_big_endian() ? (uint32_t)(x) : swab32(x)) #define htonl(x) (is_big_endian() ? (uint32_t)(x) : swab32(x)) #else -- To view, visit https://review.coreboot.org/c/coreboot/+/54022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69ca92175abef8d38c7bad2b2e9ed40f5cdd1d32 Gerrit-Change-Number: 54022 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: doc/releases/coreboot-4.14: Add x86 bootblock and ACPI GNVS changes
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54008 ) Change subject: doc/releases/coreboot-4.14: Add x86 bootblock and ACPI GNVS changes ...................................................................... doc/releases/coreboot-4.14: Add x86 bootblock and ACPI GNVS changes Change-Id: Ifa58a9ac7c6dcc391cd9942295319a8677cd4492 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54008 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Documentation/releases/coreboot-4.14-relnotes.md 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Werner Zeh: Looks good to me, approved Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved diff --git a/Documentation/releases/coreboot-4.14-relnotes.md b/Documentation/releases/coreboot-4.14-relnotes.md index 6b629f4..b6c927e 100644 --- a/Documentation/releases/coreboot-4.14-relnotes.md +++ b/Documentation/releases/coreboot-4.14-relnotes.md @@ -61,4 +61,19 @@ moved to the common AMD SoC code, so that they could be used by the Cezanne code instead of adding another slightly different copy. +### X86 bootblock layout + +The static size C_ENV_BOOTBLOCK_SIZE was mostly dropped in favor of +dynamically allocating the stage size; the Kconfig is still available +to use as a fixed size and to enforce a maximum for selected chipsets. +Linker sections are now top-aligned for a reduced flash footprint and to +maintain the requirements of near jump from reset vector. + +### ACPI GNVS framework + +SMI handlers for APM_CNT_GNVS_UDPATE were dropped; GNVS pointer to SMM is +now passed from within SMM_MODULE_LOADER. Allocation and initialisations +for common ACPI GNVS table entries were largely moved to one centralized +implementation. + ### Add significant changes here -- To view, visit https://review.coreboot.org/c/coreboot/+/54008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa58a9ac7c6dcc391cd9942295319a8677cd4492 Gerrit-Change-Number: 54008 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021