coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: util/cbfstool: several fixes to build on OpenBSD
by Idwer Vollering (Code Review) 11 May '21

11 May '21

Attention is currently required from: David Hendricks. Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54022 ) Change subject: util/cbfstool: several fixes to build on OpenBSD ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This depends on a (pending) change in vboot_reference. This depends on vboot_reference: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_refere… -- To view, visit https://review.coreboot.org/c/coreboot/+/54022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69ca92175abef8d38c7bad2b2e9ed40f5cdd1d32 Gerrit-Change-Number: 54022 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Mon, 10 May 2021 22:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Idwer Vollering <vidwer(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Configure wake resource for WiFi
by Karthik Ramasubramanian (Code Review) 10 May '21

10 May '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Mathew King. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52908 ) Change subject: mb/google/guybrush: Configure wake resource for WiFi ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52908/comment/167fb511_fa5c0ce0 PS1, Line 13: is added to SSDT. > > At what point did you check it? IIUC, it gets set on the suspend path in kernel. […] Performed a rogue experiment of setting the bit corresponding to GEVENT_8 in SMI:event_enable register as part of S0ix entry. With that bit set, I was able to wakeup the system using Wake on WLAN disconnect. [ 852.973207] rtw_8822ce 0000:01:00.0: Unknown wakeup reason 4 -- To view, visit https://review.coreboot.org/c/coreboot/+/52908 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic238d9606aea20c058e9b47093693f10b14e6288 Gerrit-Change-Number: 52908 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Mathew King <mathewk(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Mathew King <mathewk(a)chromium.org> Gerrit-Comment-Date: Mon, 10 May 2021 21:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Enable CR50 TPM support over SPI
by Thejaswani Putta (Code Review) 10 May '21

10 May '21

Attention is currently required from: Cliff Huang, Selma Bensaid, Bernardo Perez Priego, Thejaswani Putta. Hello Bora Guvendik, Anil Kumar K, build bot (Jenkins), Cliff Huang, Selma Bensaid, Bernardo Perez Priego, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54023 to look at the new patch set (#2). Change subject: mb/intel/adlrvp_m: Enable CR50 TPM support over SPI ...................................................................... mb/intel/adlrvp_m: Enable CR50 TPM support over SPI Add Kconfig options and enable TPM device in devicetree BUG: SYSCROS-57029 TEST:Booted the image and checked the successful TPM communication in verstage,romstage & ramstage from coreboot logs. Signed-off-by: Thejaswani Puta thejaswani.putta(a)intel.com <thejaswani.putta(a)intel.com> Change-Id: Icaedf9f17e35e82c35cbabd6d2938c167e42e9e8 --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/devicetree_m.cb M src/mainboard/intel/adlrvp/early_gpio_m.c M src/mainboard/intel/adlrvp/gpio_m.c 4 files changed, 45 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/54023/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icaedf9f17e35e82c35cbabd6d2938c167e42e9e8 Gerrit-Change-Number: 54023 Gerrit-PatchSet: 2 Gerrit-Owner: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Enable CR50 TPM support over SPI
by Bora Guvendik (Code Review) 10 May '21

10 May '21

Attention is currently required from: Cliff Huang, Selma Bensaid, Bernardo Perez Priego, Thejaswani Putta. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54023 ) Change subject: mb/intel/adlrvp_m: Enable CR50 TPM support over SPI ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/54023/comment/de119634_9983d2c8 PS1, Line 14: Coreboot coreboot logs. File src/mainboard/intel/adlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/54023/comment/8e914619_ed94a60c PS1, Line 22: select MAINBOARD_HAS_TPM2 : select MAINBOARD_HAS_SPI_TPM_CR50 : select SPI_TPM : Are we enabling for ADLRVP_P also? or ADLRVP_M only? -- To view, visit https://review.coreboot.org/c/coreboot/+/54023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icaedf9f17e35e82c35cbabd6d2938c167e42e9e8 Gerrit-Change-Number: 54023 Gerrit-PatchSet: 1 Gerrit-Owner: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Comment-Date: Mon, 10 May 2021 21:42:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Doc/nb/intel/sandybridge: Fix up some typos and cosmetics
by Angel Pons (Code Review) 10 May '21

10 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54035 ) Change subject: Doc/nb/intel/sandybridge: Fix up some typos and cosmetics ...................................................................... Doc/nb/intel/sandybridge: Fix up some typos and cosmetics Change-Id: I23b0c94ec9881aef8e39a14bc048856a65a6286d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M Documentation/northbridge/intel/sandybridge/index.md M Documentation/northbridge/intel/sandybridge/nri.md M Documentation/northbridge/intel/sandybridge/nri_registers.md 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/54035/1 diff --git a/Documentation/northbridge/intel/sandybridge/index.md b/Documentation/northbridge/intel/sandybridge/index.md index c1d4b99..27fbb2cc2 100644 --- a/Documentation/northbridge/intel/sandybridge/index.md +++ b/Documentation/northbridge/intel/sandybridge/index.md @@ -4,6 +4,6 @@ ## Topics -- [Native Ram Initialization](nri.md) +- [Native RAM Initialization](nri.md) - [RAM initialization feature matrix](nri_features.md) - [ME Cleaner](me_cleaner.md) diff --git a/Documentation/northbridge/intel/sandybridge/nri.md b/Documentation/northbridge/intel/sandybridge/nri.md index 812cd23..bf0b89f 100644 --- a/Documentation/northbridge/intel/sandybridge/nri.md +++ b/Documentation/northbridge/intel/sandybridge/nri.md @@ -40,7 +40,7 @@ +---------+-------------------------------------------------------------------+------------+--------------+ ``` -## (Inoffical) register documentation +## (Unoffical) register documentation - [Sandy Bridge - Register documentation](nri_registers.md) ## Frequency selection @@ -83,7 +83,7 @@ > **Note:** This feature is available since coreboot 4.4 ### MRC cache -The name *MRC cache* might be missleading as in case of *Native ram init* +The name *MRC cache* might be misleading as in case of *Native RAM init* there's no MRC, but for historical reasons it's still named *MRC cache*. The MRC cache is part of flash memory that is writeable by coreboot. At the end of the boot process coreboot will write the RAM training results to diff --git a/Documentation/northbridge/intel/sandybridge/nri_registers.md b/Documentation/northbridge/intel/sandybridge/nri_registers.md index 8f85629..aae1205 100644 --- a/Documentation/northbridge/intel/sandybridge/nri_registers.md +++ b/Documentation/northbridge/intel/sandybridge/nri_registers.md @@ -1,9 +1,9 @@ -# Inoffical Documentation of Intel MCHBAR register space. +# Unofficial Documentation of Intel MCHBAR register space. The MCHBAR can be enabled by using register 0x48 of PCI(0:0:0) device. This documentation is incomplete and might be incorrect. -Please handle with care ! +Please handle with care! **MCHBAR + 0x4** -- To view, visit https://review.coreboot.org/c/coreboot/+/54035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23b0c94ec9881aef8e39a14bc048856a65a6286d Gerrit-Change-Number: 54035 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation/releases: Add more details about release notes
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54032 ) Change subject: Documentation/releases: Add more details about release notes ...................................................................... Documentation/releases: Add more details about release notes There are some steps when updating the release notes that are easily missed (see: I missed them for 4.14), so document them. Change-Id: Icdb69eb74f8dd3a7189eb8803b0259c4e6a31f96 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/releases/checklist.md 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/54032/1 diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index 7e66c4d..50d99f6 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -59,8 +59,9 @@ - [ ] If there are any deprecations announced for the following release, make sure that a list of currently affected boards and chipsets is part of the release notes. -- [ ] Finalize release notes (as much as possible), without specifying - release commit ids. +- [ ] Finalize release notes as much as possible +- [ ] Prepare release notes template for following release +- [ ] Update `Documentation/releases/index.md` - [ ] Run `util/vboot_list/vboot_list.sh` script to update the list of boards supported by vboot. @@ -68,7 +69,7 @@ - [ ] Select a commit ID to base the release upon, announce to IRC, ask for testing. - [ ] Test the commit selected for release. -- [ ] Update release notes with actual commit id, push to repo. +- [ ] Submit release notes - [ ] Create new release notes doc template for the next version. - [ ] Fill in the release date, remove "Upcoming release" and other filler from the current release notes. -- To view, visit https://review.coreboot.org/c/coreboot/+/54032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icdb69eb74f8dd3a7189eb8803b0259c4e6a31f96 Gerrit-Change-Number: 54032 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation/releases: Add 4.15 release notes template
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54031 ) Change subject: Documentation/releases: Add 4.15 release notes template ...................................................................... Documentation/releases: Add 4.15 release notes template Change-Id: I52bd1ee6b297ba08e335f5c65941b09f14689a00 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- A Documentation/releases/coreboot-4.15-relnotes.md M Documentation/releases/index.md 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/54031/1 diff --git a/Documentation/releases/coreboot-4.15-relnotes.md b/Documentation/releases/coreboot-4.15-relnotes.md new file mode 100644 index 0000000..6244cf6 --- /dev/null +++ b/Documentation/releases/coreboot-4.15-relnotes.md @@ -0,0 +1,16 @@ +Upcoming release - coreboot 4.15 +================================ + +The 4.15 release is planned for October 2021. + +Update this document with changes that should be in the release notes. + +* Please use Markdown. +* See the past few release notes for the general format. +* The chip and board additions and removals will be updated right + before the release, so those do not need to be added. + +Significant changes +------------------- + +### Add significant changes here diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index 081d1fc..78ad127 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -14,6 +14,7 @@ * [4.11 - November 2019](coreboot-4.11-relnotes.md) * [4.12 - May 2020](coreboot-4.12-relnotes.md) * [4.13 - November 2020](coreboot-4.13-relnotes.md) +* [4.14 - May 2021](coreboot-4.14-relnotes.md) The checklist contains instructions to ensure that a release covers all important things and provides a reliable format for tarballs, branch @@ -25,4 +26,4 @@ ---------------- Please add to the release notes as changes are added: -* [4.14 - May 2021](coreboot-4.14-relnotes.md) +* [4.15 - October 2021](coreboot-4.15-relnotes.md) -- To view, visit https://review.coreboot.org/c/coreboot/+/54031 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52bd1ee6b297ba08e335f5c65941b09f14689a00 Gerrit-Change-Number: 54031 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation/releases: Update checklist
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54030 ) Change subject: Documentation/releases: Update checklist ...................................................................... Documentation/releases: Update checklist Since we want commits to go through 24 hours of review, move the vboot list update a week earlier. Also point more directly at the right script to execute. Change-Id: I49e6dfe22894402d5a0526588f8a04595ac88862 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/releases/checklist.md 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/54030/1 diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index 3f19bfb..7e66c4d 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -61,6 +61,8 @@ part of the release notes. - [ ] Finalize release notes (as much as possible), without specifying release commit ids. +- [ ] Run `util/vboot_list/vboot_list.sh` script to update the list of + boards supported by vboot. ### Day of release - [ ] Select a commit ID to base the release upon, announce to IRC, @@ -71,7 +73,6 @@ - [ ] Fill in the release date, remove "Upcoming release" and other filler from the current release notes. - [ ] Run release script. -- [ ] Run vboot_list script. - [ ] Test the release from the actual release tarballs. - [ ] Push signed Tag to repo. - [ ] Announce that the release tag is done on IRC. -- To view, visit https://review.coreboot.org/c/coreboot/+/54030 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49e6dfe22894402d5a0526588f8a04595ac88862 Gerrit-Change-Number: 54030 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Documentation: Update vboot support list
by Patrick Georgi (Code Review) 10 May '21

10 May '21

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54029 ) Change subject: Documentation: Update vboot support list ...................................................................... Documentation: Update vboot support list Created by util/vboot_list/vboot_list.sh Change-Id: I49536c26540c0fd1940a32f588fa49afb55b108a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/security/vboot/list_vboot.md 1 file changed, 21 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/54029/1 diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index c9c2fdf..745db24 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -1,15 +1,23 @@ # vboot-enabled devices +## AMD +- Majolica + +## Clevo +- N130WU / N131WU + ## Emulation - QEMU x86 i440fx/piix4 (aka qemu -M pc) - QEMU x86 q35/ich9 (aka qemu -M q35, since v1.4) ## Facebook +- fbg1701 - Facebook Monolith ## Google - Asurada - Hayato +- Spherion - Auron_Paine (Acer C740 Chromebook) - Auron_Yuna (Acer Chromebook 15 (C910/CB5-531)) - Buddy (Acer Chromebase 24) @@ -22,6 +30,7 @@ - Tricky (Dell Chromebox 3010) - Zako (HP Chromebox G1) - Butterfly (HP Pavilion Chromebook 14) +- Cherry - Banon (Acer Chromebook 15 (CB3-532)) - Celes (Samsung Chromebook 3) - Cyan (Acer Chromebook R11 (C738T)) @@ -56,6 +65,7 @@ - Scarlet - Nefario - Rainier +- Guybrush - Akemi - Dratini - Duffy Legacy (32MB) @@ -79,6 +89,7 @@ - Dooly - Ambassador - Genesis +- Herobrine - Guado (ASUS Chromebox CN62) - Jecht - Rikku (Acer Chromebox CXI2) @@ -94,6 +105,7 @@ - Kodama - Kakadu - Flapjack +- Katsu - Jacuzzi - Juniper - Kappa @@ -104,7 +116,10 @@ - Esche - Burnet - Fennel +- Cozmo +- Makomo - Link (Google Chromebook Pixel (2013)) +- Mancomb - Mistral - Nyan - Nyan Big (Acer Chromebook 13 (CB5-311)) @@ -175,6 +190,7 @@ - Woomax - Dirinboz - Shuboz +- Gumboz ## HP - Z220 SFF Workstation @@ -182,14 +198,15 @@ ## Intel - Alderlake-P RVP - Alderlake-P RVP with Chrome EC +- Alderlake-M RVP +- Alderlake-M RVP with Chrome EC - Basking Ridge CRB -- Cannonlake U LPDDR4 RVP -- Cannonlake Y LPDDR4 RVP - Coffeelake U SO-DIMM DDR4 RVP - Coffeelake H SO-DIMM DDR4 RVP11 - Whiskeylake U DDR4 RVP - Coffeelake S U-DIMM DDR4 RVP8 - Cometlake U DDR4 RVP +- Elkhartlake LPDDR4x CRB - Emerald Lake 2 CRB - Galileo - Glkrvp @@ -202,6 +219,7 @@ - Kabylake DDR4 RVP8 - Kabylake DDR4 RVP11 - Kunimitsu +- shadowmountain - Strago - Tigerlake UP3 RVP - Tigerlake UP4 RVP @@ -255,7 +273,7 @@ ## Supermicro - X11SSH-TF - X11SSM-F -- X11SSH-F/X11SSH-LN4F +- X11SSH-F/LN4F ## UP - Squared -- To view, visit https://review.coreboot.org/c/coreboot/+/54029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49536c26540c0fd1940a32f588fa49afb55b108a Gerrit-Change-Number: 54029 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: payloads/Tianocore: Update default build target, simplify build options
by Matt DeVillier (Code Review) 10 May '21

10 May '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Angel Pons, Arthur Heymans. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54019 ) Change subject: payloads/Tianocore: Update default build target, simplify build options ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Intel GM45 and X4X targets don't work with UefiPayloadPkg but do with CorebootPayloadPkg. […] do those platforms work with `TIANOCORE_USE_8254_TIMER` selected? If so, could just select that as a default for ones that need it -- To view, visit https://review.coreboot.org/c/coreboot/+/54019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If545fbd0c30be6dcc6ff43107b80980fa23a527e Gerrit-Change-Number: 54019 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 10 May 2021 21:23:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021