Anil Kumar K has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/52681 )
Change subject: mb/intel/adlrvp: Set SKUID for adlrvp to 255
......................................................................
Abandoned
The change suggested is merged in the OS (internal RVP build) . not required in CB anymore
--
To view, visit https://review.coreboot.org/c/coreboot/+/52681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e501f995988b95c480637599412c8ddea0814dc
Gerrit-Change-Number: 52681
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Azhar Shaikh <azhar.shaikh(a)intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nathan D Ciobanu <nathan.d.ciobanu(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Ravi kumar, Martin Roth, mturney mturney, Julius Werner, Sudheer Amrabadi.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50582 )
Change subject: sc7280: add qclib support
......................................................................
Patch Set 33:
(1 comment)
Patchset:
PS33:
I think that you need https://review.coreboot.org/c/coreboot/+/54037 for this Jenkins to build.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50582
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d400f0ad96dbef2e45cc1f11ed17ea95fc60d16
Gerrit-Change-Number: 50582
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sudheer Amrabadi <samrab(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Sudheer Amrabadi <samrab(a)codeaurora.org>
Gerrit-Comment-Date: Mon, 10 May 2021 22:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54037 )
Change subject: 3rdparty/qc_blobs: Uprev to new HEAD (053eb2a)
......................................................................
3rdparty/qc_blobs: Uprev to new HEAD (053eb2a)
Now that Boot blobs have landed, need to uprev the qc_blobs.
Change-Id: I510de2d1e4334612c81f35a082dea92d445da0bb
Signed-off-by: Shelley Chen <shchen(a)google.com>
---
M 3rdparty/qc_blobs
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/54037/1
diff --git a/3rdparty/qc_blobs b/3rdparty/qc_blobs
index 02ba9a6..053eb2a 160000
--- a/3rdparty/qc_blobs
+++ b/3rdparty/qc_blobs
@@ -1 +1 @@
-Subproject commit 02ba9a6a362f67ccd097c285fa8a202dedd38631
+Subproject commit 053eb2ab5f89a8e2b2077fd70c9ae7ff945e440e
--
To view, visit https://review.coreboot.org/c/coreboot/+/54037
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I510de2d1e4334612c81f35a082dea92d445da0bb
Gerrit-Change-Number: 54037
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Maulik V Vaghela, Selma Bensaid, Tim Wawrzynczak, Patrick Rudolph.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54036 )
Change subject: [WIP]soc/intel/alderlake: Update meminit code due to upd changes FSP 2147 onwards
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Maulik, would you like to make https://review.coreboot.org/c/coreboot/+/52316 public and rebase under this patch?
--
To view, visit https://review.coreboot.org/c/coreboot/+/54036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5af11ae99db3bbe3373a9bd4ce36453b58d62fec
Gerrit-Change-Number: 54036
Gerrit-PatchSet: 1
Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 10 May 2021 22:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Angel Pons, Marco Chen, Karthik Ramasubramanian.
Vitaly Rodionov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52981 )
Change subject: drivers/i2c/cs42l42: Make HS_BIAS_SENSE_EN optional
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/i2c/cs42l42/chip.h:
https://review.coreboot.org/c/coreboot/+/52981/comment/0f95ae4f_c49ed928
PS4, Line 118: Default =
> In this case, coreboot will always generate the property, so the kernel default is meaningless.
Yes, you are right. We need to add this property only when we want to disable it.
https://review.coreboot.org/c/coreboot/+/52981/comment/bb212436_0571b917
PS4, Line 118: Default =
> In this case, coreboot will always generate the property, so the kernel default is meaningless.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/52981
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87c6f01af1bdb5b1cb8e399191519598d7fbe9ea
Gerrit-Change-Number: 52981
Gerrit-PatchSet: 4
Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 10 May 2021 22:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Vitaly Rodionov, Marco Chen, Karthik Ramasubramanian.
Hello build bot (Jenkins), Furquan Shaikh, Marco Chen, Karthik Ramasubramanian, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52981
to look at the new patch set (#5).
Change subject: drivers/i2c/cs42l42: Make HS_BIAS_SENSE_EN optional
......................................................................
drivers/i2c/cs42l42: Make HS_BIAS_SENSE_EN optional
HSBIAS_SENSE_EN configures HSBIAS output current sense through
the external 2.21-k resistor. HSBIAS_SENSE is hardware feature to reduce
the potential pop noise during the headset plug out slowly. But on some
platforms ESD voltage will affect it causing test to fail, especially
with CTIA headset type. For different hardware setups, a designer might
want to tweak default behavior.
Signed-off-by: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
Change-Id: I87c6f01af1bdb5b1cb8e399191519598d7fbe9ea
---
M src/drivers/i2c/cs42l42/chip.h
M src/drivers/i2c/cs42l42/cs42l42.c
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/52981/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/52981
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87c6f01af1bdb5b1cb8e399191519598d7fbe9ea
Gerrit-Change-Number: 52981
Gerrit-PatchSet: 5
Gerrit-Owner: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Vitaly Rodionov <vitaly.rodionov(a)cirrus.corp-partner.google.com>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset