Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney.
Hello Shelley Chen, build bot (Jenkins), Julius Werner, mturney mturney,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52662
to look at the new patch set (#5).
Change subject: sc7180: Add display support for mipi panels
......................................................................
sc7180: Add display support for mipi panels
Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f
Signed-off-by: Vinod Polimera <vpolimer(a)codeaurora.org>
---
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/mainboard.c
M src/soc/qualcomm/sc7180/Makefile.inc
M src/soc/qualcomm/sc7180/display/dsi.c
A src/soc/qualcomm/sc7180/display/panel_driver.c
M src/soc/qualcomm/sc7180/include/soc/display/mipi_dsi.h
A src/soc/qualcomm/sc7180/include/soc/display/panel.h
7 files changed, 328 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/52662/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/52662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f
Gerrit-Change-Number: 52662
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52131
to look at the new patch set (#8).
Change subject: sc7280: Enable bootblock compression
......................................................................
sc7280: Enable bootblock compression
This patch enables bootblock compression on SC7280. In my tests, that
makes it boot roughly 10ms faster (which isn't much, but... might as
well take it).
Ref link: https://review.coreboot.org/c/coreboot/+/45855
Change-Id: I3564a7e531d769c8df16a1592ea98133d83b07b0
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
---
M src/soc/qualcomm/sc7280/Kconfig
M src/soc/qualcomm/sc7280/Makefile.inc
A src/soc/qualcomm/sc7280/decompressor.c
3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/52131/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/52131
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3564a7e531d769c8df16a1592ea98133d83b07b0
Gerrit-Change-Number: 52131
Gerrit-PatchSet: 8
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Martin Roth, mturney mturney, Julius Werner, Sudheer Amrabadi.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, mturney mturney, Julius Werner, Sudheer Amrabadi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50582
to look at the new patch set (#34).
Change subject: sc7280: add qclib support
......................................................................
sc7280: add qclib support
Change-Id: I2d400f0ad96dbef2e45cc1f11ed17ea95fc60d16
Signed-off-by: Sudheer Kumar Amrabadi <samrabad(a)codeaurora.org>
---
M src/soc/qualcomm/sc7280/Makefile.inc
M src/soc/qualcomm/sc7280/memlayout.ld
2 files changed, 27 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/50582/34
--
To view, visit https://review.coreboot.org/c/coreboot/+/50582
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d400f0ad96dbef2e45cc1f11ed17ea95fc60d16
Gerrit-Change-Number: 50582
Gerrit-PatchSet: 34
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sudheer Amrabadi <samrab(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Sudheer Amrabadi <samrab(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Matt DeVillier, Stefan Reinauer, Angel Pons.
Patrik Tesarik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54019 )
Change subject: payloads/Tianocore: Update default build target, simplify build options
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> > In comparison to Upstream EDK2 there is no UEFI boot menu prompt a la "Select boot option: Shell o […]
I meant what you described, excuse me. However, with UefiPayloadPkg I don't see that UEFI prompt to select the BootManager. It's just blank until at some time later OS prompt shows up.
As a side note: I am connected through a SerialTTY and not a VGA or digital graphic output. However, upstream master displays the prompt via SerialTTY.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54019
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If545fbd0c30be6dcc6ff43107b80980fa23a527e
Gerrit-Change-Number: 54019
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrik Tesarik <depate(a)das-labor.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 11 May 2021 15:09:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Patrik Tesarik <depate(a)das-labor.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52584
to look at the new patch set (#3).
Change subject: [WIP] soc/amd/cezanne,common,picasso: use BERT region reserved by FSP driver
......................................................................
[WIP] soc/amd/cezanne,common,picasso: use BERT region reserved by FSP driver
commit ce0e2a014009390c4527e064efb59260ef4d3a3b (drivers/intel/fsp2_0:
use FSP to allocate APEI BERT memory region) adds a mechanism to reserve
the BERT region inside the coreboot code, so we can get rid of the
workaround to reserve it in the FSP and return the location in a HOB.
mcfg->bert_size defaults to 0 which makes the FSP not generate the
corresponding HOB, but that field is planned to be removed at least on
Cezanne, so don't explicitly set it to 0.
TODO: test if Linux likes this or not
BUG=b:169934025
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Iaca89b47793bf9982181560f026459a18e7db134
---
M src/soc/amd/cezanne/fsp_m_params.c
M src/soc/amd/common/block/cpu/noncar/memmap.c
M src/soc/amd/picasso/fsp_m_params.c
M src/vendorcode/amd/fsp/cezanne/FspGuids.h
M src/vendorcode/amd/fsp/picasso/FspGuids.h
5 files changed, 4 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/52584/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52584
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaca89b47793bf9982181560f026459a18e7db134
Gerrit-Change-Number: 52584
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52616
to look at the new patch set (#2).
Change subject: [WIP] soc/amd/picasso/mca: use MCAX registers instead of legacy MCA
......................................................................
[WIP] soc/amd/picasso/mca: use MCAX registers instead of legacy MCA
not verified yet
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I31912d3b3e77e905f64b6143042f5e7f73db7407
---
M src/soc/amd/picasso/mca.c
1 file changed, 8 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/52616/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31912d3b3e77e905f64b6143042f5e7f73db7407
Gerrit-Change-Number: 52616
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Sheng-Liang Pan, YH Lin.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54051 )
Change subject: mb/google/volteer/var/volteer: add specific wifi SAR for volta
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/54051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I000aefca63346c70556688f232ca54360b3badef
Gerrit-Change-Number: 54051
Gerrit-PatchSet: 3
Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Tue, 11 May 2021 14:48:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Hello Lance Zhao, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Justin TerAvest, Tim Wawrzynczak, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50127
to look at the new patch set (#6).
Change subject: drivers/intel/dptf: Add OEM variables support
......................................................................
drivers/intel/dptf: Add OEM variables support
This adds OEM variables feature under DPTF. Using this, platform vendors
can expose an array of OEM-specific values to be used in determining
DPTF policy. These are obtained via the ODVP method, and then simply
exposed under sysfs. In addition, these gets updated when a notification
is received or when the DPTF policy is changed by userspace.
BRANCH=None
BUG=b:187253038
TEST=Built and tested on dedede board
Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Signed-off-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
M src/acpi/acpigen_dptf.c
M src/drivers/intel/dptf/chip.h
M src/drivers/intel/dptf/dptf.c
M src/include/acpi/acpigen_dptf.h
4 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/50127/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/50127
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Gerrit-Change-Number: 50127
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Todd Broch <tbroch(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Todd Broch <tbroch(a)chromium.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Justin TerAvest, Sumeet R Pawnikar, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Justin TerAvest, Tim Wawrzynczak, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50127
to look at the new patch set (#5).
Change subject: drivers/intel/dptf: Add OEM variables support
......................................................................
drivers/intel/dptf: Add OEM variables support
This adds OEM variables feature under DPTF. Using this, platform vendors
can expose an array of OEM-specific values to be used in determining
DPTF policy. These are obtained via the ODVP method, and then simply
exposed under sysfs. In addition, these gets updated when a notification
is received or when the DPTF policy is changed by userspace.
BRANCH=None
BUG=b:176965529
TEST=Built and tested on dedede board
Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Signed-off-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
M src/acpi/acpigen_dptf.c
M src/drivers/intel/dptf/chip.h
M src/drivers/intel/dptf/dptf.c
M src/include/acpi/acpigen_dptf.h
4 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/50127/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/50127
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Gerrit-Change-Number: 50127
Gerrit-PatchSet: 5
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Todd Broch <tbroch(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Justin TerAvest <teravest(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Todd Broch <tbroch(a)chromium.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset