Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54342 )
Change subject: cpu/x86/smm: Fix size_t type mismatch in print statement
......................................................................
cpu/x86/smm: Fix size_t type mismatch in print statement
Fix the format warning below:
CC ramstage/cpu/x86/smm/smm_module_loader.o
src/cpu/x86/smm/smm_module_loader.c: In function 'smm_module_setup_stub':
src/cpu/x86/smm/smm_module_loader.c:360:70: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=]
360 | printk(BIOS_ERR, "%s: state save size: %zx : smm_entry_offset -> %lx\n",
| ~~^
| |
| long unsigned int
| %x
Fixes: afb7a814 ("cpu/x86/smm: Introduce SMM module loader version 2")
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
Change-Id: I4172e0f4dc40437250da89b7720a5c1e5fbab709
---
M src/cpu/x86/smm/smm_module_loader.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/54342/1
diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index 1a7b448..ecdd493 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -357,7 +357,7 @@
/* The save state size encroached over the first SMM entry point. */
if (size <= SMM_ENTRY_OFFSET) {
printk(BIOS_ERR, "%s: encroachment over SMM entry point\n", __func__);
- printk(BIOS_ERR, "%s: state save size: %zx : smm_entry_offset -> %lx\n",
+ printk(BIOS_ERR, "%s: state save size: %zx : smm_entry_offset -> %zx\n",
__func__, size, (size_t)SMM_ENTRY_OFFSET);
return -1;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/54342
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4172e0f4dc40437250da89b7720a5c1e5fbab709
Gerrit-Change-Number: 54342
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newchange
Attention is currently required from: Selma Bensaid, Sridhar Siricilla, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54334 )
Change subject: soc/intel/alderlake: Add configurable value for UsbTcPortEn
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/54334/comment/6b9f2e3f_97af7d81
PS2, Line 48: uint8_t UsbTcPortEn;
suggestion: an array of `bool` would be a nicer interface than raw bitmask, e.g.
```
bool typec_port_enable[MAX_TYPE_C_PORTS];
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/54334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5cd0690945b9296c105ade2d99f68bbf0ee22bd
Gerrit-Change-Number: 54334
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sun, 16 May 2021 17:13:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Selma Bensaid, Sridhar Siricilla, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54334 )
Change subject: soc/intel/alderlake: Add configurable value for UsbTcPortEn
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/54334/comment/f1d01fb2_5614c84b
PS2, Line 131: UsbTcPortEn
`UsbTcPortEn`
needs to be opened
--
To view, visit https://review.coreboot.org/c/coreboot/+/54334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5cd0690945b9296c105ade2d99f68bbf0ee22bd
Gerrit-Change-Number: 54334
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sun, 16 May 2021 17:11:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Selma Bensaid, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph.
Hello build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54334
to look at the new patch set (#2).
Change subject: soc/intel/alderlake: Add configurable value for UsbTcPortEn
......................................................................
soc/intel/alderlake: Add configurable value for UsbTcPortEn
As a requirement of TCSS this setting needs to be correctly set
to determine what Type-C ports are enabled on the platform.
BUG=b:184324979
TEST=Verified on brya
Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Change-Id: Ic5cd0690945b9296c105ade2d99f68bbf0ee22bd
---
M src/soc/intel/alderlake/chip.h
M src/soc/intel/alderlake/fsp_params.c
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/54334/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54334
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5cd0690945b9296c105ade2d99f68bbf0ee22bd
Gerrit-Change-Number: 54334
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.corp-partner.google.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ivy Jian.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54297 )
Change subject: mb/google/mancomb: enable DDI0-DP port
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8af14509b0d246c5c2da6e1a48991384471e69f
Gerrit-Change-Number: 54297
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Sun, 16 May 2021 16:35:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54337
to look at the new patch set (#2).
Change subject: mb/asus/p8x7x: Turn P8Z77-V LX2 into a variant of P8x7x baseboard
......................................................................
mb/asus/p8x7x: Turn P8Z77-V LX2 into a variant of P8x7x baseboard
Other variants would be added later.
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
Change-Id: Id9a7f1069233b43eb4a046f2e61c7a72fec7e960
---
M src/mainboard/asus/p8x7x/Kconfig
M src/mainboard/asus/p8x7x/Kconfig.name
M src/mainboard/asus/p8x7x/variants/z77-m_pro/overridetree.cb
R src/mainboard/asus/p8x7x/variants/z77-v_lx2/acpi_tables.c
A src/mainboard/asus/p8x7x/variants/z77-v_lx2/board_info.txt
R src/mainboard/asus/p8x7x/variants/z77-v_lx2/data.vbt
R src/mainboard/asus/p8x7x/variants/z77-v_lx2/early_init.c
R src/mainboard/asus/p8x7x/variants/z77-v_lx2/gma-mainboard.ads
R src/mainboard/asus/p8x7x/variants/z77-v_lx2/gpio.c
R src/mainboard/asus/p8x7x/variants/z77-v_lx2/hda_verb.c
A src/mainboard/asus/p8x7x/variants/z77-v_lx2/mainboard.c
A src/mainboard/asus/p8x7x/variants/z77-v_lx2/overridetree.cb
D src/mainboard/asus/p8z77-v_lx2/Kconfig
D src/mainboard/asus/p8z77-v_lx2/Kconfig.name
D src/mainboard/asus/p8z77-v_lx2/Makefile.inc
D src/mainboard/asus/p8z77-v_lx2/acpi/ec.asl
D src/mainboard/asus/p8z77-v_lx2/acpi/platform.asl
D src/mainboard/asus/p8z77-v_lx2/acpi/superio.asl
D src/mainboard/asus/p8z77-v_lx2/board_info.txt
D src/mainboard/asus/p8z77-v_lx2/cmos.default
D src/mainboard/asus/p8z77-v_lx2/cmos.layout
D src/mainboard/asus/p8z77-v_lx2/devicetree.cb
D src/mainboard/asus/p8z77-v_lx2/dsdt.asl
23 files changed, 53 insertions(+), 274 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/54337/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54337
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9a7f1069233b43eb4a046f2e61c7a72fec7e960
Gerrit-Change-Number: 54337
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset