coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: cpu/x86/smm: Fix uintptr_t type mismatches in print statements
by Paul Menzel (Code Review) 17 May '21

17 May '21

Attention is currently required from: Werner Zeh. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54341 ) Change subject: cpu/x86/smm: Fix uintptr_t type mismatches in print statements ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This is not good readable in my opinion. The macros in src/include/inttypes. […] I think the problem is, that’s it’s dependent on the host build system, how uintptr_t is defined. -- To view, visit https://review.coreboot.org/c/coreboot/+/54341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32bff397c8a033fe34390e6c1a7dfe773707a4e8 Gerrit-Change-Number: 54341 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 17 May 2021 06:57:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Move "--help" to general option section
by Bao Zheng (Code Review) 16 May '21

16 May '21

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/54349 to review the following change. Change subject: amdfwtool: Move "--help" to general option section ...................................................................... amdfwtool: Move "--help" to general option section Change-Id: I442be6b60ce939c110ffec4f3de8b158f4130212 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/54349/1 diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 46910cb..b0fe106 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -196,7 +196,6 @@ printf("-C | --soc-name <socname> Specify SOC name. Supported names are\n"); printf(" Stoneyridge, Raven, Picasso, Renoir, Cezanne\n"); printf(" or Lucienne\n"); - printf("-h | --help Show this help\n"); printf("\nEmbedded Firmware Structure options used by the PSP:\n"); printf("--spi-speed <HEX_VAL> SPI fast speed to place in EFS Table\n"); printf(" 0x0 66.66Mhz\n"); @@ -219,9 +218,11 @@ printf(" 0x1 Micron parts are always used\n"); printf(" 0x2 Micron parts optional, this option is only\n"); printf(" supported with RN/LCN SOC\n"); + printf("\nGeneral options:\n") printf("-c | --config <config file> Config file\n"); printf("-d | --debug Print debug message\n"); printf("-D | --depend List out the firmware files\n"); + printf("-h | --help Show this help\n"); } amd_fw_entry amd_psp_fw_table[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/54349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I442be6b60ce939c110ffec4f3de8b158f4130212 Gerrit-Change-Number: 54349 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cpu/x86/smm: Fix u32 type mismatch in print statement
by Werner Zeh (Code Review) 16 May '21

16 May '21

Attention is currently required from: Paul Menzel. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54343 ) Change subject: cpu/x86/smm: Fix u32 type mismatch in print statement ...................................................................... Patch Set 1: (1 comment) File src/cpu/x86/smm/smm_module_loader.c: https://review.coreboot.org/c/coreboot/+/54343/comment/683fe46b_61ef3c27 PS1, Line 415: PRIu32 " Here you make a decimal notation out of a hex but keep 0x as prefix. -- To view, visit https://review.coreboot.org/c/coreboot/+/54343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib504bc5e5b19f62d4702b7f485522a2ee3d26685 Gerrit-Change-Number: 54343 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 17 May 2021 05:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Fix uintptr_t type mismatches in print statements
by Werner Zeh (Code Review) 16 May '21

16 May '21

Attention is currently required from: Paul Menzel. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54341 ) Change subject: cpu/x86/smm: Fix uintptr_t type mismatches in print statements ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is not good readable in my opinion. The macros in src/include/inttypes.h have been introduced in CB:33823 with the goal to let 3rd party code be aware of the underlaying types. Here, you are using them in core code of coreboot, so why not just use %lx here instead? It would be way better readable while still maintaining your needs. -- To view, visit https://review.coreboot.org/c/coreboot/+/54341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I32bff397c8a033fe34390e6c1a7dfe773707a4e8 Gerrit-Change-Number: 54341 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 17 May 2021 05:20:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Rearrange slot table for remapping type 9 Slot ID
by Jonathan Zhang (Code Review) 16 May '21

16 May '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Patrick Rudolph, Johnny Lin, Jingle Hsu, Angel Pons, Morgan Jang. Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51389 ) Change subject: mb/ocp/deltalake: Rearrange slot table for remapping type 9 Slot ID ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/51389 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07bdf7f85f8411e04da8a94da7de1e7b93c9e921 Gerrit-Change-Number: 51389 Gerrit-PatchSet: 3 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Mon, 17 May 2021 03:59:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asus/p8x7x: Turn P8Z77-M PRO into a variant of P8x7x baseboard
by Bill XIE (Code Review) 16 May '21

16 May '21

Attention is currently required from: Bill XIE. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54335 to look at the new patch set (#3). Change subject: mb/asus/p8x7x: Turn P8Z77-M PRO into a variant of P8x7x baseboard ...................................................................... mb/asus/p8x7x: Turn P8Z77-M PRO into a variant of P8x7x baseboard Other variants would be added later. MAINBOARD_HAS_TPM1 should not be selected, since the module is replaceable. Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: Iaf0bd4c993debe4d5d7ca695473438bd4c954290 --- A src/mainboard/asus/p8x7x/Kconfig R src/mainboard/asus/p8x7x/Kconfig.name A src/mainboard/asus/p8x7x/Makefile.inc R src/mainboard/asus/p8x7x/acpi/ec.asl R src/mainboard/asus/p8x7x/acpi/platform.asl R src/mainboard/asus/p8x7x/acpi/superio.asl A src/mainboard/asus/p8x7x/board_info.txt R src/mainboard/asus/p8x7x/cmos.default R src/mainboard/asus/p8x7x/cmos.layout A src/mainboard/asus/p8x7x/devicetree.cb R src/mainboard/asus/p8x7x/dsdt.asl A src/mainboard/asus/p8x7x/hda_verb.c R src/mainboard/asus/p8x7x/variants/z77-m_pro/acpi_tables.c A src/mainboard/asus/p8x7x/variants/z77-m_pro/board_info.txt R src/mainboard/asus/p8x7x/variants/z77-m_pro/data.vbt R src/mainboard/asus/p8x7x/variants/z77-m_pro/early_init.c R src/mainboard/asus/p8x7x/variants/z77-m_pro/gma-mainboard.ads R src/mainboard/asus/p8x7x/variants/z77-m_pro/gpio.c R src/mainboard/asus/p8x7x/variants/z77-m_pro/hda_verb.c R src/mainboard/asus/p8x7x/variants/z77-m_pro/mainboard.c A src/mainboard/asus/p8x7x/variants/z77-m_pro/overridetree.cb D src/mainboard/asus/p8z77-m_pro/Kconfig D src/mainboard/asus/p8z77-m_pro/Makefile.inc D src/mainboard/asus/p8z77-m_pro/board_info.txt D src/mainboard/asus/p8z77-m_pro/devicetree.cb 25 files changed, 183 insertions(+), 139 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/54335/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/54335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf0bd4c993debe4d5d7ca695473438bd4c954290 Gerrit-Change-Number: 54335 Gerrit-PatchSet: 3 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/cherry: Pass reset gpio parameter to BL31
by Yu-Ping Wu (Code Review) 16 May '21

16 May '21

Attention is currently required from: Hung-Te Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54013 ) Change subject: mb/google/cherry: Pass reset gpio parameter to BL31 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a55216c0d5a00bbdb373d931bd50ebe7ca5694f Gerrit-Change-Number: 54013 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Mon, 17 May 2021 03:30:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: enable ARM64_USE_ARM_TRUSTED_FIRMWARE
by Yu-Ping Wu (Code Review) 16 May '21

16 May '21

Attention is currently required from: Hung-Te Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53898 ) Change subject: soc/mediatek/mt8195: enable ARM64_USE_ARM_TRUSTED_FIRMWARE ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/53898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1ef29894fa3a6022574c3874dee62617133b12c Gerrit-Change-Number: 53898 Gerrit-PatchSet: 18 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Mon, 17 May 2021 03:25:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Pass reset gpio parameter to BL31
by Hung-Te Lin (Code Review) 16 May '21

16 May '21

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu, Yidi Lin. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54013 ) Change subject: mb/google/cherry: Pass reset gpio parameter to BL31 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a55216c0d5a00bbdb373d931bd50ebe7ca5694f Gerrit-Change-Number: 54013 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Comment-Date: Mon, 17 May 2021 02:55:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/cret: Enable/disable LTE function based on FW_CO...
by Dtrain Hsu (Code Review) 16 May '21

16 May '21

Attention is currently required from: Furquan Shaikh, Henry Sun, Tim Wawrzynczak, Karthik Ramasubramanian. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54057 ) Change subject: mb/google/dedede/var/cret: Enable/disable LTE function based on FW_CONFIG ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/dedede/variants/cret/variant.c: https://review.coreboot.org/c/coreboot/+/54057/comment/f7eb773a_eb514a49 PS3, Line 18: Once the FW_CONFIG is provisioned, > I am fine with that since we will be in S5 for only 10 seconds before entering G3 and hence power le […] Furquan@, thanks for your comment about Lte power off sequence. Please invite me when you raise a bug. Thank you. Karthik@, thanks for your comment. I restore the code about Lte power off sequence in SMM mode. -- To view, visit https://review.coreboot.org/c/coreboot/+/54057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib926e99aaf9df433a7cff71180ee55431d69f718 Gerrit-Change-Number: 54057 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 17 May 2021 02:43:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021