coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: Revert "libpayload/keyboard: Reset to scancode set #2 on exit"
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Raul Rangel, Nico Huber, Duncan Laurie. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52432 ) Change subject: Revert "libpayload/keyboard: Reset to scancode set #2 on exit" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I have a change here that makes it into a kconfig option: https://review.coreboot. […] I'd prefer this as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/52432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5057ab0b764d784b172f09aeacabaa4e74f34f Gerrit-Change-Number: 52432 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-CC: Duncan Laurie <duncan(a)iceblink.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-Comment-Date: Fri, 30 Apr 2021 17:47:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: i8042: Enable keyboard translation by defualt on exit
by Angel Pons (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Duncan Laurie, Tim Wawrzynczak. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52737 ) Change subject: libpayload: i8042: Enable keyboard translation by defualt on exit ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25dfe3f425a5bb57e97476564886672b707aa3bd Gerrit-Change-Number: 52737 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 30 Apr 2021 17:46:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "libpayload/keyboard: Reset to scancode set #2 on exit"
by Duncan Laurie (Code Review) 01 May '21

01 May '21

Attention is currently required from: Raul Rangel, Nico Huber, Angel Pons. Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52432 ) Change subject: Revert "libpayload/keyboard: Reset to scancode set #2 on exit" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I have a change here that makes it into a kconfig option: https://review.coreboot.org/c/coreboot/+/52737 It has a +2 from furquan but I have not submitted yet.. -- To view, visit https://review.coreboot.org/c/coreboot/+/52432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5057ab0b764d784b172f09aeacabaa4e74f34f Gerrit-Change-Number: 52432 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <dlaurie(a)gmail.com> Gerrit-CC: Duncan Laurie <duncan(a)iceblink.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 30 Apr 2021 17:45:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC]libpayload/keyboard: Reset to scancode set #2 on exit
by Nico Huber (Code Review) 01 May '21

01 May '21

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47594 ) Change subject: [RFC]libpayload/keyboard: Reset to scancode set #2 on exit ...................................................................... [RFC]libpayload/keyboard: Reset to scancode set #2 on exit If we select scancode set #1 and keep that, it can confuse Linux with keyboards that don't return to set #2 when asked to load the defaults. This happens for instance with various integrated Think- Pad keyboards but was also seen with an external PS/2 one. The chosen configuration, scancode set #2 without translation, seems to be the default for many systems. So we can expect other payloads and kernels to work with it. Change-Id: I28d74590e9f04d32bb2bbd461b67f15014f927ec Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M payloads/libpayload/drivers/i8042/keyboard.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/47594/1 diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index 09b35d3..1f8d88b 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -648,6 +648,11 @@ keyboard_cmd(I8042_KBCMD_DEFAULT_DIS); keyboard_drain_input(); + /* Nobody but us seems to still use scancode set #1. + So try to hand over with more modern settings. */ + set_scancode_set(2); + i8042_set_kbd_translation(false); + /* Send keyboard disconnect command */ i8042_cmd(I8042_CMD_DIS_KB); -- To view, visit https://review.coreboot.org/c/coreboot/+/47594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28d74590e9f04d32bb2bbd461b67f15014f927ec Gerrit-Change-Number: 47594 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

5 7

Change in coreboot[master]: Revert "libpayload/keyboard: Reset to scancode set #2 on exit"
by Raul Rangel (Code Review) 01 May '21

01 May '21

Attention is currently required from: Nico Huber, Angel Pons. Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/52432 to review the following change. Change subject: Revert "libpayload/keyboard: Reset to scancode set #2 on exit" ...................................................................... Revert "libpayload/keyboard: Reset to scancode set #2 on exit" This reverts commit 1f2b5fb20137afc897aff6304cd31682cac56282. Reason for revert: Breaks all chromebook keyboards. Change-Id: Ice5057ab0b764d784b172f09aeacabaa4e74f34f --- M payloads/libpayload/drivers/i8042/keyboard.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/52432/1 diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c index a695723..cc412ac 100644 --- a/payloads/libpayload/drivers/i8042/keyboard.c +++ b/payloads/libpayload/drivers/i8042/keyboard.c @@ -655,11 +655,6 @@ keyboard_cmd(I8042_KBCMD_DEFAULT_DIS); keyboard_drain_input(); - /* Nobody but us seems to still use scancode set #1. - So try to hand over with more modern settings. */ - set_scancode_set(2); - i8042_set_kbd_translation(false); - /* Send keyboard disconnect command */ i8042_cmd(I8042_CMD_DIS_KB); -- To view, visit https://review.coreboot.org/c/coreboot/+/52432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice5057ab0b764d784b172f09aeacabaa4e74f34f Gerrit-Change-Number: 52432 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Duncan Laurie <duncan(a)iceblink.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Added CMOS option to disable ME
by build bot (Jenkins) (Code Review) 01 May '21

01 May '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 ) Change subject: Added CMOS option to disable ME ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/common/block/cse/cse.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118125): https://review.coreboot.org/c/coreboot/+/52800/comment/c1eac23d_971a9065 PS2, Line 826: printk(BIOS_DEBUG, "HECI: Disable ME set %s!\n", status ? "success" : "failure"); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/52800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20 Gerrit-Change-Number: 52800 Gerrit-PatchSet: 2 Gerrit-Owner: Star Labs <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 30 Apr 2021 17:23:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Added Star Labs labtop series
by Star Labs (Code Review) 01 May '21

01 May '21

Star Labs has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52803 ) Change subject: Added Star Labs labtop series ...................................................................... Added Star Labs labtop series Change-Id: Ifa79eaffbb7ac83da0124819eec5559af49cc475 --- M src/mainboard/starlabs/labtop/acpi/mainboard.asl 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/52803/1 diff --git a/src/mainboard/starlabs/labtop/acpi/mainboard.asl b/src/mainboard/starlabs/labtop/acpi/mainboard.asl index bf73244..7b955c4 100644 --- a/src/mainboard/starlabs/labtop/acpi/mainboard.asl +++ b/src/mainboard/starlabs/labtop/acpi/mainboard.asl @@ -34,7 +34,7 @@ Name (_CID, Package (0x02) { - "PRP00001", + "PRP00001", "PNP0A05" }) @@ -45,7 +45,7 @@ } } -/* +/* * ITE IT8987E Embedded Controller * * We include this here as we need to support different levels within @@ -55,5 +55,3 @@ #define EC_GPE_SCI 0x50 /* GPP_E16 */ #include <ec/starlabs/it8987/acpi/ec.asl> - - -- To view, visit https://review.coreboot.org/c/coreboot/+/52803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa79eaffbb7ac83da0124819eec5559af49cc475 Gerrit-Change-Number: 52803 Gerrit-PatchSet: 1 Gerrit-Owner: Star Labs <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Added CMOS option to disable ME
by Star Labs (Code Review) 01 May '21

01 May '21

Attention is currently required from: Star Labs, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52800 to look at the new patch set (#2). Change subject: Added CMOS option to disable ME ...................................................................... Added CMOS option to disable ME Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20 --- M src/soc/intel/cannonlake/me.c M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/include/intelblocks/cse.h M src/soc/intel/skylake/me.c M src/soc/intel/tigerlake/me.c 5 files changed, 45 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/52800/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I374db3b7c0ded71cdc18f27970252fec7220cc20 Gerrit-Change-Number: 52800 Gerrit-PatchSet: 2 Gerrit-Owner: Star Labs <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Star Labs <admin(a)starlabs.systems> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp: Enable support for Chrome OS mode switches
by Anil Kumar K (Code Review) 01 May '21

01 May '21

Attention is currently required from: Shaunak Saha, Maulik V Vaghela, Selma Bensaid, Usha P, Bernardo Perez Priego, Anil Kumar K, Felix Held. Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52614 ) Change subject: mb/intel/adlrvp: Enable support for Chrome OS mode switches ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Hi Felix. can u help in fixing the QA job.. The config choses by default is ADL_INTEL_EC and hence this dependency is not met. We need to choose ADL_CHROME_EC (via BOARD_INTEL_ADLRVP_M_EXT_EC) -- To view, visit https://review.coreboot.org/c/coreboot/+/52614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I771f0ef14b1c273f9d1af22c96de0eabd08e9a8c Gerrit-Change-Number: 52614 Gerrit-PatchSet: 1 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 30 Apr 2021 17:15:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Add placeholder GPIO macro, PAD_UNCHANGED
by Raul Rangel (Code Review) 01 May '21

01 May '21

Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52763 ) Change subject: soc/amd/common: Add placeholder GPIO macro, PAD_UNCHANGED ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/52763/comment/ca317859_a2e9c269 PS1, Line 9: GPIOs can only be updated in gpio_configure_pads_with_override() if they : are present in the base table. If they are not there, the override : does not work. This allows them to be in the base table so that they can : be overridden without changing the existing configuration. > talked with Martin and the scopes of those two things are a bit different, so it's probably a good i […] What's the level of effort required to fix this behavior? I would rather fix it then introduce another PAD_X macro. -- To view, visit https://review.coreboot.org/c/coreboot/+/52763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e5e7b7d30f2c89fa1db375ddba394e6914d97b9 Gerrit-Change-Number: 52763 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 30 Apr 2021 17:07:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021