Attention is currently required from: EricR Lai.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52726
to look at the new patch set (#2).
Change subject: mb/google/brya: Add CHROMEOS_DRAM_PART_NUMBER_IN_CBI
......................................................................
mb/google/brya: Add CHROMEOS_DRAM_PART_NUMBER_IN_CBI
Brya uses CBI to store dram part number. So enable the config.
BUG=b:186571840
BRANCH=none
TEST=dmidecode -t 17 can show the dram part number.
Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com>
Change-Id: I1b4fc4da31d8964763c3e671d84be71996fa5e2a
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/52726/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b4fc4da31d8964763c3e671d84be71996fa5e2a
Gerrit-Change-Number: 52726
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52726 )
Change subject: mb/google/brya: Add CHROMEOS_DRAM_PART_NUMBER_IN_CBI
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52726/comment/5470896d_b51a0b7b
PS1, Line 9: is use
uses
--
To view, visit https://review.coreboot.org/c/coreboot/+/52726
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b4fc4da31d8964763c3e671d84be71996fa5e2a
Gerrit-Change-Number: 52726
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:47:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52732 )
Change subject: mb/intel/adlrvp: Align chromeos.fmd file with Brya
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Updated SI_ALL region to 6 MB since ME.bin size for ADLRVP is 4.8 MB which would be difficult to accomodate within 5 MB along with EC.bin
File src/mainboard/intel/adlrvp/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/52732/comment/448a0ddc_0724cf84
PS1, Line 4: SI_EC 0x80000
> windows sku need this
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52732
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I644e2e5ba06d2b816d413a7cc9f5f248d8a6fee8
Gerrit-Change-Number: 52732
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Spoorthi K <spoorthi.k(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Meera Ravindranath, Ronak Kanabar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52732
to look at the new patch set (#2).
Change subject: mb/intel/adlrvp: Align chromeos.fmd file with Brya
......................................................................
mb/intel/adlrvp: Align chromeos.fmd file with Brya
While moving to emerge build for coreboot, Adlrvp doesn't have space
for CBFS region. We need to update fmd file to align with Brya, so that
we have enough space in CBFS and FW_MAIN_* regions to accomodate all
necessary binaries such as Microcode, VBT, EC, ME etc.
BUG=b:184997582
BRANCH=NONE
TEST=Code compiles fine and able to boot adlrvp platform
Change-Id: I644e2e5ba06d2b816d413a7cc9f5f248d8a6fee8
Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
---
M src/mainboard/intel/adlrvp/chromeos.fmd
1 file changed, 38 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/52732/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52732
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I644e2e5ba06d2b816d413a7cc9f5f248d8a6fee8
Gerrit-Change-Number: 52732
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Spoorthi K <spoorthi.k(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Julius Werner, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels
......................................................................
Patch Set 2:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/1a0ce7a2_cf289cb4
PS2, Line 101: if(CONFIG(TROGDOR_HAS_MIPI_PANEL))
space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/25050419_34a284e1
PS2, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/5576877d_a3fcf937
PS2, Line 172: write32(&dsi0->int_ctrl,0x0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/525fac2e_16ec0649
PS2, Line 210: printk(BIOS_ERR,
Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/2d1369cd_e21836f9
PS2, Line 281: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/82c8f040_37163c62
PS2, Line 289: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/10c37931_187c877a
PS2, Line 292: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/ed301257_426ef738
PS2, Line 299: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/ac3cbba2_c531d75f
PS2, Line 302: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/a8d8b79b_87c43829
PS2, Line 319: write32(&dsi0->int_ctrl,0x0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/0a039e7f_f0ca74a3
PS2, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/27f14125_9dca8d28
PS2, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/096b5b27_69315dd2
PS2, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/2642375b_ecb43de1
PS2, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117970):
https://review.coreboot.org/c/coreboot/+/52662/comment/e8d8c28e_5d0f6500
PS2, Line 343: if(!pinfo && !pinfo->init_cmd)
space required before the open parenthesis '('
--
To view, visit https://review.coreboot.org/c/coreboot/+/52662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f
Gerrit-Change-Number: 52662
Gerrit-PatchSet: 2
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:44:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, Martin Roth, mturney mturney, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52376 )
Change subject: HACK payloads: Add libpci for arm arch HACK
......................................................................
Patch Set 4:
(14 comments)
File payloads/libpayload/drivers/pci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/091e2a76_26d1d5f1
PS4, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/9e292994_9023c087
PS4, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0)
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/7bcf3b02_af782597
PS4, Line 84: static void dw_pcie_writel_ob_unroll(void * atu_base,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/c66368d1_29f0bbf1
PS4, Line 224: if (current_bus == 1)
Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/5a57e5c2_d5001023
PS4, Line 231:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/7e8b9966_061d538f
PS4, Line 248: io_size);
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/39894d97_6c53025a
PS4, Line 253: u8 pci_read_config8(u32 dev, u16 reg)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/90308d21_2884904c
PS4, Line 254: {
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/a6b086d5_d14c1bc6
PS4, Line 255: int val, offset = reg;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/2187a9a0_89e42723
PS4, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/78f1c69f_d3d18319
PS4, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/96ce3d37_5b1eff41
PS4, Line 268: u32 pci_read_config32(u32 dev, u16 reg)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/3075a86a_226b753d
PS4, Line 343: u16 reg = 0x10+ (bar * 4);
need consistent spacing around '+' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117964):
https://review.coreboot.org/c/coreboot/+/52376/comment/9eb74d43_c9de5e78
PS4, Line 344: val = pci_read_config32(dev, reg );
space prohibited before that close parenthesis ')'
--
To view, visit https://review.coreboot.org/c/coreboot/+/52376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9850125d27da9d7bec3fc3af9995c6db240b4b3d
Gerrit-Change-Number: 52376
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 14:42:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment