Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Chris Wang, chris wang, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 )
Change subject: amd/cezanne: Add telemetry setting to UPD
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52733/comment/19cd7f5a_25960819
PS1, Line 106: 0x04C7
> During today's conversation, we decided not to worry about the alignment because it would break too […]
OK, decided to keep it as-is.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52733
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e
Gerrit-Change-Number: 52733
Gerrit-PatchSet: 4
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 17:01:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Martin Roth, Tim Wawrzynczak.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52747 )
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
Please update Documentation/lib/fw_config.md to reflect the new format and perhaps provide an example in there.
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/52747/comment/a85dd14d_96d3e672
PS3, Line 598: ((1ull << (1ull + bits->end_bit - bits->start_bit)) - 1ull);
could pull this into a function that takes fw_config_field_bits since it is used in multiple places now.
File util/sconfig/sconfig.h:
https://review.coreboot.org/c/coreboot/+/52747/comment/0bb96e8b_93836de7
PS3, Line 230: append_bits
I would suggest adding fw_config in the name to match all the other fw_config callbacks. (although it is pretty evident from the 1st argument..)
--
To view, visit https://review.coreboot.org/c/coreboot/+/52747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Gerrit-Change-Number: 52747
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Apr 2021 16:52:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52698 )
Change subject: mb/google/volteer/variant/lindar: Modify ELAN touch screen IRQ trigger method
......................................................................
mb/google/volteer/variant/lindar: Modify ELAN touch screen IRQ trigger method
According to SED team provided ELAN touch screen SPEC. IRQ trigger
method need set with level trigger, that modify IRQ trigger to level
from edge.
BUG=b:174972088
TEST=Build FW and boot to OS and check with test result.
Signed-off-by: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Change-Id: I9237d9aad6166a5754afe464ce8453129a58d283
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52698
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Zhuohao Lee <zhuohao(a)google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com>
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Nick Vaccaro: Looks good to me, approved
Zhuohao Lee: Looks good to me, but someone else must approve
Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index a1010d2..5edd6db 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -239,7 +239,7 @@
chip drivers/i2c/generic
register "hid" = ""ELAN0001""
register "desc" = ""ELAN Touchscreen""
- register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_E7_IRQ)"
+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"
register "probed" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C10)"
register "reset_delay_ms" = "20"
--
To view, visit https://review.coreboot.org/c/coreboot/+/52698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9237d9aad6166a5754afe464ce8453129a58d283
Gerrit-Change-Number: 52698
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged
Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Chris Wang, chris wang, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 )
Change subject: amd/cezanne: Add telemetry setting to UPD
......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52733/comment/7ac63be7_35490c96
PS1, Line 106: 0x04C7
> I would align, however it's just a habit. I believe the FSP doesn't care. […]
During today's conversation, we decided not to worry about the alignment because it would break too much stuff. However, I believe we can realign the telemetry changes without any trouble.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52733
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e
Gerrit-Change-Number: 52733
Gerrit-PatchSet: 4
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 29 Apr 2021 16:22:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Zhuohao Lee.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52754 )
Change subject: mb/google/brya: select GOOGLE_SMBIOS_MAINBOARD_VERSION
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52754/comment/8f93aded_c760542d
PS1, Line 9: In order to use the function smbios_mainboard_version()
: to query the board revision from the EC.
: we need to select GOOGLE_SMBIOS_MAINBOARD_VERSION.
> suggestion: selectin GOOGLE_SMBIOS_MAINBOARD_VERSION allows querying board revision from the EC.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eeb958f73607afb801794f91fbf91ec7bd5cd8b
Gerrit-Change-Number: 52754
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Apr 2021 16:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Zhuohao Lee.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52754
to look at the new patch set (#2).
Change subject: mb/google/brya: select GOOGLE_SMBIOS_MAINBOARD_VERSION
......................................................................
mb/google/brya: select GOOGLE_SMBIOS_MAINBOARD_VERSION
Select GOOGLE_SMBIOS_MAINBOARD_VERSION allows querying
board revision from the EC.
BUG=b:186721096
TEST=1. emerge-brya coreboot chromeos-bootimage
2. flash the image to the device and check board rev
by using command `dmidecode -t 1 | grep Version`
Change-Id: I8eeb958f73607afb801794f91fbf91ec7bd5cd8b
Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org>
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/52754/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eeb958f73607afb801794f91fbf91ec7bd5cd8b
Gerrit-Change-Number: 52754
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-MessageType: newpatchset