Attention is currently required from: Martin Roth, Selma Bensaid, Subrata Banik, Bernardo Perez Priego, Usha P, Andrey Petrov, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51105 )
Change subject: drivers/intel/fsp2_0/memory_init: Add saving memory info API
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/intel/fsp2_0/hob_memory_info.c:
PS2:
In my opinion, this file belongs in soc/intel/common/block/memory. Reason is the same as I mentioned before - this is a platform specific implementation and not something that the FSP spec covers. Hence, this must not be added to fsp driver here.
https://review.coreboot.org/c/coreboot/+/51105/comment/1e7298f2_0ddd84d3
PS2, Line 16: #ifndef CHANNEL_NOT_PRESENT
: #define CHANNEL_NOT_PRESENT 0 // There is no channel present on the controller.
: #endif
: #ifndef CHANNEL_DISABLED
: #define CHANNEL_DISABLED 1 // There is a channel present but it is disabled.
: #endif
: #ifndef CHANNEL_PRESENT
: #define CHANNEL_PRESENT 2 // There is a channel present and it is enabled.
: #endif
These should come from the FSP headers and not defined in coreboot. I think once you move this file to soc/intel/common/block/memory, you should update the file to include a soc header which pulls in all the required FSP provided header files as well as provide the definition of FSP_SMBIOS_MEMORY_INFO_GUID on a per platform level.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d14c71d5d19f58e6a27ed5ef8269c6678f32a5
Gerrit-Change-Number: 51105
Gerrit-PatchSet: 2
Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:22:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Xi Chen, Martin Roth, Yu-Ping Wu.
Yidi Lin has uploaded a new patch set (#9) to the change originally created by Hung-Te Lin. ( https://review.coreboot.org/c/coreboot/+/49448 )
Change subject: mb/google/asurada: Add generic DRAM groups
......................................................................
mb/google/asurada: Add generic DRAM groups
To reduce qualification effort, we want to pre-populate DRAM by their
size, package type and geometry so when a new DRAM is introduced we
don't need to spin off a new firmware release.
Change-Id: Ia89cc26a3b18a60f18b38906f0ac13b1e8c86416
Signed-off-by: Hung-Te Lin <hungte(a)chromium.org>
Signed-off-by: Xi Chen <xixi.chen(a)mediatek.com>
---
M src/mainboard/google/asurada/boardid.c
M src/mainboard/google/asurada/sdram_configs.c
M src/mainboard/google/asurada/sdram_params/Makefile.inc
A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-DISCRETE-1RANK-4GB.c
A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-DISCRETE-2RANK-4GB.c
A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-DISCRETE-2RANK-8GB.c
A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-EMCP-1RANK-4GB.c
A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-EMCP-2RANK-4GB.c
A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-EMCP-2RANK-8GB.c
9 files changed, 174 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/49448/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/49448
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia89cc26a3b18a60f18b38906f0ac13b1e8c86416
Gerrit-Change-Number: 49448
Gerrit-PatchSet: 9
Gerrit-Owner: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Selma Bensaid, Subrata Banik, Bernardo Perez Priego, Usha P, Andrey Petrov, Patrick Rudolph.
Hello build bot (Jenkins), Selma Bensaid, Subrata Banik, Usha P, Andrey Petrov, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51105
to look at the new patch set (#2).
Change subject: drivers/intel/fsp2_0/memory_init: Add saving memory info API
......................................................................
drivers/intel/fsp2_0/memory_init: Add saving memory info API
DIMM information is stored into CBMEM later to be used to generate
SMBIOS table 17.
Including implementation for CNL, SKL and TGL SOC's.
Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Change-Id: I78d14c71d5d19f58e6a27ed5ef8269c6678f32a5
---
M src/drivers/intel/fsp2_0/Kconfig
M src/drivers/intel/fsp2_0/Makefile.inc
A src/drivers/intel/fsp2_0/hob_memory_info.c
M src/drivers/intel/fsp2_0/include/fsp/api.h
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/skylake/romstage/romstage.c
M src/soc/intel/tigerlake/Kconfig
M src/soc/intel/tigerlake/romstage/romstage.c
10 files changed, 156 insertions(+), 317 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/51105/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78d14c71d5d19f58e6a27ed5ef8269c6678f32a5
Gerrit-Change-Number: 51105
Gerrit-PatchSet: 2
Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 )
Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc
Gerrit-Change-Number: 51145
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:08:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, Martin Roth, Kangheui Won, Chris Wang, Rob Barnes, EricR Lai.
Hello Frank Wu, build bot (Jenkins), Martin Roth, Kangheui Won, Chris Wang, Rob Barnes, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51165
to look at the new patch set (#3).
Change subject: mb/google/zork/var/vilboz: Update telemetry settings
......................................................................
mb/google/zork/var/vilboz: Update telemetry settings
Update telemetry settings for vilboz.
VDD Slope : 26939 -> 27225
VDD Offset: 125 -> 187
SOC Slope : 20001 -> 26559
SOC Offset: 168 -> 89
BUG=b:177162553
BRANCH=zork
TEST=emerge-zork coreboot
Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com>
Change-Id: Iaf7c5083c4c5affec5ae0b5583efb5237e10d0ec
---
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/51165/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7c5083c4c5affec5ae0b5583efb5237e10d0ec
Gerrit-Change-Number: 51165
Gerrit-PatchSet: 3
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Mathew King.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51020 )
Change subject: mb/google/guybrush: Add generated LPDDR4x SPDs
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b9bd04534d6e45dbfe10a0028052978ef3d7c17
Gerrit-Change-Number: 51020
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mathew King <mathewk(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Mathew King <mathewk(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:05:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51021 )
Change subject: mb/google/guybrush: Add SPDs to build for Guybrush variant
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3797ba6d52248961418000614a4f7885182521a3
Gerrit-Change-Number: 51021
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mathew King <mathewk(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:04:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Mathew King, Paul Menzel, Karthik Ramasubramanian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51069 )
Change subject: mb/google/guybrush: Add option to toggle GPIO for sign of life
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I069623ae76a4e4d1e43a47dd95fdfcece398ebfb
Gerrit-Change-Number: 51069
Gerrit-PatchSet: 8
Gerrit-Owner: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Mathew King <mathewk(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:02:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment