Attention is currently required from: Frank Wu, Martin Roth, Tim Wawrzynczak, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51051 )
Change subject: drivers/generic/alc1015: add ALC1015 AMP driver
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
Gerrit-Change-Number: 51051
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 05:28:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Karthik Ramasubramanian.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Furquan Shaikh, Jamie Ryu, Tim Wawrzynczak, Rizwan Qureshi, Sridhar Siricilla, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/50472
to look at the new patch set (#6).
Change subject: elog: Support logging CSE Lite info in elog
......................................................................
elog: Support logging CSE Lite info in elog
This patch adds the following updates,
1. Add support for new elog event type to log CSE Lite information in
elog.
2. Add helper functions to get cse firmware sku, manfacturing mode info in cse lib.
3. Add elog event in cse lite driver to log cse info in elog.
BUG=b:174121840
BRANCH=None
TEST=Build, boot image and check for elog entry in logs.
localhost ~ # cbmem -c | grep -i "elog"
...
ELOG: Event(B6) added with size 32 at 2021-01-17 16:01:57 UTC
localhost ~ # mosys eventlog list
0 | 2021-01-21 08:46:18 | Log area cleared | 4088
1 | 2021-01-21 08:46:18 | Memory Cache Update | Normal | Success
2 | 2021-01-21 08:46:18 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269
| YES | 0x5 | 0x3 | RO
3 | 2021-01-21 08:46:21 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269
| YES | 0x5 | 0x0 | RW
4 | 2021-01-21 08:46:25 | System boot | 3098
5 | 2021-01-21 08:46:25 | Power Fail
6 | 2021-01-21 08:46:25 | SUS Power Fail
7 | 2021-01-21 08:46:25 | ACPI Wake | S5
8 | 2021-01-21 08:46:25 | Wake Source | Power Button | 0
9 | 2021-01-21 08:46:25 | Chrome OS Developer Mode
Change-Id: Ib183941d1fa0a9971e30b4092ea3d23daaa29334
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d(a)intel.com>
---
M src/include/elog.h
M src/soc/intel/alderlake/Makefile.inc
M src/soc/intel/alderlake/me.c
M src/soc/intel/cannonlake/Makefile.inc
M src/soc/intel/cannonlake/me.c
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/include/intelblocks/cse.h
M src/soc/intel/jasperlake/Makefile.inc
M src/soc/intel/jasperlake/me.c
M src/soc/intel/tigerlake/Makefile.inc
M src/soc/intel/tigerlake/me.c
12 files changed, 115 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/50472/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/50472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib183941d1fa0a9971e30b4092ea3d23daaa29334
Gerrit-Change-Number: 50472
Gerrit-PatchSet: 6
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Hao Chou, Nick Vaccaro, Ken Lu.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49980 )
Change subject: mb/google/volteer/variants/copano: Describe USB ports in devicetree
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Tim/Nick, do you have any concern for this patch?
--
To view, visit https://review.coreboot.org/c/coreboot/+/49980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25412d16df8ad809c05635022c11bd8882d002c5
Gerrit-Change-Number: 49980
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 05:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Hao Chou, Nick Vaccaro, Ken Lu.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49980 )
Change subject: mb/google/volteer/variants/copano: Describe USB ports in devicetree
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/49980
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25412d16df8ad809c05635022c11bd8882d002c5
Gerrit-Change-Number: 49980
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 05:06:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51166 )
Change subject: drivers/generic/max98357a: Use depends HAVE_ACPI_TABLES
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Did the same thing like alc1015 :p
--
To view, visit https://review.coreboot.org/c/coreboot/+/51166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6ebfde49f0f3c205e174c5113feb75444dedba8
Gerrit-Change-Number: 51166
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 04:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, John Su, Martin Roth, Kangheui Won, Chris Wang, Rob Barnes.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51165 )
Change subject: mb/google/zork/var/vilboz: Update telemetry settings
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf7c5083c4c5affec5ae0b5583efb5237e10d0ec
Gerrit-Change-Number: 51165
Gerrit-PatchSet: 3
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 04:24:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Mary Ruthven, Joel Kitching, Vadim Bendebury, Christian Walter, Julius Werner, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51164 )
Change subject: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
Looks okay to me. Just some minor nits.
File src/security/tpm/tss/vendor/cr50/cr50.h:
https://review.coreboot.org/c/coreboot/+/51164/comment/a3314e09_e4f5220d
PS1, Line 104: Issue a halt() after triggering EC reset because cr50 leaves 50 ms after receiving
: * the command to reset the EC.
Should the function perform a halt() too instead of expecting the caller to do it?
File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/c/coreboot/+/51164/comment/b355056d_a2c6c970
PS1, Line 155: mode_command
nit: Shouldn't this be named reset_command or just cmd? I think mode_command was used in `tlcl_cr50_get_tpm_mode()` because that command dealt with getting TPM mode.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46063678511d27fea5eabbd12fc3af0b1df68143
Gerrit-Change-Number: 51164
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Joel Kitching <kitching(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Mary Ruthven <mruthven(a)google.com>
Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mary Ruthven <mruthven(a)google.com>
Gerrit-Attention: Joel Kitching <kitching(a)google.com>
Gerrit-Attention: Vadim Bendebury <vbendeb(a)google.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 04:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Henry Sun, Paul Menzel, Tao Xia, Weimin Wu, Karthik Ramasubramanian.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51017 )
Change subject: mb/google/dedede/var/storo: Support LTE module
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51017/comment/83497173_5dcb1d5b
PS2, Line 14: TEST=LTE function is OK
> Flash firmware and insert the SIM card to connect to the network.
Done
https://review.coreboot.org/c/coreboot/+/51017/comment/b99c1c57_34a5f722
PS2, Line 14: TEST=LTE function is OK
> Flash firmware and insert the SIM card to connect to the network.
Done
File src/mainboard/google/dedede/variants/storo/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/51017/comment/a964ee14_f645c620
PS2, Line 5: smm-y += variant.c
> Powering off LTE module will follow the system shutdown.
Done
File src/mainboard/google/dedede/variants/storo/variant.c:
https://review.coreboot.org/c/coreboot/+/51017/comment/872a59df_dbc5280c
PS2, Line 11: mdelay(20);
> It's refer to spec about LTE850.
Done
https://review.coreboot.org/c/coreboot/+/51017/comment/e9b66539_8cacc530
PS2, Line 11: mdelay(20);
> It's refer to spec about LTE850.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9aff9608e08eae00ab5ac8547f63bc83b62fea78
Gerrit-Change-Number: 51017
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Comment-In-Reply-To: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Frank Wu, Furquan Shaikh, Martin Roth, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51051 )
Change subject: drivers/generic/alc1015: add ALC1015 AMP driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
kernel Upstream here https://www.spinics.net/lists/alsa-devel/msg122711.html. Fixed the name.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
Gerrit-Change-Number: 51051
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:43:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment