Attention is currently required from: Frank Wu, Furquan Shaikh, Martin Roth, Tim Wawrzynczak.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Kangheui Won, Paul Menzel, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51051
to look at the new patch set (#6).
Change subject: drivers/generic/alc1015: add ALC1015 AMP driver
......................................................................
drivers/generic/alc1015: add ALC1015 AMP driver
Add ALC1015 AMP support.
ALC1015Q-VB Datasheet Rev 0.1
BUG=b:177971830
TEST: ALC1015P driver can probe properly.
Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com>
Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
---
A src/drivers/generic/alc1015/Kconfig
A src/drivers/generic/alc1015/Makefile.inc
A src/drivers/generic/alc1015/alc1015.c
A src/drivers/generic/alc1015/chip.h
4 files changed, 88 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/51051/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/51051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
Gerrit-Change-Number: 51051
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Furquan Shaikh, Martin Roth, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51051 )
Change subject: drivers/generic/alc1015: add ALC1015 AMP driver
......................................................................
Patch Set 5:
(5 comments)
File src/drivers/generic/alc1015/Kconfig:
https://review.coreboot.org/c/coreboot/+/51051/comment/53efa69d_d6532c88
PS5, Line 3:
> SG!
Done
File src/drivers/generic/alc1015/alc1015.c:
https://review.coreboot.org/c/coreboot/+/51051/comment/48f1a052_50b985b1
PS5, Line 8: #include <gpio.h>
> no need.
Done
https://review.coreboot.org/c/coreboot/+/51051/comment/04b797e2_ad96d6ed
PS5, Line 13: ALC1015_ACPI_NAME
> I can return name without define :p
Done
https://review.coreboot.org/c/coreboot/+/51051/comment/4bc15df5_e03aef2b
PS5, Line 54: config->sdb.active_low);
> oh, yes. one line can fit 96 char.
Done
File src/drivers/generic/alc1015/chip.h:
https://review.coreboot.org/c/coreboot/+/51051/comment/95716671_1685b264
PS5, Line 7: hid
> I think this is only one HID. Kernel UPSTREAM is on going. I can wait the final name.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51051
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id93845024aa2cded69acc88d594c222f2f821f79
Gerrit-Change-Number: 51051
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:42:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 )
Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51145/comment/87c42ea4_062acd21
PS2, Line 72: sx9324
> Woops. Missed that you already commented about having raised a bug. Please ignore this comment.
Not sure vendor have this plan or not. And that make some issue for compatibility of different kernel/FW. For the shipping device still use the old one but if kernel update to the new one. It might cause some issue. But not our project though. ;p
--
To view, visit https://review.coreboot.org/c/coreboot/+/51145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc
Gerrit-Change-Number: 51145
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51021 )
Change subject: mb/google/guybrush: Add SPDs to build for Guybrush variant
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3797ba6d52248961418000614a4f7885182521a3
Gerrit-Change-Number: 51021
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mathew King <mathewk(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:36:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Mathew King.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51020 )
Change subject: mb/google/guybrush: Add generated LPDDR4x SPDs
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b9bd04534d6e45dbfe10a0028052978ef3d7c17
Gerrit-Change-Number: 51020
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Mathew King <mathewk(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Mathew King <mathewk(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:36:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51057 )
Change subject: util/spd_tools/lp4x: Add 2 new parts to global memory definition
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/51057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cd729fc72d8f44a449429e97683b2ca1f560f2c
Gerrit-Change-Number: 51057
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:36:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Wonkyu Kim, Angel Pons, Bernardo Perez Priego, Srinidhi N Kaushik, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50897 )
Change subject: soc/intel/tigerlake: Add CNVi Bluetooth flag at devicetree entry
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/50897/comment/42b9c82c_c081ac86
PS6, Line 357: CnviBtCore
> one more change, add further condition for BT audio offload: […]
Rather than silently updating the config silently, what do you think about asserting if the mainboard has set the wrong config. That way it should ensure that the mainboard developer fixes the devicetree config.
```
params->CnviMode = is_dev_enabled(dev);
params->CnviBtCore = config->CnviBtCore;
params->CnviBtAudioOffload = config->CnviBtAudioOffload;
/* Assert if CNVi BT is enabled without CNVi being enabled. */
assert(params->CnviMode || !params->CnviBtCore);
/* Assert if CNVi BT offload is enabled without CNVi BT being enabled. */
assert(params->CnviBtCore || !params->CnviBtAudioOffload);
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/50897
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71c512fe884060e23ee26e7334c575c4c517b78d
Gerrit-Change-Number: 50897
Gerrit-PatchSet: 8
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: AndreX Andraos <andrex.andraos(a)intel.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:33:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 )
Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51145/comment/d2568259_326dd056
PS2, Line 72: sx9324
> Not for this change: There are some changes happening to sx9310 driver here(https://review.coreboot. […]
Woops. Missed that you already commented about having raised a bug. Please ignore this comment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc
Gerrit-Change-Number: 51145
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51145 )
Change subject: mb/google/brya: Fix a few mistakes in brya0 overridetree
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51145/comment/06d4c37d_9b4f82c6
PS2, Line 72: sx9324
Not for this change: There are some changes happening to sx9310 driver here(https://review.coreboot.org/c/coreboot/+/50210). I think similar changes will be required to sx9324 driver too. Can you please raise a bug to follow-up on that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/51145
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf586229532819a7779652cbee73755b036dfbdc
Gerrit-Change-Number: 51145
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Angel Pons, Julius Werner, Gwendal Grignou.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50210 )
Change subject: drivers/i2c: sx9310: Use open source variables
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/i2c/sx9310/registers.h:
https://review.coreboot.org/c/coreboot/+/50210/comment/50c9edda_f934cad6
PS4, Line 7: reg_prox_ctrl0
Another board needs to be fixed along with this: nocturne (https://qa.coreboot.org/job/coreboot-gerrit/164590/testReport/junit/(root)/…)
File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50210/comment/8bc1c9bb_e245cd7a
PS4, Line 158: -
_ instead of -
(https://qa.coreboot.org/job/coreboot-gerrit/164590/testReport/junit/board/c…)
--
To view, visit https://review.coreboot.org/c/coreboot/+/50210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d1c81b56eaeef1dbb0f73c1d74c3a20e8b2fd7b
Gerrit-Change-Number: 50210
Gerrit-PatchSet: 4
Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Mar 2021 03:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment