Attention is currently required from: Mathew King.
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51043
to look at the new patch set (#3).
Change subject: mb/google/guybrush: Enable Chrome EC
......................................................................
mb/google/guybrush: Enable Chrome EC
BUG=b:180507937
TEST=builds
Signed-off-by: Mathew King <mathewk(a)chromium.org>
Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb
---
M src/mainboard/google/guybrush/Kconfig
M src/mainboard/google/guybrush/Makefile.inc
A src/mainboard/google/guybrush/ec.c
M src/mainboard/google/guybrush/mainboard.c
A src/mainboard/google/guybrush/variants/baseboard/include/baseboard/ec.h
A src/mainboard/google/guybrush/variants/guybrush/include/variant/ec.h
6 files changed, 102 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/51043/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/51043
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cdd6422b1bc53ea934346327359cbc6d86baeeb
Gerrit-Change-Number: 51043
Gerrit-PatchSet: 3
Gerrit-Owner: Mathew King <mathewk(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Mathew King <mathewk(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#12).
Change subject: T440P: Enable FN Lock Inversion
......................................................................
T440P: Enable FN Lock Inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-off-by: Ph0rk0z <Crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 12
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#11).
Change subject: T440P: Enable FN Lock Inversion
......................................................................
T440P: Enable FN Lock Inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-off-by: Forkoz <crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 11
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#10).
Change subject: T440P: Enable FN Lock Inversion
......................................................................
T440P: Enable FN Lock Inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Signed-off-by: Forkoz <crabstorage(a)getbackinthe.kitchen>
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 10
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#9).
Change subject: T440P: Enable FN Lock Inversion
......................................................................
T440P: Enable FN Lock Inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-off-by: Forkoz <crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 9
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#8).
Change subject: T440P: Enable FN Lock Inversion
......................................................................
T440P: Enable FN Lock Inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-of-by: Forkoz <crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 8
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Forkoz, Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#6).
Change subject: T440P: Enable FN Lock Inversion
......................................................................
T440P: Enable FN Lock Inversion
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Signed-of-By: Forkoz <crabstorage(a)getbackinthe.kitchen>
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 6
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Patrick Rudolph.
Forkoz has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51229 )
Change subject: T440P: Update data.vbt from newer bios version.
......................................................................
T440P: Update data.vbt from newer bios version.
The old vbt was from 2012, this one is from 2013. I have tested compile and windows/linux. It works.
Signed-off-by: Forkoz <crabstorage(a)getbackinthe.kitchen>
Change-Id: Ia47d4ad1f1e8d84fb8734865f6e774e4ac062ba3
---
M src/mainboard/lenovo/t440p/data.vbt
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/51229/1
diff --git a/src/mainboard/lenovo/t440p/data.vbt b/src/mainboard/lenovo/t440p/data.vbt
index 1b2cd87..3facd1e 100644
--- a/src/mainboard/lenovo/t440p/data.vbt
+++ b/src/mainboard/lenovo/t440p/data.vbt
Binary files differ
--
To view, visit https://review.coreboot.org/c/coreboot/+/51229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia47d4ad1f1e8d84fb8734865f6e774e4ac062ba3
Gerrit-Change-Number: 51229
Gerrit-PatchSet: 1
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Attention is currently required from: Alexander Couzens, Patrick Rudolph.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51179
to look at the new patch set (#5).
Change subject: The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P. Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
......................................................................
The current f1 to f12 as primary just enables FN Lock and causes a light to enable on the keyboard of the T440P.
Newer machine firmware has the option to invert FN Lock so that the unlocked state has the light on and locked has
it off. This way you have no light and can use the F keys instead of hotkeys unless you hold FN or enable FN lock.
Obviously now we don't want FN lock on by default. This was tested on both the T440P and X250 so should be present in
all thinkpads with a FN light that had the option in the bios.
Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
---
M src/ec/lenovo/h8/Kconfig
M src/ec/lenovo/h8/h8.c
M src/mainboard/lenovo/t440p/cmos.default
M src/mainboard/lenovo/t440p/cmos.layout
4 files changed, 24 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/51179/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/51179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f03a9fbd7e16d6c30828a66502d2b72f499dfe
Gerrit-Change-Number: 51179
Gerrit-PatchSet: 5
Gerrit-Owner: Forkoz <Crabstorage(a)getbackinthe.kitchen>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset