coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: mb/google/volteer: update thermal table for Eldrid
by Nick Chen (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Keith Short, Tim Wawrzynczak, Nick Vaccaro. Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50111 ) Change subject: mb/google/volteer: update thermal table for Eldrid ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50111/comment/fa3540cb_ecbc7784 PS1, Line 14: Signed-off-by: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> > Missing "TEST=" field. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/50111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f1fe9a6de4dbb587b79cb8758c5458a3ae5d768 Gerrit-Change-Number: 50111 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Keith Short <keithshort(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 02:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Fix tsc_freq_mhz() on some platforms
by Furquan Shaikh (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Stefan Reinauer, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49232 ) Change subject: Fix tsc_freq_mhz() on some platforms ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/common/block/timer/timer.c: https://review.coreboot.org/c/coreboot/+/49232/comment/21383516_624d0212 PS1, Line 57: if (cpuid_get_max_func() < 0x15) : return 0; Drop this since the caller now performs this check? https://review.coreboot.org/c/coreboot/+/49232/comment/798bf29d_8b33b6f4 PS1, Line 113: platform_info = rdmsr(MSR_PLATFORM_INFO); : return CONFIG_CPU_BCLK_MHZ * ((platform_info.lo >> 8) & 0xff); Is this true for all x86 models? Or does there need to be a model check? Some older models I think reported using MSR_IA32_PERF_STATUS? Not sure if we care about those here? -- To view, visit https://review.coreboot.org/c/coreboot/+/49232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic42a057945a48d8bf0641d1418160906cd15a991 Gerrit-Change-Number: 49232 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 03 Feb 2021 01:33:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: update thermal table for Eldrid
by Nick Vaccaro (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Keith Short, Tim Wawrzynczak, Nick Chen. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50111 ) Change subject: mb/google/volteer: update thermal table for Eldrid ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/50111/comment/2c2b0657_e398defc PS1, Line 14: Signed-off-by: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Missing "TEST=" field. -- To view, visit https://review.coreboot.org/c/coreboot/+/50111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f1fe9a6de4dbb587b79cb8758c5458a3ae5d768 Gerrit-Change-Number: 50111 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Keith Short <keithshort(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 01:31:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: update thermal table for Eldrid
by Nick Chen (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Keith Short, Tim Wawrzynczak, Nick Vaccaro. Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50111 ) Change subject: mb/google/volteer: update thermal table for Eldrid ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/volteer/variants/eldrid/overridetree.cb: https://review.coreboot.org/c/coreboot/+/50111/comment/9b13e501_f692d93f PS1, Line 104: 60.8 > This will turn into `60` (it's an unsigned int type), did you mean 60? I mean 60.8 but turn into 60 is ok. -- To view, visit https://review.coreboot.org/c/coreboot/+/50111 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f1fe9a6de4dbb587b79cb8758c5458a3ae5d768 Gerrit-Change-Number: 50111 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Chen <nick_xr_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Keith Short <keithshort(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Keith Short <keithshort(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 01:23:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD
by Arthur Heymans (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Angel Pons, Morgan Jang. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50237 ) Change subject: mb/ocp/deltalake: Implement skipping TXT lockdown via VPD ...................................................................... Patch Set 1: (1 comment) File src/mainboard/ocp/deltalake/ramstage.c: https://review.coreboot.org/c/coreboot/+/50237/comment/6ad1ff1c_123ddcd9 PS1, Line 368: static bool fetched_vpd = 0; > Do you really need to cache this? The function is only called once The follow-up patch does ;) -- To view, visit https://review.coreboot.org/c/coreboot/+/50237 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5daf96bdda9c36054c410b07b08bcd3482d777c Gerrit-Change-Number: 50237 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 01:20:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/var/voema: Enable EEPROM for OV2740
by David Wu (Code Review) 03 Feb '21

03 Feb '21

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50216 ) Change subject: mb/google/volteer/var/voema: Enable EEPROM for OV2740 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks Tim and Jim. -- To view, visit https://review.coreboot.org/c/coreboot/+/50216 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8fb684166649f78713050d62445bf47189b06ab Gerrit-Change-Number: 50216 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jim Lai <jim.lai(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 03 Feb 2021 00:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/cbfs.h: Add comment for chain-includes of commonlib
by Julius Werner (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Philipp Hug, Kyösti Mälkki, ron minnich, HAOUAS Elyes. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50167 ) Change subject: include/cbfs.h: Add comment for chain-includes of commonlib ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I mean, FWI (stupid Gerrit submitting half-written comments after I already clicked Cancel...) -- To view, visit https://review.coreboot.org/c/coreboot/+/50167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98fb5df0148a3f5fe0bc5b08c5a0b8b1e95c4624 Gerrit-Change-Number: 50167 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 03 Feb 2021 00:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: include/cbfs.h: Add comment for chain-includes of commonlib
by Julius Werner (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Philipp Hug, Kyösti Mälkki, ron minnich, HAOUAS Elyes. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50167 ) Change subject: include/cbfs.h: Add comment for chain-includes of commonlib ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: > I am tempted to -2 works on indirect includes until something appears under Documentation/. I've drafted an addition to the coding style as CB:50247 (it currently doesn't say anything about includes, FWIW), let me know what you think. PS4: I mean, FWI -- To view, visit https://review.coreboot.org/c/coreboot/+/50167 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98fb5df0148a3f5fe0bc5b08c5a0b8b1e95c4624 Gerrit-Change-Number: 50167 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 03 Feb 2021 00:37:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Codify some guidelines for headers and chain-including
by Julius Werner (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Martin Roth, Kyösti Mälkki, HAOUAS Elyes. Hello Patrick Georgi, Martin Roth, Kyösti Mälkki, HAOUAS Elyes, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/50247 to review the following change. Change subject: Documentation: Codify some guidelines for headers and chain-including ...................................................................... Documentation: Codify some guidelines for headers and chain-including There has been some repeated discussion about how header includes should be formatted, specifically on the topic of chain-including. The coding style currently doesn't say anything about the topic but clearly people have some basic assumptions. This patch tries to codify some common ground rules that are supposed to reflect the existing practice. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: Ibbcde306a814f52b3a41b58c7a33bdd99b0187e0 --- M Documentation/coding_style.md 1 file changed, 39 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/50247/1 diff --git a/Documentation/coding_style.md b/Documentation/coding_style.md index ac0de4e..ca45096 100644 --- a/Documentation/coding_style.md +++ b/Documentation/coding_style.md @@ -834,22 +834,51 @@ out-of-range result. Typical examples would be functions that return pointers; they use NULL or the ERR_PTR mechanism to report failure. -Don't re-invent the kernel macros ----------------------------------- +Headers and includes +--------------- -The header file include/linux/kernel.h contains a number of macros that -you should use, rather than explicitly coding some variant of them -yourself. For example, if you need to calculate the length of an array, -take advantage of the macro +Headers should always be included at the top of the file, preferrably in +alphabetical order. Includes should always use the `#include <file.h>` +notation, except for rare cases where a file in the same directory that +is not part of a normal include path gets included (e.g. local headers +in mainboard directories), which should use `#include "file.h"`. Headers +that can be included from both assembly files and .c files should keep +all C code wrapped in `#ifndef __ASSEMBLER__` blocks, including includes +to other headers that don't follow that provision. + +Files should generally include every header they need a definition from +directly (and not include any unnecessary extra headers). Excepted from +this are certain headers that intentionally chain-include other headers +which logically belong to them and are just factored out into a separate +location for implementation or organizatory reasons. This could be +because part of the definitions is generic and part SoC-specific (e.g. +`<gpio.h>` chain-including `<soc/gpio.h>`), architecture-specific (e.g. +`<device/mmio.h>` chain-including `<arch/mmio.h>`), separated out into +commonlib[/bsd] for sharing/license reasons (e.g. `<cbfs.h>` +chain-including `<commonlib/bsd/cbfs_serialized.h>`) or just split out +to make organizing subunits of a larger header easier. This can also +happen when certain definitions need to be in a specific header for +legacy POSIX reasons but we would like to logically group them together +(e.g. `uintptr_t` is in `<stdint.h>` and `size_t` in `<stddef.h>`, but +it's nicer to be able to just include `<types.h>` and get all the common +type and helper function stuff we need everywhere). + +The headers `<kconfig.h>`, `<rules.h>` and `<commonlib/bsd/compiler.h>` +are always automatically included in all compilation units by the build +system and should not be included manually. + +Don't re-invent common macros +----------------------------- + +The header file `src/commonlib/bsd/include/commonlib/bsd/helpers.h` +contains a number of macros that you should use, rather than explicitly +coding some variant of them yourself. For example, if you need to +calculate the length of an array, take advantage of the macro ```c #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) ``` -There are also min() and max() macros that do strict type checking if -you need them. Feel free to peruse that header file to see what else is -already defined that you shouldn't reproduce in your code. - Editor modelines and other cruft -------------------------------- -- To view, visit https://review.coreboot.org/c/coreboot/+/50247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbcde306a814f52b3a41b58c7a33bdd99b0187e0 Gerrit-Change-Number: 50247 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/cezanne: populate some FSP-M UPDs
by Felix Held (Code Review) 03 Feb '21

03 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50239 ) Change subject: soc/amd/cezanne: populate some FSP-M UPDs ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/cezanne/romstage.c: https://review.coreboot.org/c/coreboot/+/50239/comment/9ff890b5_2e96b62b PS2, Line 19: 1 > Cezanne doesn't support a stride of 1 though. […] ah, DRIVERS_UART_8250MEM and DRIVERS_UART_8250MEM_32 only get selected together, so this is indeed for the support of legacy i/o mapped uarts -- To view, visit https://review.coreboot.org/c/coreboot/+/50239 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81a812662f921d0bf8d436238d338b6a1fa6a9ee Gerrit-Change-Number: 50239 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Justin Frodsham <justin.frodsham(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Comment-Date: Wed, 03 Feb 2021 00:33:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021