coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: security/intel/txt/Makefile.inc: Use tab for indent
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50432 ) Change subject: security/intel/txt/Makefile.inc: Use tab for indent ...................................................................... security/intel/txt/Makefile.inc: Use tab for indent Change-Id: Ic85a3b6cfb462f335df99e7d6c6c7aa46dc094e7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/security/intel/txt/Makefile.inc 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/50432/1 diff --git a/src/security/intel/txt/Makefile.inc b/src/security/intel/txt/Makefile.inc index bac4eb8..cdcbd40 100644 --- a/src/security/intel/txt/Makefile.inc +++ b/src/security/intel/txt/Makefile.inc @@ -30,20 +30,20 @@ $(call add_intermediate, add_acm_fit, $(IFITTOOL)) $(IFITTOOL) -r COREBOOT -a -n $(CONFIG_INTEL_TXT_CBFS_BIOS_ACM) -t 2 \ - -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -f $< + -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -f $< # CBnT does not use FIT for IBB ifneq ($(CONFIG_INTEL_CBNT_SUPPORT),y) # Initial BootBlock files ibb-files := $(foreach file,$(cbfs-files), \ - $(if $(shell echo '$(call extract_nth,7,$(file))'|grep -- --ibb), \ - $(call extract_nth,2,$(file)),)) + $(if $(shell echo '$(call extract_nth,7,$(file))'|grep -- --ibb), \ + $(call extract_nth,2,$(file)),)) ibb-files += bootblock $(call add_intermediate, add_ibb_fit, $(IFITTOOL)) $(foreach file, $(ibb-files), $(shell $(IFITTOOL) -f $< -a -n $(file) -t 7 \ - -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -r COREBOOT)) true + -s $(CONFIG_CPU_INTEL_NUM_FIT_ENTRIES) -r COREBOOT)) true endif # INTEL_CBNT_SUPPORT -- To view, visit https://review.coreboot.org/c/coreboot/+/50432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic85a3b6cfb462f335df99e7d6c6c7aa46dc094e7 Gerrit-Change-Number: 50432 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/volteer/variants: Remove unneeded whitespace before tab
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50431 ) Change subject: mb/google/volteer/variants: Remove unneeded whitespace before tab ...................................................................... mb/google/volteer/variants: Remove unneeded whitespace before tab Change-Id: I4c991e6119f14d949a2e103024132d70674f29a1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/50431/1 diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index d0d1c28..6f7ca6b 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -578,7 +578,7 @@ { "i2c-allow-low-power-probe", 0x01 - } + } } }) Name (PRT0, Package (0x04) -- To view, visit https://review.coreboot.org/c/coreboot/+/50431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c991e6119f14d949a2e103024132d70674f29a1 Gerrit-Change-Number: 50431 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/amd/mandolin/Kconfig: Remove unneeded whitespace before tab
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50430 ) Change subject: mb/amd/mandolin/Kconfig: Remove unneeded whitespace before tab ...................................................................... mb/amd/mandolin/Kconfig: Remove unneeded whitespace before tab Change-Id: I2b52c32a607386cdc1ca00531eda4dfc0bfaab1e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/amd/mandolin/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/50430/1 diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 7c9387a..1e933c8 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -43,8 +43,8 @@ config SUPERIO_ADDR_BASE hex - default 0x4e if SMSC_SIO1036_BASE_4E - default 0x164e if SMSC_SIO1036_BASE_164E + default 0x4e if SMSC_SIO1036_BASE_4E + default 0x164e if SMSC_SIO1036_BASE_164E config CBFS_SIZE hex -- To view, visit https://review.coreboot.org/c/coreboot/+/50430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b52c32a607386cdc1ca00531eda4dfc0bfaab1e Gerrit-Change-Number: 50430 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: arch/x86/id.S: Remove unneeded whitespace before tab
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50429 ) Change subject: arch/x86/id.S: Remove unneeded whitespace before tab ...................................................................... arch/x86/id.S: Remove unneeded whitespace before tab Change-Id: I053a2a8cff3fda1a1074f74e4d4c174a0cb24d86 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/id.S 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/50429/1 diff --git a/src/arch/x86/id.S b/src/arch/x86/id.S index 574a7dc..b569178 100644 --- a/src/arch/x86/id.S +++ b/src/arch/x86/id.S @@ -12,11 +12,11 @@ .asciz CONFIG_MAINBOARD_PART_NUMBER #if ENV_X86_64 -.long 0xffffffff - ver + 1 /* Reverse offset to the version */ +.long 0xffffffff - ver + 1 /* Reverse offset to the version */ .long 0xffffffff - vendor + 1 /* Reverse offset to the vendor id */ .long 0xffffffff - part + 1 /* Reverse offset to the part number */ #else -.long - ver /* Reverse offset to the version */ +.long - ver /* Reverse offset to the version */ .long - vendor /* Reverse offset to the vendor id */ .long - part /* Reverse offset to the part number */ #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/50429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I053a2a8cff3fda1a1074f74e4d4c174a0cb24d86 Gerrit-Change-Number: 50429 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/superio: Fix typo in comment
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50428 ) Change subject: src/superio: Fix typo in comment ...................................................................... src/superio: Fix typo in comment Change-Id: I2e5cac310af824eb9756b2aa9459239e0b5784da Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/acpi/pnp_config.asl M src/superio/winbond/w83627hf/acpi/superio.asl 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/50428/1 diff --git a/src/superio/acpi/pnp_config.asl b/src/superio/acpi/pnp_config.asl index ff74153..0257cc7 100644 --- a/src/superio/acpi/pnp_config.asl +++ b/src/superio/acpi/pnp_config.asl @@ -27,7 +27,7 @@ /* * Enter configuration mode (and aquire mutex) - * Method must be run before accesssing the configuration region. + * Method must be run before accessing the configuration region. * Parameter is the LDN which should be accessed. Values >= 0xFF mean * no LDN switch should be done. */ diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index 1f92df9..5e23cb0 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -144,7 +144,7 @@ } /* Enter configuration mode (and aquire mutex) - Method must be run before accesssing the configuration region. + Method must be run before accessing the configuration region. Parameter is the LDN which should be accessed. Values >= 0xFF mean no LDN switch should be done. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/50428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e5cac310af824eb9756b2aa9459239e0b5784da Gerrit-Change-Number: 50428 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled`
by Angel Pons (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Werner Zeh, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50426 ) Change subject: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > There is one additional point to consider: […] Right. For this use-case, having a Kconfig option would still work. -- To view, visit https://review.coreboot.org/c/coreboot/+/50426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I313194edb3795962a42eebde9683579abc078851 Gerrit-Change-Number: 50426 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 12:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/external: add support for BOOTBOOT payload
by Zoltan Baldaszti (Code Review) 09 Feb '21

09 Feb '21

Zoltan Baldaszti has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45483 ) Change subject: payloads/external: add support for BOOTBOOT payload ...................................................................... payloads/external: add support for BOOTBOOT payload Change-Id: I6ba99a3ebb8f10b0ab1e9541bfe313b58d5ac4f4 Signed-off-by: Zoltan Baldaszti <bztemail(a)gmail.com> --- M payloads/external/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/45483/1 diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 15d7348..da199e4 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -308,4 +308,3 @@ payloads/external/BOOTBOOT/bootboot/dist/bootbootcb.elf: $(MAKE) -C payloads/external/BOOTBOOT all - -- To view, visit https://review.coreboot.org/c/coreboot/+/45483 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ba99a3ebb8f10b0ab1e9541bfe313b58d5ac4f4 Gerrit-Change-Number: 45483 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Baldaszti <bztemail(a)gmail.com> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled`
by Werner Zeh (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Subrata Banik, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50426 ) Change subject: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would prefer to simply drop the option. It's not board […] There is one additional point to consider: There are valid cases where one would like to disable this feature in order to prevent the CPU frequency changing due to current computing power demand. This can be very nasty in real time environments and for instance siemens mc_xxxx boards would generally disable eist. So having this feature configurable is very handy. -- To view, visit https://review.coreboot.org/c/coreboot/+/50426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I313194edb3795962a42eebde9683579abc078851 Gerrit-Change-Number: 50426 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 12:51:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/amd/agesa/hudson/amd_pci_int_defs.h: Fix comments
by Michał Żygowski (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Angel Pons. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50425 ) Change subject: sb/amd/agesa/hudson/amd_pci_int_defs.h: Fix comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff701d8e6d672b3ca97d9d6361ba48736c06c6c1 Gerrit-Change-Number: 50425 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 11:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled`
by Nico Huber (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Subrata Banik, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50426 ) Change subject: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I would prefer to simply drop the option. It's not board specific. Maybe OS specific, but then it shouldn't be a devicetree option. The only argument for such an option that I can imagine is to minimize coreboot code, but that's not about hard- ware at all. -- To view, visit https://review.coreboot.org/c/coreboot/+/50426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I313194edb3795962a42eebde9683579abc078851 Gerrit-Change-Number: 50426 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 11:49:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021