coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: mb/amd/mandolin/Kconfig: Remove unneeded whitespace before tab
by Frans Hendriks (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Jason Glenesk, Marshall Dawson, HAOUAS Elyes, Felix Held. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50430 ) Change subject: mb/amd/mandolin/Kconfig: Remove unneeded whitespace before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b52c32a607386cdc1ca00531eda4dfc0bfaab1e Gerrit-Change-Number: 50430 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Feb 2021 14:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/id.S: Remove unneeded whitespace before tab
by Frans Hendriks (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: HAOUAS Elyes. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50429 ) Change subject: arch/x86/id.S: Remove unneeded whitespace before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I053a2a8cff3fda1a1074f74e4d4c174a0cb24d86 Gerrit-Change-Number: 50429 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 09 Feb 2021 14:41:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mainboard: Remove unneeded whitespace before tab
by Frans Hendriks (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Felix Singer, HAOUAS Elyes. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50433 ) Change subject: src/mainboard: Remove unneeded whitespace before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37f12f5cb35ea1a6ad33edb114688ce1619030a4 Gerrit-Change-Number: 50433 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 09 Feb 2021 14:41:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/superio: Fix typo in comment
by Frans Hendriks (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: HAOUAS Elyes, Felix Held. Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50428 ) Change subject: src/superio: Fix typo in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e5cac310af824eb9756b2aa9459239e0b5784da Gerrit-Change-Number: 50428 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Feb 2021 14:41:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/mainboard: Remove unneeded whitespace before tab
by Nico Huber (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Felix Singer, HAOUAS Elyes. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50433 ) Change subject: src/mainboard: Remove unneeded whitespace before tab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37f12f5cb35ea1a6ad33edb114688ce1619030a4 Gerrit-Change-Number: 50433 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 09 Feb 2021 14:38:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled`
by Werner Zeh (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Subrata Banik, Patrick Rudolph. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50426 ) Change subject: [RFC] soc/intel/{adl,ehl,icl,jsl,tgl}: Invert `eist_enabled` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Right. For this use-case, having a Kconfig option would still work. Agree, that would be good enough. -- To view, visit https://review.coreboot.org/c/coreboot/+/50426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I313194edb3795962a42eebde9683579abc078851 Gerrit-Change-Number: 50426 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 14:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp; Remove unneeded whitespace before tab
by build bot (Jenkins) (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50435 ) Change subject: soc/intel/xeon_sp; Remove unneeded whitespace before tab ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/xeon_sp/include/soc/acpi_asl.h: https://review.coreboot.org/c/coreboot/+/50435/comment/8433be46_94026057 PS1, Line 40: Method (_CRS, 0, Serialized) \ space prohibited between function name and open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/50435 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56f0d4aa627155ee318362f626347d7990571dcb Gerrit-Change-Number: 50435 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 09 Feb 2021 13:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp; Remove unneeded whitespace before tab
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Patrick Rudolph. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50435 ) Change subject: soc/intel/xeon_sp; Remove unneeded whitespace before tab ...................................................................... soc/intel/xeon_sp; Remove unneeded whitespace before tab Change-Id: I56f0d4aa627155ee318362f626347d7990571dcb Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/xeon_sp/include/soc/acpi_asl.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/50435/1 diff --git a/src/soc/intel/xeon_sp/include/soc/acpi_asl.h b/src/soc/intel/xeon_sp/include/soc/acpi_asl.h index e08e02b..c4ffed3 100644 --- a/src/soc/intel/xeon_sp/include/soc/acpi_asl.h +++ b/src/soc/intel/xeon_sp/include/soc/acpi_asl.h @@ -37,7 +37,7 @@ { \ Return (PRS##id) \ } \ - Method (_CRS, 0, Serialized) \ + Method (_CRS, 0, Serialized) \ { \ Name (RTLA, ResourceTemplate () \ { \ -- To view, visit https://review.coreboot.org/c/coreboot/+/50435 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56f0d4aa627155ee318362f626347d7990571dcb Gerrit-Change-Number: 50435 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common/block/cpu/noncar: Remove unneeded whitespace before tab
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held. HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50434 ) Change subject: soc/amd/common/block/cpu/noncar: Remove unneeded whitespace before tab ...................................................................... soc/amd/common/block/cpu/noncar: Remove unneeded whitespace before tab Change-Id: Ib88358ca26876cd25247cd9619fb2b70f6859ac2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/50434/1 diff --git a/src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc b/src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc index d9bd096..1b80f6b 100644 --- a/src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc +++ b/src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc @@ -11,7 +11,7 @@ ALIGN_COUNTER(64) PRERAM_CBMEM_CONSOLE(., CONFIG_PRERAM_CBMEM_CONSOLE_SIZE) - TIMESTAMP(., TIMESTAMP_BUFFER_SIZE) + TIMESTAMP(., TIMESTAMP_BUFFER_SIZE) CBFS_MCACHE(., CONFIG_CBFS_MCACHE_SIZE) FMAP_CACHE(., FMAP_SIZE) -- To view, visit https://review.coreboot.org/c/coreboot/+/50434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib88358ca26876cd25247cd9619fb2b70f6859ac2 Gerrit-Change-Number: 50434 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: src/mainboard: Remove unneeded whitespace before tab
by HAOUAS Elyes (Code Review) 09 Feb '21

09 Feb '21

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50433 ) Change subject: src/mainboard: Remove unneeded whitespace before tab ...................................................................... src/mainboard: Remove unneeded whitespace before tab Change-Id: I37f12f5cb35ea1a6ad33edb114688ce1619030a4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/acer/g43t-am3/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/siemens/chili/variants/chili/devicetree.cb 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/50433/1 diff --git a/src/mainboard/acer/g43t-am3/devicetree.cb b/src/mainboard/acer/g43t-am3/devicetree.cb index 4266861..a713f34 100644 --- a/src/mainboard/acer/g43t-am3/devicetree.cb +++ b/src/mainboard/acer/g43t-am3/devicetree.cb @@ -108,7 +108,7 @@ irq 0x70 = 0x0c irq 0xf0 = 0x00 end - device pnp 2e.7 on # GPIO + device pnp 2e.7 on # GPIO io 0x60 = 0x000 io 0x62 = 0xa20 io 0x64 = 0xa30 @@ -140,7 +140,7 @@ end end device pci 1f.2 on end # SATA (IDE: port 0-3, AHCI/RAID: 0-5) - device pci 1f.3 on # SMBus + device pci 1f.3 on # SMBus chip drivers/i2c/ck505 # IDT CV194 register "mask" = "{ 0xff, 0xff, 0xff, 0x00, 0xff, 0x00, 0x00, 0x00, diff --git a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb index c1e80c8..a449200 100644 --- a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb @@ -44,7 +44,7 @@ device pci 1b.0 on end # HD Audio controller device pci 1d.0 on end # USB2 EHCI #1 device pci 1e.0 off end # PCI bridge - device pci 1f.0 on # LPC bridge + device pci 1f.0 on # LPC bridge chip drivers/pc80/tpm device pnp 0c31.0 on end end diff --git a/src/mainboard/siemens/chili/variants/chili/devicetree.cb b/src/mainboard/siemens/chili/variants/chili/devicetree.cb index 8595ce8..4416dbf 100644 --- a/src/mainboard/siemens/chili/variants/chili/devicetree.cb +++ b/src/mainboard/siemens/chili/variants/chili/devicetree.cb @@ -55,11 +55,11 @@ register "vin[4].high" = "12000 * 105/100" register "temp_in[0].low" = "-25" - register "temp_in[0].high" = " 85" + register "temp_in[0].high" = " 85" register "temp_in[1].low" = "-25" - register "temp_in[1].high" = " 85" + register "temp_in[1].high" = " 85" register "temp_in[2].low" = "-25" - register "temp_in[2].high" = " 85" + register "temp_in[2].high" = " 85" register "fan[0]" = "{ .mode = LM96000_FAN_HOTTEST_123, -- To view, visit https://review.coreboot.org/c/coreboot/+/50433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37f12f5cb35ea1a6ad33edb114688ce1619030a4 Gerrit-Change-Number: 50433 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021