coreboot-gerrit February 2021

coreboot-gerrit@coreboot.org

1 participants
7192 discussions

Change in coreboot[master]: intel/xeon_sp/util: Use get_stack_busno instead of get_cpubusnos
by Maxim Polyakov (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Marc Jones, Maxim Polyakov, Patrick Rudolph. Hello build bot (Jenkins), Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Angel Pons, Morgan Jang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49458 to look at the new patch set (#14). Change subject: intel/xeon_sp/util: Use get_stack_busno instead of get_cpubusnos ...................................................................... intel/xeon_sp/util: Use get_stack_busno instead of get_cpubusnos This function is more convenient to get the value of a single bus number than get_cpubusnos(). Now get_cpubusnos is not used anywhere, so remove it. Change-Id: I71c06c2d69344d97e48609e67a3966ed8c671152 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M src/soc/intel/xeon_sp/include/soc/util.h M src/soc/intel/xeon_sp/util.c 2 files changed, 1 insertion(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/49458/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/49458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I71c06c2d69344d97e48609e67a3966ed8c671152 Gerrit-Change-Number: 49458 Gerrit-PatchSet: 14 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Revert "mb/intel/shadowmountain: Add the ASL code"
by Paul Menzel (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: V Sowmya, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Aamir Bohra. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50055 ) Change subject: Revert "mb/intel/shadowmountain: Add the ASL code" ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Any idea why the build fails? ``` + nice -n 20 make --no-print-directory what-jenkins-does BUILD_TIMELESS=1 Check that files have license headers (lint-stable-000-license-headers): success Check for superfluous whitespace in the tree (lint-stable-003-whitespace): success Check that C labels begin at start-of-line (lint-stable-004-style-labels): success Check that every board has a meaningful board_info.txt (lint-stable-005-board-status): Terminated success Check that every vendor and board has a Kconfig.name (lint-stable-006-board-name): success Check Kconfig files for errors (lint-stable-008-kconfig): make: *** [util/testing/Makefile.inc:83: what-jenkins-does] Terminated Build was aborted Aborted by new patch set. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/50055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa5e8cc2ad485bf82bfbda151bc46d26faef7ab Gerrit-Change-Number: 50055 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Comment-Date: Thu, 11 Feb 2021 10:07:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/intel/shadowmountain: Add the ASL code"
by Patrick Georgi (Code Review) 11 Feb '21

11 Feb '21

1 0

Change in coreboot[master]: mb/intel/shadowmountain: Add the ASL code
by Patrick Georgi (Code Review) 11 Feb '21

11 Feb '21

Patrick Georgi has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/49733 ) Change subject: mb/intel/shadowmountain: Add the ASL code ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/49733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I511b2d23c424b0565ad1abcc3b41cace1b89936e Gerrit-Change-Number: 49733 Gerrit-PatchSet: 5 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: revert

1 0

Change in coreboot[master]: Revert "mb/intel/shadowmountain: Add the ASL code"
by Patrick Georgi (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: V Sowmya, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Aamir Bohra. Hello V Sowmya, build bot (Jenkins), Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Aamir Bohra, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/50055 to review the following change. Change subject: Revert "mb/intel/shadowmountain: Add the ASL code" ...................................................................... Revert "mb/intel/shadowmountain: Add the ASL code" This reverts commit 2151f7561d728a9280d69d20ef56a9fe44db7cb1. Reason for revert: It depends on one of the other shadowmountain patches, probably the ramstage code. Error on the builder: IASL /cb-build/coreboot.0/default/INTEL_SHADOWMOUNTAIN/dsdt.aml src/mainboard/intel/shadowmountain/dsdt.asl:4:10: fatal error: baseboard/ec.h: No such file or directory #include <baseboard/ec.h> ^~~~~~~~~~~~~~~~ compilation terminated. Change-Id: I9fa5e8cc2ad485bf82bfbda151bc46d26faef7ab --- M src/mainboard/intel/shadowmountain/dsdt.asl 1 file changed, 0 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/50055/1 diff --git a/src/mainboard/intel/shadowmountain/dsdt.asl b/src/mainboard/intel/shadowmountain/dsdt.asl index f94ad37..c8dc9ee 100644 --- a/src/mainboard/intel/shadowmountain/dsdt.asl +++ b/src/mainboard/intel/shadowmountain/dsdt.asl @@ -1,8 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <acpi/acpi.h> -#include <baseboard/ec.h> -#include <baseboard/gpio.h> DefinitionBlock( "dsdt.aml", @@ -14,31 +12,4 @@ ) { #include <acpi/dsdt_top.asl> - #include <soc/intel/common/block/acpi/acpi/platform.asl> - - /* global NVS and variables */ - #include <soc/intel/common/block/acpi/acpi/globalnvs.asl> - - /* CPU */ - #include <cpu/intel/common/acpi/cpu.asl> - - Scope (\_SB) { - Device (PCI0) - { - #include <soc/intel/common/block/acpi/acpi/northbridge.asl> - #include <soc/intel/alderlake/acpi/southbridge.asl> - #include <soc/intel/alderlake/acpi/tcss.asl> - } - } - - /* Chrome OS Embedded Controller */ - Scope (\_SB.PCI0.LPCB) - { - // ACPI code for EC SuperIO functions - #include <ec/google/chromeec/acpi/superio.asl> - // ACPI code for EC functions - #include <ec/google/chromeec/acpi/ec.asl> - } - - #include <southbridge/intel/common/acpi/sleepstates.asl> } -- To view, visit https://review.coreboot.org/c/coreboot/+/50055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fa5e8cc2ad485bf82bfbda151bc46d26faef7ab Gerrit-Change-Number: 50055 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/spi: Stop using a variable-length array
by Angel Pons (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Julius Werner, Jacob Garber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50480 ) Change subject: drivers/spi: Stop using a variable-length array ...................................................................... Patch Set 1: (2 comments) File src/drivers/spi/adesto.c: https://review.coreboot.org/c/coreboot/+/50480/comment/dc18dd72_3fa310b7 PS1, Line 94: DEFAULT_PAGE_SIZE_SHIFT > Hiding this behind a macro here doesn't feel right to me, even if it's currently the same everywhere […] Good point File src/drivers/spi/spi_flash.c: https://review.coreboot.org/c/coreboot/+/50480/comment/441a53a2_4d24fd6b PS1, Line 95: u8 buff[4 + (1 << DEFAULT_PAGE_SIZE_SHIFT)]; > Rather than explicitly tying this to any page size, why not just define a constant like MAX_FLASH_CM […] Hmmm... The problem is that we need to concatenate two buffers. There must be a better way to avoid this. -- To view, visit https://review.coreboot.org/c/coreboot/+/50480 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib630bff1b496bc276616989d4506a3c96f242e26 Gerrit-Change-Number: 50480 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Comment-Date: Thu, 11 Feb 2021 09:58:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Add initial code for adl-m variant board
by Maulik V Vaghela (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Varshit B Pandya, Francois Toguo Fotso, Sridhar Siricilla, Subrata Banik. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49871 ) Change subject: mb/intel/adlrvp_m: Add initial code for adl-m variant board ...................................................................... Patch Set 20: (3 comments) File src/mainboard/intel/adlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/49871/comment/9a481c13_f5465901 PS12, Line 58: BOARD_INTEL_ADLRVP_M > || BOARD_INTEL_ADLRVP_M_EXT_EC Done https://review.coreboot.org/c/coreboot/+/49871/comment/0be9dbb6_677a688a PS12, Line 59: default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb" if BOARD_INTEL_ADLRVP_M_EXT_EC > remove this line? Done File src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/devicetree.cb: https://review.coreboot.org/c/coreboot/+/49871/comment/0547e052_613ab122 PS12, Line 1: chip soc/intel/alderlake > Sure Subrata... I have pushed patchset #13, to unblock External EC board bring up. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/49871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I997b89ba87fb03dfa6a836caec51efd05baa2e8d Gerrit-Change-Number: 49871 Gerrit-PatchSet: 20 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Thu, 11 Feb 2021 09:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Add initial code for adl-m variant board
by Maulik V Vaghela (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Varshit B Pandya, Francois Toguo Fotso, Sridhar Siricilla, Subrata Banik. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49871 ) Change subject: mb/intel/adlrvp_m: Add initial code for adl-m variant board ...................................................................... Patch Set 20: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/49871/comment/60c9324c_335f2daa PS8, Line 7: adlrvm > adlrvp Done -- To view, visit https://review.coreboot.org/c/coreboot/+/49871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I997b89ba87fb03dfa6a836caec51efd05baa2e8d Gerrit-Change-Number: 49871 Gerrit-PatchSet: 20 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Thu, 11 Feb 2021 09:57:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Add initial code for adl-m variant board
by Maulik V Vaghela (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Varshit B Pandya, Francois Toguo Fotso, Subrata Banik. Maulik V Vaghela has uploaded a new patch set (#20) to the change originally created by Varshit B Pandya. ( https://review.coreboot.org/c/coreboot/+/49871 ) Change subject: mb/intel/adlrvp_m: Add initial code for adl-m variant board ...................................................................... mb/intel/adlrvp_m: Add initial code for adl-m variant board List of changes: 1. Add mainboard Kconfig to Kconfig.name files 2. Handle mainboard names in Kconfig file for adlrvp 3. Add override devicetree for ADL-M RVP. 4. Configure proper PCI and USB ports as per schematics for ADL-M Since ADL-M RVP uses ADL-M PCH, There is difference in number of root ports supported for each. Moving extra ports for ADL-P inside it's overridetree.cb to prevent compilation error. BUG=None BRANCH=None TEST=Able to build ADL-M RVP variants adlrvp_m and adlrvp_m_ext_ec. Signed-0ff-by: Maulik Vaghela <maulik.v.vaghela(a)intel.com> Signed-off-by: Varshit Pandya <varshit.b.pandya(a)intel.com> Change-Id: I997b89ba87fb03dfa6a836caec51efd05baa2e8d --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Kconfig.name A src/mainboard/intel/adlrvp/devicetree_m.cb A src/mainboard/intel/adlrvp/variants/adlrvp_m/overridetree.cb A src/mainboard/intel/adlrvp/variants/adlrvp_m_ext_ec/overridetree.cb 5 files changed, 317 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/49871/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/49871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I997b89ba87fb03dfa6a836caec51efd05baa2e8d Gerrit-Change-Number: 49871 Gerrit-PatchSet: 20 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: tint: update the patch version numbers according to a new tint version
by Angel Pons (Code Review) 11 Feb '21

11 Feb '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Mike Banon. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50468 ) Change subject: tint: update the patch version numbers according to a new tint version ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50468 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91f780f80026147c3c35330625a4106c65a1ddf0 Gerrit-Change-Number: 50468 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Comment-Date: Thu, 11 Feb 2021 09:46:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2021