coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60512 ) Change subject: sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... sb/intel/bd82x6x/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I17ab35629b5545052c214e3cb2d57788b6a5b7ad Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60512 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/acpi/lpc.asl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/southbridge/intel/bd82x6x/acpi/lpc.asl b/src/southbridge/intel/bd82x6x/acpi/lpc.asl index 9df8ac6..2e86157 100644 --- a/src/southbridge/intel/bd82x6x/acpi/lpc.asl +++ b/src/southbridge/intel/bd82x6x/acpi/lpc.asl @@ -91,15 +91,15 @@ If (HPTE) { CreateDWordField(BUF0, \_SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 } If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 } If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17ab35629b5545052c214e3cb2d57788b6a5b7ad Gerrit-Change-Number: 60512 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60495 ) Change subject: arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... arch/x86/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I10a94406aa7e66eed4fec22f56b7a8802252e781 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60495 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/arch/x86/acpi/globutil.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/arch/x86/acpi/globutil.asl b/src/arch/x86/acpi/globutil.asl index 2600d0b..25feaea 100644 --- a/src/arch/x86/acpi/globutil.asl +++ b/src/arch/x86/acpi/globutil.asl @@ -24,7 +24,7 @@ Method(S2BF, 1, Serialized) { - Add(SLEN(Arg0), One, Local0) + Local0 = SLEN(Arg0) + 1 Name(BUFF, Buffer(Local0) {}) Store(Arg0, BUFF) Return(BUFF) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10a94406aa7e66eed4fec22f56b7a8802252e781 Gerrit-Change-Number: 60495 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60494 ) Change subject: soc/intel/apollolake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I4d6039affd9688a2e795d69f699d5baf688ba2e4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60494 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/apollolake/acpi/gpiolib.asl M src/soc/intel/apollolake/acpi/northbridge.asl 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/apollolake/acpi/gpiolib.asl b/src/soc/intel/apollolake/acpi/gpiolib.asl index 0ec9140..e01d549 100644 --- a/src/soc/intel/apollolake/acpi/gpiolib.asl +++ b/src/soc/intel/apollolake/acpi/gpiolib.asl @@ -69,7 +69,7 @@ Method (CHSA, 0x1, Serialized) { /* Arg0 - GPIO pad offset relative to the community */ - Add (HOSTSW_OWN_REG_0, Multiply (Divide (Arg0, 32), 4), Local1) + Local1 = HOSTSW_OWN_REG_0 + Multiply (Divide (Arg0, 32), 4) Return (Local1) } diff --git a/src/soc/intel/apollolake/acpi/northbridge.asl b/src/soc/intel/apollolake/acpi/northbridge.asl index 929bdd1..1b59097 100644 --- a/src/soc/intel/apollolake/acpi/northbridge.asl +++ b/src/soc/intel/apollolake/acpi/northbridge.asl @@ -83,7 +83,7 @@ And(\_SB.PCI0.MCHC.MCNF, 0xF0000000, PMAX) /* Calculate PCI MMIO Length */ - Add(Subtract(PMAX, PMIN), 1, PLEN) + PLEN = Subtract(PMAX, PMIN) + 1 /* Find GFX resource area in GCRS */ CreateDwordField(MCRS, STOM._MIN, GMIN) @@ -96,7 +96,7 @@ /* Read TOLUD */ And(\_SB.PCI0.MCHC.TLUD, 0xFFF00000, GMAX) Decrement(GMAX) - Add(Subtract(GMAX, GMIN), 1, GLEN) + GLEN = Subtract(GMAX, GMIN) + 1 /* Patch PM02 range based on Memory Size */ If (LEqual (A4GS, 0)) { 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d6039affd9688a2e795d69f699d5baf688ba2e4 Gerrit-Change-Number: 60494 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60493 ) Change subject: ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... ec/starlabs/merlin/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I4f8b71c90f0c56fdb29c4d2e9a2a737f704f3265 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60493 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/starlabs/merlin/acpi/ec.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl index 905916c..2c2b8d7 100644 --- a/src/ec/starlabs/merlin/acpi/ec.asl +++ b/src/ec/starlabs/merlin/acpi/ec.asl @@ -126,7 +126,7 @@ } Sleep (1) Arg1 = Arg0 - Add (Local1, 1, Local1) + Local1 += 1 If (Local1 == 0x03) { Break } -- To view, visit https://review.coreboot.org/c/coreboot/+/60493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f8b71c90f0c56fdb29c4d2e9a2a737f704f3265 Gerrit-Change-Number: 60493 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60492 ) Change subject: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: Ibbc0831e688b62d7ed0dec5e4b7224688ed0ae6d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60492 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/lenovo/h8/acpi/thermal.asl M src/ec/lenovo/h8/acpi/thinkpad.asl 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index 2215d5f..26b5df0 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -12,7 +12,7 @@ Method(C2K, 1, NotSerialized) { Multiply(Arg0, 10, Local0) - Add (Local0, 2732, Local0) + Local0 += 2732 if (LLessEqual(Local0, 2732)) { Return (3000) } diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index eca0d44..fa073d8 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -37,13 +37,13 @@ Store (BTN, Local0) If (LNotEqual (Local0, Zero)) { Store (Zero, BTN) - Add (Local0, 0x1000, Local0) + Local0 += 0x1000 Return (Local0) } Store (BTAB, Local0) If (LNotEqual (Local0, Zero)) { Store (Zero, BTAB) - Add (Local0, 0x5000, Local0) + Local0 += 0x5000 Return (Local0) } Return (Zero) -- To view, visit https://review.coreboot.org/c/coreboot/+/60492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbc0831e688b62d7ed0dec5e4b7224688ed0ae6d Gerrit-Change-Number: 60492 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Alexander Couzens. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60492 ) Change subject: ec/lenovo/h8/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Why don't you convert the files to ASL 2.0 in one go? […] I think it's harder to review and this way I can push little patches whenever I have time. -- To view, visit https://review.coreboot.org/c/coreboot/+/60492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbc0831e688b62d7ed0dec5e4b7224688ed0ae6d Gerrit-Change-Number: 60492 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 31 Dec 2021 08:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60491 ) Change subject: mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/kahlee/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: If80d97abc831e17bc8bc6e379bbae26e65db23f1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60491 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl index 732ff87..2930def 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -24,7 +24,7 @@ Multiply (Arg0, 10, Local0) /* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If80d97abc831e17bc8bc6e379bbae26e65db23f1 Gerrit-Change-Number: 60491 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/cyan/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60490 ) Change subject: mb/google/cyan/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/cyan/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I771c855e8885238c7fc3b0a7a6e9c2002274c0f2 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60490 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl index 2cfc256..8852345 100644 --- a/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/cyan/variants/terra/include/variant/acpi/dptf.asl @@ -206,7 +206,7 @@ Multiply (Arg0, 10, Local0) /* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60490 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I771c855e8885238c7fc3b0a7a6e9c2002274c0f2 Gerrit-Change-Number: 60490 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60489 ) Change subject: mb/google/jecht/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... mb/google/jecht/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: Ie7fa132623c7834e3d2f1acda032928579819a84 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60489 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index 1d64669..e156306 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -27,7 +27,7 @@ Multiply (Arg0, 10, Local0) // Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index 1d64669..e156306 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -27,7 +27,7 @@ Multiply (Arg0, 10, Local0) // Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index 1d64669..e156306 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -27,7 +27,7 @@ Multiply (Arg0, 10, Local0) // Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index adde850..050e2d5 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -42,7 +42,7 @@ Multiply (Arg0, 10, Local0) // Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie7fa132623c7834e3d2f1acda032928579819a84 Gerrit-Change-Number: 60489 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/mediatek: Enable PCIe support for mt8195
by Jianjun Wang (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56793 ) Change subject: soc/mediatek: Enable PCIe support for mt8195 ...................................................................... Patch Set 10: (1 comment) File src/soc/mediatek/mt8195/Kconfig: https://review.coreboot.org/c/coreboot/+/56793/comment/14ab1f8f_b3e38a55 PS8, Line 13: select PCIE_MEDIATEK > Do we want to enable this for all mt8195 devices? Thanks for reminder, I think we should enable this for specific board, it will affect the boot time and cause 200ms delay when there is no PCIe device connected. -- To view, visit https://review.coreboot.org/c/coreboot/+/56793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I314572955f1021abe9f2f0f4635670135ed08fff Gerrit-Change-Number: 56793 Gerrit-PatchSet: 10 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 31 Dec 2021 08:51:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021