coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/intel/skylake/acpi: Replace Add(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60502 ) Change subject: soc/intel/skylake/acpi: Replace Add(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/skylake/acpi: Replace Add(a,b) with ASL 2.0 syntax Replace `Add (a, b)` with `a + b`. Change-Id: Id35c24663f529238fe17721b99ad8e93a4f5433f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60502 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/skylake/acpi/xhci.asl 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/skylake/acpi/xhci.asl b/src/soc/intel/skylake/acpi/xhci.asl index 196af97..da5c10b 100644 --- a/src/soc/intel/skylake/acpi/xhci.asl +++ b/src/soc/intel/skylake/acpi/xhci.asl @@ -17,8 +17,7 @@ Local0 = Arg1 + ((Arg0 - 1) * 0x10) /* Map ((XMEM << 16) + Local0 in PSCR */ - OperationRegion (PSCR, SystemMemory, - Add (ShiftLeft (Arg2, 16), Local0), 0x10) + OperationRegion (PSCR, SystemMemory, ShiftLeft (Arg2, 16) + Local0, 0x10) Field (PSCR, DWordAcc, NoLock, Preserve) { PSCT, 32, @@ -101,8 +100,7 @@ D3HE, 1, /* D3_hot_en */ } - OperationRegion (XREG, SystemMemory, - Add (ShiftLeft (XMEM, 16), 0x8000), 0x200) + OperationRegion (XREG, SystemMemory, ShiftLeft (XMEM, 16) + 0x8000, 0x200) Field (XREG, DWordAcc, Lock, Preserve) { Offset (0x1c4), /* USB2PMCTRL */ 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id35c24663f529238fe17721b99ad8e93a4f5433f Gerrit-Change-Number: 60502 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/smsc/mec1308/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60501 ) Change subject: ec/smsc/mec1308/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/smsc/mec1308/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Ia736b0080848e029eaeae094f1d2cc12aace3730 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60501 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/smsc/mec1308/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/smsc/mec1308/acpi/battery.asl b/src/ec/smsc/mec1308/acpi/battery.asl index bbbcfe2..603b1d4 100644 --- a/src/ec/smsc/mec1308/acpi/battery.asl +++ b/src/ec/smsc/mec1308/acpi/battery.asl @@ -157,7 +157,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Subtract (Local2, Local3)) && + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) { Store (Local2, Local1) 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60501 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia736b0080848e029eaeae094f1d2cc12aace3730 Gerrit-Change-Number: 60501 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/quanta/it8518/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60500 ) Change subject: ec/quanta/it8518/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/quanta/it8518/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Ibdc3faa5c888b1bd0e5234ed8185dcf29b2f1d4d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60500 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/quanta/it8518/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/quanta/it8518/acpi/battery.asl b/src/ec/quanta/it8518/acpi/battery.asl index 9294733..0015021 100644 --- a/src/ec/quanta/it8518/acpi/battery.asl +++ b/src/ec/quanta/it8518/acpi/battery.asl @@ -317,7 +317,7 @@ // See if within ~3% of full ShiftRight (Local2, 5, Local3) - If (LGreater (Local1, Subtract (Local2, Local3)) && LLess (Local1, Add (Local2, Local3))) + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) { Store (Local2, Local1) } 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60500 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdc3faa5c888b1bd0e5234ed8185dcf29b2f1d4d Gerrit-Change-Number: 60500 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/lenovo/h8/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60499 ) Change subject: ec/lenovo/h8/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/lenovo/h8/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Id8fec71cc174008f48fc0a80c36942e6941982ac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60499 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/lenovo/h8/acpi/thinkpad.asl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl index fa073d8..48e76dc 100644 --- a/src/ec/lenovo/h8/acpi/thinkpad.asl +++ b/src/ec/lenovo/h8/acpi/thinkpad.asl @@ -51,7 +51,7 @@ /* Report event */ Method (RHK, 1, NotSerialized) { - ShiftLeft (One, Subtract (Arg0, 1), Local0) + ShiftLeft (One, Arg0 - 1, Local0) If (And (EMSK, Local0)) { Store (Arg0, BTN) Notify (HKEY, 0x80) @@ -60,7 +60,7 @@ /* Report tablet */ Method (RTAB, 1, NotSerialized) { - ShiftLeft (One, Subtract (Arg0, 1), Local0) + ShiftLeft (One, Arg0 - 1, Local0) If (And (ETAB, Local0)) { Store (Arg0, BTAB) Notify (HKEY, 0x80) @@ -84,7 +84,7 @@ /* Enable/disable event. */ Method (MHKM, 2, NotSerialized) { If (LLessEqual (Arg0, 0x20)) { - ShiftLeft (One, Subtract (Arg0, 1), Local0) + ShiftLeft (One, Arg0 - 1, Local0) If (Arg1) { Or (DHKN, Local0, DHKN) 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8fec71cc174008f48fc0a80c36942e6941982ac Gerrit-Change-Number: 60499 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: ec/google/chromeec/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60498 ) Change subject: ec/google/chromeec/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... ec/google/chromeec/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: Ib47fdb28c2047e001902345ad2f1b25fe5d8a152 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60498 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/ec/google/chromeec/acpi/battery.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/ec/google/chromeec/acpi/battery.asl b/src/ec/google/chromeec/acpi/battery.asl index 7569728..0672885 100644 --- a/src/ec/google/chromeec/acpi/battery.asl +++ b/src/ec/google/chromeec/acpi/battery.asl @@ -210,7 +210,7 @@ // See if within ~6% of full ShiftRight (Local2, 4, Local3) - If (LGreater (Local1, Subtract (Local2, Local3)) && LLess (Local1, Add (Local2, Local3))) + If (LGreater (Local1, Local2 - Local3) && LLess (Local1, Add (Local2, Local3))) { Store (Local2, Local1) } 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib47fdb28c2047e001902345ad2f1b25fe5d8a152 Gerrit-Change-Number: 60498 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60497 ) Change subject: drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... drivers/intel/gma/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60497 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/drivers/intel/gma/acpi/common.asl M src/drivers/intel/gma/acpi/configure_brightness_levels.asl 2 files changed, 4 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/drivers/intel/gma/acpi/common.asl b/src/drivers/intel/gma/acpi/common.asl index 254a66d..02169ae 100644 --- a/src/drivers/intel/gma/acpi/common.asl +++ b/src/drivers/intel/gma/acpi/common.asl @@ -9,7 +9,7 @@ Store (Match (BRIG, MEQ, Arg0, MTR, Zero, 2), Local0) If (LEqual (Local0, Ones)) { - Return (Subtract(SizeOf(BRIG), One)) + Return (SizeOf(BRIG) - 1) } Return (Local0) } @@ -56,7 +56,7 @@ Notify (LCD0, 0x86) } Else { Store (BRID (XBQC ()), Local0) - If (LNotEqual (Local0, Subtract(SizeOf(BRIG), One))) + If (LNotEqual (Local0, SizeOf(BRIG) - 1)) { Increment (Local0) } diff --git a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl index 92ae766..3581f4d 100644 --- a/src/drivers/intel/gma/acpi/configure_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/configure_brightness_levels.asl @@ -121,15 +121,13 @@ /* Local1: loop index (selectable values start at 2 in BRIG) */ Store (2, Local1) - While (LLess (Local1, Subtract (SizeOf (BRIG), 1))) { + While (LLess (Local1, SizeOf (BRIG) - 1)) { /* Local[23]: adjacent values in BRIG */ Store (DeRefOf (BRIG[Local1]), Local2) Store (DeRefOf (BRIG[Add (Local1, 1)]), Local3) If (LLess (Local0, Local3)) { - If (LOr (LLess (Local0, Local2), - LLess (Subtract (Local0, Local2), - Subtract (Local3, Local0)))) { + If (LOr (LLess (Local0, Local2), LLess (Local0 - Local2, Local3 - Local0))) { Return (Local2) } Else { Return (Local3) 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f6ffd6bbf6a37e041879e50fe41ce3cc856371f Gerrit-Change-Number: 60497 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/apollolake/acpi: Replace Subtract(a,b) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60496 ) Change subject: soc/intel/apollolake/acpi: Replace Subtract(a,b) with ASL 2.0 syntax ...................................................................... soc/intel/apollolake/acpi: Replace Subtract(a,b) with ASL 2.0 syntax Replace `Subtract (a, b)` with `a - b`. Change-Id: I3b0ee96b5a1e9bf242efc14a24f745fd8ba0cd97 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60496 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/soc/intel/apollolake/acpi/northbridge.asl 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/soc/intel/apollolake/acpi/northbridge.asl b/src/soc/intel/apollolake/acpi/northbridge.asl index 1b59097..4f2acbb 100644 --- a/src/soc/intel/apollolake/acpi/northbridge.asl +++ b/src/soc/intel/apollolake/acpi/northbridge.asl @@ -83,7 +83,7 @@ And(\_SB.PCI0.MCHC.MCNF, 0xF0000000, PMAX) /* Calculate PCI MMIO Length */ - PLEN = Subtract(PMAX, PMIN) + 1 + PLEN = PMAX - PMIN + 1 /* Find GFX resource area in GCRS */ CreateDwordField(MCRS, STOM._MIN, GMIN) @@ -96,7 +96,7 @@ /* Read TOLUD */ And(\_SB.PCI0.MCHC.TLUD, 0xFFF00000, GMAX) Decrement(GMAX) - GLEN = Subtract(GMAX, GMIN) + 1 + GLEN = GMAX - GMIN + 1 /* Patch PM02 range based on Memory Size */ If (LEqual (A4GS, 0)) { 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b0ee96b5a1e9bf242efc14a24f745fd8ba0cd97 Gerrit-Change-Number: 60496 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/mediatek: Enable PCIe support for mt8195
by Jianjun Wang (Code Review) 31 Dec '21

31 Dec '21

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56793 to look at the new patch set (#11). Change subject: soc/mediatek: Enable PCIe support for mt8195 ...................................................................... soc/mediatek: Enable PCIe support for mt8195 Enable PCIe support for mt8195. TEST=Build pass and boot up to kernel successfully via SSD on Cherry board, here is the SSD information in boot log: == NVME IDENTIFY CONTROLLER DATA == PCI VID : 0x1987 PCI SSVID : 0x1987 SN : 28F40713077B0012602 MN : Phison ESE1A043-X28 RAB : 0x1 AERL : 0x3 SQES : 0x66 CQES : 0x44 NN : 0x1 Identified NVMe model Phison ESE1A043-X28 BUG=b:178565024 Signed-off-by: Jianjun Wang <jianjun.wang(a)mediatek.com> Change-Id: I314572955f1021abe9f2f0f4635670135ed08fff --- M src/soc/mediatek/mt8195/Makefile.inc M src/soc/mediatek/mt8195/soc.c 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/56793/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/56793 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I314572955f1021abe9f2f0f4635670135ed08fff Gerrit-Change-Number: 56793 Gerrit-PatchSet: 11 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel/i82801ix/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60514 ) Change subject: sb/intel/i82801ix/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... sb/intel/i82801ix/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I09a37ff47002640c7bbc151028b4d4576f9fbfac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60514 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/southbridge/intel/i82801ix/acpi/lpc.asl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/southbridge/intel/i82801ix/acpi/lpc.asl b/src/southbridge/intel/i82801ix/acpi/lpc.asl index f90386d..b97b010 100644 --- a/src/southbridge/intel/i82801ix/acpi/lpc.asl +++ b/src/southbridge/intel/i82801ix/acpi/lpc.asl @@ -73,15 +73,15 @@ If (HPTE) { CreateDWordField(BUF0, \_SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 } If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 } If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60514 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09a37ff47002640c7bbc151028b4d4576f9fbfac Gerrit-Change-Number: 60514 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: sb/intel/i82801jx/acpi: Replace Add(a,b,c) with ASL 2.0 syntax
by Felix Singer (Code Review) 31 Dec '21

31 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60513 ) Change subject: sb/intel/i82801jx/acpi: Replace Add(a,b,c) with ASL 2.0 syntax ...................................................................... sb/intel/i82801jx/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`. Change-Id: I738a521a12363e0b6123e3d4e22721fb459925d1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60513 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/southbridge/intel/i82801jx/acpi/lpc.asl 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/southbridge/intel/i82801jx/acpi/lpc.asl b/src/southbridge/intel/i82801jx/acpi/lpc.asl index f90386d..b97b010 100644 --- a/src/southbridge/intel/i82801jx/acpi/lpc.asl +++ b/src/southbridge/intel/i82801jx/acpi/lpc.asl @@ -73,15 +73,15 @@ If (HPTE) { CreateDWordField(BUF0, \_SB.PCI0.LPCB.HPET.FED0._BAS, HPT0) If (Lequal(HPAS, 1)) { - Add(CONFIG_HPET_ADDRESS, 0x1000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x1000 } If (Lequal(HPAS, 2)) { - Add(CONFIG_HPET_ADDRESS, 0x2000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x2000 } If (Lequal(HPAS, 3)) { - Add(CONFIG_HPET_ADDRESS, 0x3000, HPT0) + HPT0 = CONFIG_HPET_ADDRESS + 0x3000 } } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I738a521a12363e0b6123e3d4e22721fb459925d1 Gerrit-Change-Number: 60513 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021