Attention is currently required from: Felix Singer, Michael Niewöhner, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60541 )
Change subject: vendorcode/intel/fsp/elkhartlake: Drop unnecessary headers
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60541/comment/968fe660_1ac7f5a8
PS1, Line 9: Elkhartlake
Elkhart Lake [1]
[1]: https://www.intel.com/content/www/us/en/products/platforms/details/elkhart-…https://review.coreboot.org/c/coreboot/+/60541/comment/322fe31b_5e46d1e8
PS1, Line 9: commit 79fcadb3c46
commit 79fcadb3c46 (soc/intel/elkhartlake: Use FSP from FSP repo by default)
--
To view, visit https://review.coreboot.org/c/coreboot/+/60541
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d6a4d4614ae21d5b8e77eceb85baa13e491c2ae
Gerrit-Change-Number: 60541
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 31 Dec 2021 09:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jianjun Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56794 )
Change subject: libpayload/pci: Add PCIe interfaces for MediaTek platform
......................................................................
Patch Set 3:
(1 comment)
File payloads/libpayload/include/pci.h:
https://review.coreboot.org/c/coreboot/+/56794/comment/30039908_28e5aa66
PS3, Line 116: void pci_update_hw_base(uintptr_t base);
Please extend the commit message, why this is useful to have, or add a comment here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56794
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ea7d111fed6b816fa2352fe93c268116519a577
Gerrit-Change-Number: 56794
Gerrit-PatchSet: 3
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 09:47:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Hung-Te Lin, Furquan Shaikh, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56791 )
Change subject: soc/mediatek: Add PCIe support
......................................................................
Patch Set 9:
(4 comments)
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/56791/comment/b960970e_72c1a039
PS9, Line 45: PCIE_MEDIATEK_GEN3
Can this be made a generic option/name? Should the config `PCI` in `src/device/Kconfig` be made user configurable?
https://review.coreboot.org/c/coreboot/+/56791/comment/7c52cbc0_5a2e6736
PS9, Line 45: config PCIE_MEDIATEK_GEN3
Is this used already in this change-set?
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/56791/comment/55b98f5f_45dab26a
PS6, Line 174: static int mtk_pcie_dev_assign_resource(struct device *dev,
> Paul, does the explanation above sound reasonable to you?
Yes, thank you.
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/56791/comment/2ec5c2ad_cc242e48
PS9, Line 161: printk(BIOS_INFO, "%s: PCIe link up success\n", __func__);
Can you print out how long it actually took (how many retries)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0
Gerrit-Change-Number: 56791
Gerrit-PatchSet: 9
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 09:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, David Wu, Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 )
Change subject: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60377/comment/b7a60085_c6793b1c
PS4, Line 7: mb/google/brya: Make more brya variants to choose eNEM for CAR
> Suggestion: […]
Ack
https://review.coreboot.org/c/coreboot/+/60377/comment/6de8a84a_5268aaba
PS4, Line 8:
> Please explain why USE_ADL_ENEM should be default.
Ack
https://review.coreboot.org/c/coreboot/+/60377/comment/53fc79c3_efc41ee0
PS4, Line 9: Brask and Gimble to drop INTEL_CAR_NEM Kconfig select and choose eNEM.
> Please explain that further. I can not see you are dropping anything here.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/60377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f
Gerrit-Change-Number: 60377
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 09:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Hello Felix Singer, build bot (Jenkins), David Wu, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60377
to look at the new patch set (#6).
Change subject: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
......................................................................
mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
More Brya variants like Brask and Gimble have migrated to use Alder Lake
QS SoC which enables eNEM feature by default hence, selects eNEM for CAR
by default for these variants.
BUG=b:168820083
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: Ie5734606e58410545a5f5421837080680664707f
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/60377/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/60377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f
Gerrit-Change-Number: 60377
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Hello Felix Singer, build bot (Jenkins), David Wu, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60377
to look at the new patch set (#5).
Change subject: mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
......................................................................
mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
More Brya variants like Brask and Gimble have migrated to use Alder Lake
QS SoC which enables eNEM feature by default hence, selects eNEM for CAR by
default for these variants.
BUG=b:168820083
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Change-Id: Ie5734606e58410545a5f5421837080680664707f
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/60377/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/60377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f
Gerrit-Change-Number: 60377
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 )
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe
......................................................................
Patch Set 10:
(2 comments)
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/822cf215_3f70cc90
PS10, Line 15: /* MMIO range(64MB): 0x20000000 ~ 0x24000000 */
Please add a space before (.
https://review.coreboot.org/c/coreboot/+/56792/comment/d3236ad0_067c92bb
PS10, Line 21: .size = 0x1000000,
Can the size be specified with macros KiB or MiB in `src/commonlib/bsd/include/commonlib/bsd/helpers.h`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976
Gerrit-Change-Number: 56792
Gerrit-PatchSet: 10
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 09:35:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, EricR Lai.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 )
Change subject: mb/google/brya: Make more brya variants to choose eNEM for CAR
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60377/comment/a9c6ce86_8536461e
PS4, Line 7: mb/google/brya: Make more brya variants to choose eNEM for CAR
Suggestion:
mb/google/brya/{brask,gimble}: Use eNEM for CAR by default
https://review.coreboot.org/c/coreboot/+/60377/comment/cd181d96_d243e47b
PS4, Line 8:
Please explain why USE_ADL_ENEM should be default.
https://review.coreboot.org/c/coreboot/+/60377/comment/d0139cdb_394dfca1
PS4, Line 9: Brask and Gimble to drop INTEL_CAR_NEM Kconfig select and choose eNEM.
Please explain that further. I can not see you are dropping anything here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f
Gerrit-Change-Number: 60377
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Wu <david_wu(a)quantatw.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 31 Dec 2021 09:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment