Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#7).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Fix the inconsistence of the target path of U-Boot payload
between KConfig and Makefile.inc.
2. Perform full clone in order to get tags.
3. Move stable commit id of U-Boot payload from Makefile to
KConfig, and let prompt consistent with it.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 7
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#6).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Fix the inconsistence of the target path of U-Boot payload
between Kconfig and Makefile.inc.
2. Perform full clone in order to get tags.
3. Move stable commit id of U-Boot payload from Makefile to
Kconfig, and let prompt consistent with it.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 6
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#5).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Fix the inconsistence of the target path of U-Boot payload
between Kconfig and Makefile.inc.
2. Perform full clone in order to get tags.
3. Make Kconfig prompt for revision consistent with the revision
in Makefile.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60028 )
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60028/comment/762210cb_1de52848
PS2, Line 9: Target of U-Boot payload is inconsistent between Kconfig and
: Makefile.inc.
:
: Perform full clone in order to get tags.
:
: Make Kconfig prompt for revision consistent with the revision
: in Makefile.
> I’d do: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 10:02:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Bill XIE, Martin Roth, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#4).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Target of U-Boot payload is inconsistent between Kconfig and
Makefile.inc.
2. Perform full clone in order to get tags.
3. Make Kconfig prompt for revision consistent with the revision
in Makefile.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kevin Chiu, Paul Menzel, Robert Chen, Wisley Chen, Shon Wang.
Robert Chen has uploaded a new patch set (#15) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59304 )
Change subject: mb/google/brya/var/vell: update overridetree
......................................................................
mb/google/brya/var/vell: update overridetree
Init basic override devicetree based on schematics
BUG=b:205908918
TEST=emerge-brya coreboot
Change-Id: Ibaa910eb1c5584197907963781258035c668298e
Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
---
M src/mainboard/google/brya/Kconfig.name
M src/mainboard/google/brya/variants/vell/overridetree.cb
2 files changed, 367 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59304/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/59304
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e
Gerrit-Change-Number: 59304
Gerrit-PatchSet: 15
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bill XIE, Martin Roth, Stefan Reinauer, Simon Glass.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60028 )
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60028/comment/15ecb9bd_94779c85
PS2, Line 9: Target of U-Boot payload is inconsistent between Kconfig and
: Makefile.inc.
:
: Perform full clone in order to get tags.
:
: Make Kconfig prompt for revision consistent with the revision
: in Makefile.
> Into which form of the list do you want me to format it?
I’d do:
1. Target …
2. Perform …
3. Make …
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 3
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 09:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59918 )
Change subject: soc/amd/cezanne: FSP: Add UPD entry for eDP tuning
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Also, why does the AGESA/FSP binary blob do the eDP tuning? Why can’t it be done properly in coreboo […]
Sorry, eDP is part of graphics initialization, which is currently not FLOSS on AMD hardware. Please document it better in the commit message, what part of FSP/AGESA does the eDP tuning. (GOP?)
--
To view, visit https://review.coreboot.org/c/coreboot/+/59918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b85faac4f2fa1fb2c14bb85b615346d4379baac
Gerrit-Change-Number: 59918
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 13 Dec 2021 09:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Ravindra, Nick Vaccaro, Sridhar Siricilla, Patrick Rudolph.
Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, Sridhar Siricilla, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60020
to look at the new patch set (#3).
Change subject: soc/intel/common/cse: Update help text for CSE_OEMP_FILE
......................................................................
soc/intel/common/cse: Update help text for CSE_OEMP_FILE
The OEM may create and sign an Audio component to extend the Audio
capability provided by Intel. The manifest is then signed, and the
signature and public key are entered into the header of the manifest
to create the final signed component binary. This creates a secure
verification mechanism where firmware verifies that the OEM Key
Manifest was signed with a key owned by a trusted owner. Once OEM KM
is authenticated, each public key hash stored within the OEM KM is
able to authenticate the corresponding FW binary.
Link to the Document:
https://www.intel.com/content/www/us/en/secure/design/confidential/software…
ADL_Signing_and_Manifesting_User_Guide.pdf
BUG=b:207820413
TEST:none
Signed-off-by: ravindr1 <ravindra(a)intel.com>
Change-Id: Id52b51ab1c910d70b7897eb31add8287b5b0166f
---
M src/soc/intel/common/block/cse/Kconfig
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/60020/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/60020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id52b51ab1c910d70b7897eb31add8287b5b0166f
Gerrit-Change-Number: 60020
Gerrit-PatchSet: 3
Gerrit-Owner: Ravindra <ravindra(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Balaji Manigandan <balaji.bmg(a)gmail.com>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-CC: Ravindra N <ravindra(a)intel.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ravindra <ravindra(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset