Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Eric Peers.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60075 )
Change subject: mb/google/guybrush/var/nipperkin: update LPDDR4X DRAM table
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60075
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99bed32025d10f62e63ace8f7f23e7cc3a740e93
Gerrit-Change-Number: 60075
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Eric Peers <epeers(a)google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Attention: Eric Peers <epeers(a)google.com>
Gerrit-Comment-Date: Mon, 13 Dec 2021 12:09:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Tim Wawrzynczak, YH Lin.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60077 )
Change subject: mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS for taniks
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60077/comment/f2e2f31c_56c29532
PS1, Line 7: Include DRIVER_TPM_I2C_BUS for taniks
> Suggestion: […]
Updated in latest patch.
Thanks for the advice!
--
To view, visit https://review.coreboot.org/c/coreboot/+/60077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
Gerrit-Change-Number: 60077
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 11:45:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Tim Wawrzynczak, YH Lin.
Hello build bot (Jenkins), Tim Wawrzynczak, YH Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60077
to look at the new patch set (#2).
Change subject: mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS for taniks
......................................................................
mb/google/brya/var/taniks: Configure DRIVER_TPM_I2C_BUS for taniks
Add I2C bus address for taniks in Kconfig
BUG=b:210390520
TEST=emerge-brya coreboot and can boot to OS.
Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
---
M src/mainboard/google/brya/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/60077/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
Gerrit-Change-Number: 60077
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Joey Peng, Tim Wawrzynczak, YH Lin.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60077 )
Change subject: mb/google/brya/var/taniks: Include DRIVER_TPM_I2C_BUS for taniks
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60077/comment/628d6ac6_ec165f01
PS1, Line 7: Include DRIVER_TPM_I2C_BUS for taniks
Suggestion:
Configure DRIVER_TPM_I2C_BUS
--
To view, visit https://review.coreboot.org/c/coreboot/+/60077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b1719c3140c13f67e7cb0e6a69257774884bd4d
Gerrit-Change-Number: 60077
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 11:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Ren Kuo, Rob Barnes, Karthik Ramasubramanian, Karthikeyan Ramasubramanian.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59975 )
Change subject: mb/google/guybrush/var/dewatt: Add Elan touchscreen
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59975/comment/d2f0fc4a_1a94c5b2
PS6, Line 9: Add Elan 6918 touchscreen for dewatt.
> Please mention the datasheet name and revision, you got the values from.
Done
https://review.coreboot.org/c/coreboot/+/59975/comment/8bd711a3_390acb81
PS6, Line 12: touchscree
> touchscreen
Done
File src/mainboard/google/guybrush/variants/dewatt/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59975/comment/9a9104ce_cdfb5156
PS2, Line 67: register "generic.stop_delay_ms" = "280"
> Long resume time is not OK. Please measure resume time impact of this touchscreen. […]
After discussing to betty.tsai(a)emc.com.tw , removed stop_delay_ms and tested with elan 6918.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59975
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a7f5891e09ffa393c93881be68641d955efdf8
Gerrit-Change-Number: 59975
Gerrit-PatchSet: 8
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 11:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#10).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Fix the inconsistence of the target path of U-Boot payload
between Kconfig and Makefile.inc.
2. Perform full clone (to the destined commit) in order to get
tags.
3. Move stable commit id of U-Boot payload from Makefile to
Kconfig, and make prompt consistent with it.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 10
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60028 )
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
Patch Set 9:
(1 comment)
File payloads/external/U-Boot/Makefile:
https://review.coreboot.org/c/coreboot/+/60028/comment/894c8fb0_126d5239
PS2, Line 28: git clone $(project_git_repo) $(project_dir)
> The value of $(STABLE_COMMIT_ID) is a tag instead of a branch, and --branch can only be used on a br […]
Sorry, it is possible to clone to a tag with -b. The tag I have tried used to be wrong.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 9
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 10:30:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org>
Comment-In-Reply-To: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#9).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Fix the inconsistence of the target path of U-Boot payload
between Kconfig and Makefile.inc.
2. Perform full clone (to the destined commit) in order to get
tags.
3. Move stable commit id of U-Boot payload from Makefile to
Kconfig, and let prompt consistent with it.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 9
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass.
Hello build bot (Jenkins), Martin Roth, Paul Menzel, Stefan Reinauer, Simon Glass,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60028
to look at the new patch set (#8).
Change subject: payloads/U-Boot: Fix various build errors
......................................................................
payloads/U-Boot: Fix various build errors
1. Fix the inconsistence of the target path of U-Boot payload
between Kconfig and Makefile.inc.
2. Perform full clone in order to get tags.
3. Move stable commit id of U-Boot payload from Makefile to
Kconfig, and let prompt consistent with it.
Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org>
---
M payloads/external/Makefile.inc
M payloads/external/U-Boot/Kconfig
M payloads/external/U-Boot/Makefile
3 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/60028/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/60028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b
Gerrit-Change-Number: 60028
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-MessageType: newpatchset