Attention is currently required from: Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59919 )
Change subject: mb/google/guybrush/var/nipperkin: Board values for eDP tuning
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59919/comment/e57ea5f8_78d3905b
PS5, Line 7: Google/Nipperkin
> mb/google/guybrush/var/nipperkin
Done
https://review.coreboot.org/c/coreboot/+/59919/comment/f6a06c60_296edaac
PS5, Line 9: These values are got from experiment.
> How exactly?
Done
https://review.coreboot.org/c/coreboot/+/59919/comment/f2c6b3b7_87c41646
PS5, Line 9: document
> That means the testing document? (Not the datasheet. […]
Done
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59919/comment/2f08af0e_544c6cb3
PS5, Line 102: 0x1F
> In coreboot it’s common to write it lowercase.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa8c594d9f5caa6b2523dac079aef89e623c56f
Gerrit-Change-Number: 59919
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Mon, 13 Dec 2021 06:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59918 )
Change subject: soc/amd/cezanne: FSP: Add UPD entry for eDP tuning
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59918/comment/fa035932_8de76209
PS4, Line 9: The document about eDP tuning is attached in issue tracker of this
: ticket.
> What document?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59918
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b85faac4f2fa1fb2c14bb85b615346d4379baac
Gerrit-Change-Number: 59918
Gerrit-PatchSet: 5
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 13 Dec 2021 06:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59990 )
Change subject: soc/mediatek/mt8186: add tracker dump
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59990/comment/2ce87449_9a77281d
PS3, Line 11: values
> could be moved to the previous line.
Done
https://review.coreboot.org/c/coreboot/+/59990/comment/bbd8e6f7_7d991718
PS3, Line 11: debug
> debugging
Done
https://review.coreboot.org/c/coreboot/+/59990/comment/bafd3dc9_e1ed3607
PS3, Line 13: issues of bus hanged
> the bug hanging issue
Done
https://review.coreboot.org/c/coreboot/+/59990/comment/6ef372dd_fdcdfbd3
PS3, Line 13: only be trigger
> will be triggered only
Done
https://review.coreboot.org/c/coreboot/+/59990/comment/10d8d969_b42ed155
PS3, Line 14: we confirm the range of registers are what we want to know.
> I'm not sure what you mean by this. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/59990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie023de2a6f7421a16b2516baa0bf0bf6fff589e2
Gerrit-Change-Number: 59990
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 13 Dec 2021 06:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60002
to look at the new patch set (#6).
Change subject: mb/google/corsola: set up open-drain ChromeOS pins
......................................................................
mb/google/corsola: set up open-drain ChromeOS pins
Set open-drain GPIOs for ChromeOS as input and high-z mode.
After applying this patch, we can measure these pins from 1.0V to
correct voltage (1.8V) to prevent wrong judgement of low/high.
Reference document:
MT8186_SoC_Pinmux_V1_1
BUG=b:209342636
TEST=measure pins voltage 1.8V on kingler board
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: Ib55a773bb63404a1b952f7e7645eb7aba6638b00
---
M src/mainboard/google/corsola/bootblock.c
M src/mainboard/google/corsola/chromeos.c
M src/mainboard/google/corsola/gpio.h
3 files changed, 46 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/60002/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/60002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib55a773bb63404a1b952f7e7645eb7aba6638b00
Gerrit-Change-Number: 60002
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59990
to look at the new patch set (#5).
Change subject: soc/mediatek/mt8186: add tracker dump
......................................................................
soc/mediatek/mt8186: add tracker dump
Tracker is a debugging tool, and MT8186 only supports AP tracker.
When bus timeout occurs, the system reboots and latches some values
which could be used for debugging.
This function will be triggered only when it encounters the bug
hanging issue.
BUG=b:202871018
TEST=range of registers are dumped as expected.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: Ie023de2a6f7421a16b2516baa0bf0bf6fff589e2
---
M src/soc/mediatek/common/tracker.c
M src/soc/mediatek/mt8186/Makefile.inc
M src/soc/mediatek/mt8186/bootblock.c
M src/soc/mediatek/mt8186/include/soc/addressmap.h
A src/soc/mediatek/mt8186/include/soc/tracker.h
5 files changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/59990/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/59990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie023de2a6f7421a16b2516baa0bf0bf6fff589e2
Gerrit-Change-Number: 59990
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Xi Chen, Paul Menzel.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59989 )
Change subject: soc/mediatek: add support for tracker version one
......................................................................
Patch Set 3: Verified+1
(1 comment)
File src/soc/mediatek/common/tracker_v2.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135409):
https://review.coreboot.org/c/coreboot/+/59989/comment/5d8ab5b9_af0fd6ce
PS3, Line 77: * bit[14] - BUS_OT_WEN_CTRL
'OT' may be misspelled - perhaps 'TO'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb146974da118b1cf5a349370bf7b2fa13f1aba8
Gerrit-Change-Number: 59989
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 13 Dec 2021 06:28:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Zheng Bao.
Hello build bot (Jenkins), Zheng Bao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59919
to look at the new patch set (#6).
Change subject: mb/google/guybrush/var/nipperkin: Board values for eDP tuning
......................................................................
mb/google/guybrush/var/nipperkin: Board values for eDP tuning
Reference test document, update tuning registers from pass experiment
setting of phy_settings.
The document about eDP tuning can be got from the issue tracker of
this ticket, at the link
https://partnerissuetracker.corp.google.com/issues/203061533#comment6
BUG=b:203061533
Change-Id: I7aa8c594d9f5caa6b2523dac079aef89e623c56f
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/59919/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/59919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7aa8c594d9f5caa6b2523dac079aef89e623c56f
Gerrit-Change-Number: 59919
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newpatchset