coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya/var/vell: update memory settings
by Robert Chen (Code Review) 13 Dec '21

13 Dec '21

Attention is currently required from: Kevin Chiu, YH Lin, Tim Wawrzynczak, Nick Vaccaro, Robert Chen, Patrick Rudolph. Robert Chen has uploaded a new patch set (#17) to the change originally created by Shon Wang. ( https://review.coreboot.org/c/coreboot/+/59334 ) Change subject: mb/google/brya/var/vell: update memory settings ...................................................................... mb/google/brya/var/vell: update memory settings DQ/DQS info from Intel_Platform_DQ_DQS_RCOMP_Info_Utility GPIO_MEN_CONFIG_0 GPP_E11 to GPP_E3 GPIO_MEN_CONFIG_3 GPP_E12 to GPP_E7 GPIO_MEM_CH_SEL_GPP_E5 GPP_E13 to GPP_E5 BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/vell/Makefile.inc A src/mainboard/google/brya/variants/vell/memory.c 2 files changed, 104 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/59334/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/59334 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0bbac5eaebc77639be6c1bc399658ac90e72fbb Gerrit-Change-Number: 59334 Gerrit-PatchSet: 17 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update gpio override
by Robert Chen (Code Review) 13 Dec '21

13 Dec '21

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Kevin Chiu, Robert Chen, Nick Vaccaro, Wisley Chen. Robert Chen has uploaded a new patch set (#21) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59305 ) Change subject: mb/google/brya/var/vell: update gpio override ...................................................................... mb/google/brya/var/vell: update gpio override Configure GPIOs according to schematics BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- A src/mainboard/google/brya/variants/vell/Makefile.inc A src/mainboard/google/brya/variants/vell/gpio.c 2 files changed, 181 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/59305/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/59305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc91866f7555c294af7eed9e5d1550e73d8059d0 Gerrit-Change-Number: 59305 Gerrit-PatchSet: 21 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree
by Robert Chen (Code Review) 13 Dec '21

13 Dec '21

Attention is currently required from: Paul Menzel, Kevin Chiu, Robert Chen, Wisley Chen, Shon Wang. Robert Chen has uploaded a new patch set (#14) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59304 ) Change subject: mb/google/brya/var/vell: update overridetree ...................................................................... mb/google/brya/var/vell: update overridetree Init basic override devicetree based on schematics BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Ibaa910eb1c5584197907963781258035c668298e Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/overridetree.cb 2 files changed, 369 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59304/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/59304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e Gerrit-Change-Number: 59304 Gerrit-PatchSet: 14 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/felwinter: Add stylus probe for garage
by EricR Lai (Code Review) 13 Dec '21

13 Dec '21

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60073 ) Change subject: mb/google/brya/var/felwinter: Add stylus probe for garage ...................................................................... mb/google/brya/var/felwinter: Add stylus probe for garage Felwinter has non-stylus sku, garage driver only attach to stylus sku. BUG=b:208937710 TEST=non-stylus doesn't register garage driver. Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I06a2c125f2b5a73f9f7c27bf1b20ff8712664809 --- M src/mainboard/google/brya/variants/felwinter/overridetree.cb 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/60073/1 diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb index dafdbfc..77f8f31 100644 --- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb +++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb @@ -4,6 +4,10 @@ option USB3_PS8815 1 option USB4_KB8001 2 end + field STYLUS 5 + option STYLUS_ABSENT 0 + option STYLUS_PRSENT 1 + end field AUDIO_AMP 7 9 option UNPROVISIONED 0 option MAX98360_ALC5682I_I2S 1 @@ -269,7 +273,9 @@ register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW" register "key.label" = ""pen_eject"" - device generic 0 on end + device generic 0 on + probe STYLUS STYLUS_PRSENT + end end end #I2C3 device ref i2c5 on -- To view, visit https://review.coreboot.org/c/coreboot/+/60073 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I06a2c125f2b5a73f9f7c27bf1b20ff8712664809 Gerrit-Change-Number: 60073 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: lib: Add __fls() (Find Last Set)
by 9elements QA (Code Review) 13 Dec '21

13 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 ) Change subject: lib: Add __fls() (Find Last Set) ...................................................................... Patch Set 7: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/84344 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/84343 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/84342 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/84341 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/84340 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/84339 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/84338 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/84337 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/59738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32 Gerrit-Change-Number: 59738 Gerrit-PatchSet: 7 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Mon, 13 Dec 2021 03:38:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree
by Robert Chen (Code Review) 13 Dec '21

13 Dec '21

Attention is currently required from: Paul Menzel, Kevin Chiu, Robert Chen, Wisley Chen, Shon Wang. Robert Chen has uploaded a new patch set (#13) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/59304 ) Change subject: mb/google/brya/var/vell: update overridetree ...................................................................... mb/google/brya/var/vell: update overridetree Init basic override devicetree based on schematics BUG=b:205908918 TEST=emerge-brya coreboot Change-Id: Ibaa910eb1c5584197907963781258035c668298e Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/variants/vell/overridetree.cb 2 files changed, 371 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/59304/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/59304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibaa910eb1c5584197907963781258035c668298e Gerrit-Change-Number: 59304 Gerrit-PatchSet: 13 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 13 Dec '21

13 Dec '21

V sujith kumar Reddy has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Passing EN_SPKR gpio descriptor from coreboot to kernel Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/drivers/amd/i2s_machine_dev/chip.h M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 3 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60072/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 2 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by build bot (Jenkins) (Code Review) 13 Dec '21

13 Dec '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Patch Set 1: (1 comment) File src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135394): https://review.coreboot.org/c/coreboot/+/60072/comment/3ecd33cd_52fa0029 PS1, Line 39: if(enspkr_gpio) space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 1 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 13 Dec 2021 03:22:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Passing EN_SPKR gpio descriptor from coreboot to kernel
by V sujith kumar Reddy (Code Review) 13 Dec '21

13 Dec '21

V sujith kumar Reddy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60072 ) Change subject: Passing EN_SPKR gpio descriptor from coreboot to kernel ...................................................................... Passing EN_SPKR gpio descriptor from coreboot to kernel Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Signed-off-by: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> --- M src/drivers/amd/i2s_machine_dev/chip.h M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb 3 files changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60072/1 diff --git a/src/drivers/amd/i2s_machine_dev/chip.h b/src/drivers/amd/i2s_machine_dev/chip.h index 0ca00a8..228e3e3 100644 --- a/src/drivers/amd/i2s_machine_dev/chip.h +++ b/src/drivers/amd/i2s_machine_dev/chip.h @@ -11,7 +11,7 @@ /* ACPI _UID */ unsigned int uid; - + struct acpi_gpio enspkr_gpio; /* * DMIC select GPIO (optional). Needs to be configured if the audio framework cannot use * all the mics and select the right channel based on the use-case. diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 7bd256d..bc45290 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -10,7 +10,8 @@ #define AMD_I2S_ACPI_DESC "I2S machine driver" static void i2s_machine_dev_fill_crs_dsd(const char *path, - const struct acpi_gpio *dmic_select_gpio) + const struct acpi_gpio *dmic_select_gpio, + const struct acpi_gpio *enspkr_gpio) { struct acpi_dp *dsd; @@ -18,6 +19,7 @@ acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); acpi_device_write_gpio(dmic_select_gpio); + acpi_device_write_gpio(enspkr_gpio); acpigen_write_resourcetemplate_footer(); dsd = acpi_dp_new_table("_DSD"); @@ -34,19 +36,23 @@ 0, /* Index = 0 (There is a single GPIO entry in _CRS). */ 0, /* Pin = 0 (There is a single pin in the GPIO resource). */ 0); /* Active low = 0 (Kernel driver does not use active polarity). */ + if(enspkr_gpio) + acpi_dp_add_gpio(dsd, "enspkr-gpio", path, 1, 0, + enspkr_gpio->active_low); acpi_dp_write(dsd); } static void i2s_machine_dev_fill_ssdt(const struct device *dev) { const char *scope = acpi_device_scope(dev); - const struct acpi_gpio *dmic_select_gpio; + const struct acpi_gpio *dmic_select_gpio, *enspkr_gpio; const struct drivers_amd_i2s_machine_dev_config *cfg; const char *path = acpi_device_path(dev); cfg = config_of(dev); dmic_select_gpio = &cfg->dmic_select_gpio; + enspkr_gpio = &cfg->enspkr_gpio; if (scope == NULL) { printk(BIOS_ERR, "%s: ERROR: ACPI I2S scope not found\n", dev_path(dev)); @@ -66,8 +72,8 @@ acpigen_write_STA(acpi_device_status(dev)); - if (dmic_select_gpio->pin_count) - i2s_machine_dev_fill_crs_dsd(path, dmic_select_gpio); + if (dmic_select_gpio->pin_count || enspkr_gpio->pin_count) + i2s_machine_dev_fill_crs_dsd(path, dmic_select_gpio, enspkr_gpio); acpigen_pop_len(); /* Device */ acpigen_pop_len(); /* Scope */ diff --git a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb index 7fb3c7e..2b1fe3b 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/guybrush/variants/baseboard/devicetree.cb @@ -325,6 +325,7 @@ device ref acp on chip drivers/amd/i2s_machine_dev register "hid" = ""AMDI1019"" + register "enspkr_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_31)" device generic 0.0 on end end end # Audio -- To view, visit https://review.coreboot.org/c/coreboot/+/60072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I784e6b58004a8a36b312b75db7739dfd6e8cd65a Gerrit-Change-Number: 60072 Gerrit-PatchSet: 1 Gerrit-Owner: V sujith kumar Reddy <vsujithkumar.reddy(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brya/var/taeko: Add define SOC_INTEL_ALDERLAKE_PCH_P in Kco...
by Joey Peng (Code Review) 13 Dec '21

13 Dec '21

Joey Peng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60022 ) Change subject: mb/google/brya/var/taeko: Add define SOC_INTEL_ALDERLAKE_PCH_P in Kconfig.name ...................................................................... Abandoned Cannot duplicate with latest codebase -- To view, visit https://review.coreboot.org/c/coreboot/+/60022 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic58f8fee87559f2d5ad107ca3c9da882e4eb2381 Gerrit-Change-Number: 60022 Gerrit-PatchSet: 4 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021