coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/fizz/Kconfig: Select board-specific options per board
by Felix Singer (Code Review) 12 Dec '21

12 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60064 ) Change subject: mb/google/fizz/Kconfig: Select board-specific options per board ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60064 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b8a9906671b327bec249f3d16cba3ba80a95669 Gerrit-Change-Number: 60064 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:17:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/fizz: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 12 Dec '21

12 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60063 ) Change subject: mb/google/fizz: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9201b5bcbf53422cefc6027a0d67fcf2201b14a4 Gerrit-Change-Number: 60063 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/fizz: Restore alphabetical order on Kconfig selects
by Felix Singer (Code Review) 12 Dec '21

12 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60062 ) Change subject: mb/google/fizz: Restore alphabetical order on Kconfig selects ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60062 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaaca82aad3c687939291c051f203b58a9c8cdb70 Gerrit-Change-Number: 60062 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:17:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados/Kconfig: Select board-specific options per board
by Felix Singer (Code Review) 12 Dec '21

12 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60061 ) Change subject: mb/google/glados/Kconfig: Select board-specific options per board ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ab37588a6b08a0cc194469fd2642b3cfefe301 Gerrit-Change-Number: 60061 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:17:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/i945/raminit.c: Set "integrated_graphics" as bool
by HAOUAS Elyes (Code Review) 12 Dec '21

12 Dec '21

Attention is currently required from: Paul Menzel, Patrick Rudolph, HAOUAS Elyes. Hello build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60056 to look at the new patch set (#2). Change subject: nb/intel/i945/raminit.c: Set "integrated_graphics" as bool ...................................................................... nb/intel/i945/raminit.c: Set "integrated_graphics" as bool "integrated_graphics" is already used as a "bool" at line #2128. So set it as "bool". Change-Id: Ic5286e691c312e8e44bbbd8e782fdfd4a13cb60f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/60056/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60056 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5286e691c312e8e44bbbd8e782fdfd4a13cb60f Gerrit-Change-Number: 60056 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/glados: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 12 Dec '21

12 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60060 ) Change subject: mb/google/glados: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifccf2b3521d84f6a678872bbccf9bf390c25ce37 Gerrit-Change-Number: 60060 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: Restore alphabetical order on Kconfig selects
by Felix Singer (Code Review) 12 Dec '21

12 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60059 ) Change subject: mb/google/glados: Restore alphabetical order on Kconfig selects ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I736234b9a960c58193fcf7bc9184c9581c6c953b Gerrit-Change-Number: 60059 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:09:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add set batteryinfo support for ec
by Tim Wawrzynczak (Code Review) 12 Dec '21

12 Dec '21

Attention is currently required from: Sumeet R Pawnikar. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59538 ) Change subject: mb/google/brya: Add set batteryinfo support for ec ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/ec.c: https://review.coreboot.org/c/coreboot/+/59538/comment/4638eb01_42f71d8b PS1, Line 29: ISL9241_BC12_MIN_VOLTAGE is this the same for all brya variants? -- To view, visit https://review.coreboot.org/c/coreboot/+/59538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic230671d95233f86afef1fc45a4b8f2aa613f7f7 Gerrit-Change-Number: 59538 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:00:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payloads/U-Boot: Fix various build errors
by Simon Glass (Code Review) 12 Dec '21

12 Dec '21

Attention is currently required from: Bill XIE, Martin Roth, Stefan Reinauer. Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60028 ) Change subject: payloads/U-Boot: Fix various build errors ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File payloads/external/U-Boot/Kconfig: https://review.coreboot.org/c/coreboot/+/60028/comment/813b217f_d05819d7 PS2, Line 12: UBOOT_STABLE Could this be used instead of STABLE_COMMIT_ID in payloads/external/U-Boot/Makefile? File payloads/external/U-Boot/Makefile: https://review.coreboot.org/c/coreboot/+/60028/comment/5c4a0304_df1ecf1c PS2, Line 28: git clone $(project_git_repo) $(project_dir) This is fine but takes a little longer We could try --branch $(STABLE_COMMIT_ID) -- To view, visit https://review.coreboot.org/c/coreboot/+/60028 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0f11c16274456a452a0422e19fab0c61d8b5d5b Gerrit-Change-Number: 60028 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 Dec 2021 17:00:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/google/chromeec: add battery participant support
by Tim Wawrzynczak (Code Review) 12 Dec '21

12 Dec '21

Attention is currently required from: Sumeet R Pawnikar. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59261 ) Change subject: ec/google/chromeec: add battery participant support ...................................................................... Patch Set 2: (1 comment) File src/ec/google/chromeec/ec_commands.h: PS2: again, this file is always just synced directly from the EC repo -- To view, visit https://review.coreboot.org/c/coreboot/+/59261 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2781ceff611877aef37141f195f21f9bdc31eb4c Gerrit-Change-Number: 59261 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Comment-Date: Sun, 12 Dec 2021 16:59:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021