Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph, Jeremy Soller, Christian Walter, Tim Wawrzynczak, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59887 )
Change subject: soc/intel/cannonlake: Hook up DPTF device to devicetree
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59887/comment/deb9f1b9_52f292a3
PS4, Line 204: device pci 04.0 on end # SA Thermal device
Well, what I said:
> However we shouldn't mix clean-ups without behavioral changes with fix-ups
> that change behavior in one commit.
This change does 4 things:
* Fix Hatch where coreboot should have seen but ignored a PCI device. Now it should configure the device, e.g. assign resources. So the state after coreboot ran might differ.
* Fix other boards where the device is not expected to show up. coreboot should never have seen the device, so the state after coreboot shouldn't differ.
* Configure FSP based on the devicetree on/off state.
* Remove the obsoleted chip.h setting.
For the latter two it definitely makes sense to do them in one commit. It's just
a refactoring.
However, the former two, especially the first, shouldn't be mixed with refactorings.
Also, the commit summary (first line) should cover all changes. Currently it
doesn't even suggest that behavior for random boards changes.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59887
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2ab7a691cb0f6941ef7c9def5fa2e6247127c15
Gerrit-Change-Number: 59887
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sun, 12 Dec 2021 11:08:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, HAOUAS Elyes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60056 )
Change subject: nb/intel/i945/raminit.c: Set "integrated_graphics" as bool
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60056/comment/8c5313d8_6e09eced
PS1, Line 8:
Why is this better?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60056
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5286e691c312e8e44bbbd8e782fdfd4a13cb60f
Gerrit-Change-Number: 60056
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 12 Dec 2021 10:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: HAOUAS Elyes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60057 )
Change subject: include/smbios.h: Update misc_slot_type and smbios_onboard_device_type
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60057
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iceccc672eaef0ad0bc0589797fa15d2a6a918918
Gerrit-Change-Number: 60057
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 12 Dec 2021 10:57:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Arthur Heymans, Patrick Rudolph, Christian Walter, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60053 )
Change subject: [RFC]soc/intel/icelake: Drop unmaintained platform
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/prodrive/hermes/devicetree.cb:
PS1:
> I think this file is not intended ^^
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf
Gerrit-Change-Number: 60053
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 11 Dec 2021 16:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter, Subrata Banik.
Hello build bot (Jenkins), Patrick Rudolph, Christian Walter, Subrata Banik, Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60053
to look at the new patch set (#2).
Change subject: [RFC]soc/intel/icelake: Drop unmaintained platform
......................................................................
[RFC]soc/intel/icelake: Drop unmaintained platform
The only user of this platform was the CRB board. From the looks of it
the code never was ready for production as only engineering sample
CPUID are supported.
Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Documentation/mainboard/index.md
D Documentation/mainboard/intel/icelake_rvp.md
D Documentation/soc/intel/icelake/iceLake_coreboot_development.md
D Documentation/soc/intel/icelake/index.md
M Documentation/soc/intel/index.md
D src/mainboard/intel/icelake_rvp/Kconfig
D src/mainboard/intel/icelake_rvp/Kconfig.name
D src/mainboard/intel/icelake_rvp/Makefile.inc
D src/mainboard/intel/icelake_rvp/board_id.c
D src/mainboard/intel/icelake_rvp/board_id.h
D src/mainboard/intel/icelake_rvp/board_info.txt
D src/mainboard/intel/icelake_rvp/bootblock.c
D src/mainboard/intel/icelake_rvp/chromeos.c
D src/mainboard/intel/icelake_rvp/chromeos.fmd
D src/mainboard/intel/icelake_rvp/dsdt.asl
D src/mainboard/intel/icelake_rvp/hda_verb.c
D src/mainboard/intel/icelake_rvp/mainboard.c
D src/mainboard/intel/icelake_rvp/romstage_fsp_params.c
D src/mainboard/intel/icelake_rvp/spd/Makefile.inc
D src/mainboard/intel/icelake_rvp/spd/empty.spd.hex
D src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.hex
D src/mainboard/intel/icelake_rvp/spd/spd.h
D src/mainboard/intel/icelake_rvp/spd/spd_util.c
D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/ec.h
D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/gpio.h
D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h
D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h
D src/mainboard/intel/icelake_rvp/variants/icl_u/Makefile.inc
D src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb
D src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c
D src/mainboard/intel/icelake_rvp/variants/icl_y/Makefile.inc
D src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb
D src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c
M src/soc/intel/common/block/cpu/mp_init.c
D src/soc/intel/icelake/Kconfig
D src/soc/intel/icelake/Makefile.inc
D src/soc/intel/icelake/acpi.c
D src/soc/intel/icelake/acpi/gpio.asl
D src/soc/intel/icelake/acpi/pch_hda.asl
D src/soc/intel/icelake/acpi/pci_irqs.asl
D src/soc/intel/icelake/acpi/pcie.asl
D src/soc/intel/icelake/acpi/scs.asl
D src/soc/intel/icelake/acpi/serialio.asl
D src/soc/intel/icelake/acpi/southbridge.asl
D src/soc/intel/icelake/acpi/xhci.asl
D src/soc/intel/icelake/bootblock/bootblock.c
D src/soc/intel/icelake/bootblock/pch.c
D src/soc/intel/icelake/bootblock/report_platform.c
D src/soc/intel/icelake/chip.c
D src/soc/intel/icelake/chip.h
D src/soc/intel/icelake/cpu.c
D src/soc/intel/icelake/elog.c
D src/soc/intel/icelake/espi.c
D src/soc/intel/icelake/finalize.c
D src/soc/intel/icelake/fsp_params.c
D src/soc/intel/icelake/gpio.c
D src/soc/intel/icelake/gspi.c
D src/soc/intel/icelake/i2c.c
D src/soc/intel/icelake/include/soc/bootblock.h
D src/soc/intel/icelake/include/soc/cpu.h
D src/soc/intel/icelake/include/soc/espi.h
D src/soc/intel/icelake/include/soc/gpe.h
D src/soc/intel/icelake/include/soc/gpio.h
D src/soc/intel/icelake/include/soc/gpio_defs.h
D src/soc/intel/icelake/include/soc/gpio_soc_defs.h
D src/soc/intel/icelake/include/soc/iomap.h
D src/soc/intel/icelake/include/soc/irq.h
D src/soc/intel/icelake/include/soc/itss.h
D src/soc/intel/icelake/include/soc/me.h
D src/soc/intel/icelake/include/soc/msr.h
D src/soc/intel/icelake/include/soc/nvs.h
D src/soc/intel/icelake/include/soc/p2sb.h
D src/soc/intel/icelake/include/soc/pch.h
D src/soc/intel/icelake/include/soc/pci_devs.h
D src/soc/intel/icelake/include/soc/pcr_ids.h
D src/soc/intel/icelake/include/soc/pm.h
D src/soc/intel/icelake/include/soc/pmc.h
D src/soc/intel/icelake/include/soc/ramstage.h
D src/soc/intel/icelake/include/soc/romstage.h
D src/soc/intel/icelake/include/soc/serialio.h
D src/soc/intel/icelake/include/soc/smbus.h
D src/soc/intel/icelake/include/soc/soc_chip.h
D src/soc/intel/icelake/include/soc/systemagent.h
D src/soc/intel/icelake/include/soc/usb.h
D src/soc/intel/icelake/lockdown.c
D src/soc/intel/icelake/me.c
D src/soc/intel/icelake/p2sb.c
D src/soc/intel/icelake/pmc.c
D src/soc/intel/icelake/pmutil.c
D src/soc/intel/icelake/reset.c
D src/soc/intel/icelake/romstage/Makefile.inc
D src/soc/intel/icelake/romstage/fsp_params.c
D src/soc/intel/icelake/romstage/romstage.c
D src/soc/intel/icelake/romstage/systemagent.c
D src/soc/intel/icelake/sd.c
D src/soc/intel/icelake/smihandler.c
D src/soc/intel/icelake/spi.c
D src/soc/intel/icelake/systemagent.c
D src/soc/intel/icelake/uart.c
99 files changed, 0 insertions(+), 8,111 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/60053/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf
Gerrit-Change-Number: 60053
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60053 )
Change subject: [RFC]soc/intel/icelake: Drop unmaintained platform
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/prodrive/hermes/devicetree.cb:
PS1:
I think this file is not intended ^^
--
To view, visit https://review.coreboot.org/c/coreboot/+/60053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf
Gerrit-Change-Number: 60053
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 11 Dec 2021 15:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Arthur Heymans, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60050 )
Change subject: soc/intel/icelake: Hook up public microcode
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
File src/soc/intel/icelake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/60050/comment/e740bdec_e8da4100
PS1, Line 51: 06-7a-01
> This is for Gemini Lake. Correct is 06-7e-05
Thanks. I looked at the CPUID inside the tree and it looks like CPUs with that CPUID won't even work as only engineering samples are hooked up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60050
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I613d72ff8f941757173e7debddbdfd4aca9b4faf
Gerrit-Change-Number: 60050
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Sat, 11 Dec 2021 15:26:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: comment