Attention is currently required from: Tim Crawford, Maxim Polyakov, Jeremy Soller, Angel Pons, Michael Niewöhner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60210 )
Change subject: mainboard: Fix comment about early GPIOs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae9353d106483f30cefa2d035d96e63e4c127261
Gerrit-Change-Number: 60210
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:16:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Rob Barnes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60139 )
Change subject: mb/google/guybrush: Enable PSP_S0I3_RESUME_VERSTAGE
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60139
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d64fe92ffc67a421be6d5e013e636332ce86dd5
Gerrit-Change-Number: 60139
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:16:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Alex James.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/vboot/+/60217 )
Change subject: vboot: Fix compilation on macOS hosts
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/vboot/+/60217/comment/e9d749a2_48e09460
PS1, Line 8:
1. What macOS version?
2. What is the error?
3. How do you fix it?
--
To view, visit https://review.coreboot.org/c/vboot/+/60217
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: vboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifca476620386260835d75e58f1e316b2d281e4af
Gerrit-Change-Number: 60217
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James <theracermaster(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Alex James <theracermaster(a)gmail.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Alex James.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60220 )
Change subject: cbfstool: Fix compilation on macOS
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60220/comment/8bbaedd6_8594ed09
PS1, Line 8:
1. What macOS version?
2. What is the error?
3. How do you fix it?
Patchset:
PS1:
Maybe the commit can be split up into smaller chunks?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5997d6d00e12f9f960550e72333ec354593501c
Gerrit-Change-Number: 60220
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James <theracermaster(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alex James <theracermaster(a)gmail.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alex James.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60219 )
Change subject: commonlib: Add endian definitions for macOS
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60219/comment/a480cd99_706ed7e8
PS1, Line 8:
Please give a short motivation? Since what macOS version is it needed, and what version did you use?
--
To view, visit https://review.coreboot.org/c/coreboot/+/60219
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44d59869a4420030f3ce26118175304c680d57a1
Gerrit-Change-Number: 60219
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James <theracermaster(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alex James <theracermaster(a)gmail.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Alex James.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60218 )
Change subject: xcompile: Support i686-elf toolchains
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60218/comment/8e76dfa8_b42efe0b
PS1, Line 11:
What Homebrew version? Please give an example toolchain string.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60218
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdf2cdd8b244822740c03935747184ebc5ca1512
Gerrit-Change-Number: 60218
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James <theracermaster(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Alex James <theracermaster(a)gmail.com>
Gerrit-Comment-Date: Sun, 19 Dec 2021 10:10:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment