coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts
by Shou-Chieh Hsu (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Dtrain Hsu, Henry Sun, Karthik Ramasubramanian. Shou-Chieh Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58412 ) Change subject: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: LGTM for adding new dram parts -- To view, visit https://review.coreboot.org/c/coreboot/+/58412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03980858f89e56320ddff3a808110a5f1dd57784 Gerrit-Change-Number: 58412 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Simon Yang (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: shkim, Henry Sun, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/dedede/variants/bugzzy/ramstage.c: https://review.coreboot.org/c/coreboot/+/60190/comment/0ddf8ac3_15e6571d PS8, Line 7: #include <drivers/intel/gma/i915_reg.h> > #include <soc/pci_devs. […] add one more line, not replace -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 8 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:51:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by Simon Yang (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: shkim, Henry Sun, SH Kim, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 8: (5 comments) File src/mainboard/google/dedede/variants/bugzzy/ramstage.c: https://review.coreboot.org/c/coreboot/+/60190/comment/732fb3fe_eb76d2f6 PS8, Line 7: #include <drivers/intel/gma/i915_reg.h> #include <soc/pci_devs.h> https://review.coreboot.org/c/coreboot/+/60190/comment/0a3a3214_2519b2d6 PS8, Line 9: #define IGD_MMIO_BASE 0xc0010000 #define IGD_MMIO_BASE(Bus, Dev, Func) (CONFIG_MMCONF_BASE_ADDRESS + (Bus << 20) + (Dev << 15) + (Func << 12)) https://review.coreboot.org/c/coreboot/+/60190/comment/0a248284_5744042f PS8, Line 27: addr32 = IGD_MMIO_BASE; addr32 = IGD_MMIO_BASE(0, SA_DEV_SLOT_IGD, 0); https://review.coreboot.org/c/coreboot/+/60190/comment/b3d6a124_2c4b1530 PS8, Line 29: addr32 = IGD_MMIO_BASE + 0x10; addr32 = IGD_MMIO_BASE(0, 2, 0) + PCI_BASE_ADDRESS_0; https://review.coreboot.org/c/coreboot/+/60190/comment/664f1b7c_909c702e PS8, Line 36: 0xc7204 PCH_PP_CONTROL -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 8 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:49:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: update overridetree for fingerprint
by Shon Wang (Code Review) 20 Dec '21

20 Dec '21

Shon Wang has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/60251 ) Change subject: mb/google/brya/var/vell: update overridetree for fingerprint ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/60251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd2f5de38df0eb89fb92ea2abe25851c0d6ec53f Gerrit-Change-Number: 60251 Gerrit-PatchSet: 2 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Enable PIXA touchpad
by Teddy Shih (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Paul Fagerburg, Karthik Ramasubramanian, Felix Held. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60246 ) Change subject: mb/google/dedede/var/beadrix: Enable PIXA touchpad ...................................................................... Patch Set 1: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b551554c69d52f0559ace4ad9c1335270dacea9 Gerrit-Change-Number: 60246 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Configure GPIO settings
by Teddy Shih (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Paul Menzel, Aseda Aboagye, Paul Fagerburg, Karthik Ramasubramanian, Felix Held. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60245 ) Change subject: mb/google/dedede/var/beadrix: Configure GPIO settings ...................................................................... Patch Set 2: Code-Review+1 (1 comment) This change is ready for review. File src/mainboard/google/dedede/variants/beadrix/gpio.c: https://review.coreboot.org/c/coreboot/+/60245/comment/95550e5e_e12a0e96 PS1, Line 6: ramstage*/ > Missing space. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53fc8088ff8ebb2790ac8cd68186cf9de908b414 Gerrit-Change-Number: 60245 Gerrit-PatchSet: 2 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:38:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Correct memory settings
by Teddy Shih (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Paul Fagerburg, Karthik Ramasubramanian, Felix Held. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60244 ) Change subject: mb/google/dedede/var/beadrix: Correct memory settings ...................................................................... Patch Set 1: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I935581fbf21be4820b03a608ea5bd60b1c000baa Gerrit-Change-Number: 60244 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:33:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add memory part and generate DRAM ID
by Teddy Shih (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Paul Fagerburg, Karthik Ramasubramanian, Felix Held. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60242 ) Change subject: mb/google/dedede/var/beadrix: Add memory part and generate DRAM ID ...................................................................... Patch Set 1: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/60242 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibff150bb4e742f32641da661cfca6594d18c52e9 Gerrit-Change-Number: 60242 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:33:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by SH Kim (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: shkim, Henry Sun, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 8: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60190/comment/66acb92f_20bf2f7f PS4, Line 19: new touch screen firmware > Which version exactly? Done https://review.coreboot.org/c/coreboot/+/60190/comment/ad47997d_c2be19c8 PS4, Line 20: > Please add the delay the current code adds. […] Done File src/mainboard/google/dedede/variants/bugzzy/ramstage.c: https://review.coreboot.org/c/coreboot/+/60190/comment/a2cc0d82_01dd0115 PS4, Line 47: udelay(20 * 1000); // delay 20ms > SH, […] The value of 20ms is from panel init in vbt -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 8 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:27:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Tidy up GPIOs
by Sean Rhodes (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Felix Singer, Andy Pont, Michael Niewöhner. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60123 ) Change subject: mb/starlabs/labtop: Tidy up GPIOs ...................................................................... Patch Set 14: (13 comments) File src/mainboard/starlabs/labtop/variants/tgl/gpio.c: https://review.coreboot.org/c/coreboot/+/60123/comment/1ffba142_abc16f8b PS2, Line 29: PAD_CFG_NF(GPD2, NATIVE, PWROK, NF1), > Disconnect Done https://review.coreboot.org/c/coreboot/+/60123/comment/4b7b0f53_cfb8be5b PS2, Line 38: PAD_CFG_GPO(GPD11, 0, PWROK) > Disconnect Done https://review.coreboot.org/c/coreboot/+/60123/comment/a3f000c2_c068e42b PS2, Line 64: PAD_CFG_GPO(GPP_B17, 0, PWROK), > Disconnect Done https://review.coreboot.org/c/coreboot/+/60123/comment/2539ed4b_1de00790 PS2, Line 65: PAD_CFG_GPO(GPP_B18, 0, DEEP), > Disconnect Done https://review.coreboot.org/c/coreboot/+/60123/comment/7487d888_301df1aa PS2, Line 73: PAD_CFG_GPO(GPP_B22, 0, DEEP), > Disconnect Done https://review.coreboot.org/c/coreboot/+/60123/comment/29eb5330_948952ec PS2, Line 114: PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), > PAD_CFG_GPI_APIC_LOW(GPP_C8, NONE, PLTRST), Done https://review.coreboot.org/c/coreboot/+/60123/comment/2513ed69_684677d6 PS2, Line 182: /* REQ 0 */ PAD_NC(GPP_D5, NONE), : /* REQ 1 */ PAD_NC(GPP_D6, NONE), : /* REQ 2 */ PAD_NC(GPP_D7, NONE), > Not used Done https://review.coreboot.org/c/coreboot/+/60123/comment/e3cbf5f1_91f0d603 PS2, Line 186: /* REQ 4 */ PAD_NC(GPP_H10, NONE), : /* REQ 5 */ PAD_NC(GPP_H11, NONE), : /* REQ 6 */ PAD_NC(GPP_F19, NONE), > Not used Done https://review.coreboot.org/c/coreboot/+/60123/comment/cffc4e8a_93a371e9 PS2, Line 346: PAD_CFG_TERM_GPO(GPP_D19, 1, UP_20K, DEEP), > Disconnect Done File src/mainboard/starlabs/labtop/variants/tgl/gpio.c: https://review.coreboot.org/c/coreboot/+/60123/comment/7981021c_254ca9c2 PS11, Line 213: : PAD_CFG_NF(GPP_T2, DN_20K, DEEP, NF2), : PAD_CFG_NF(GPP_T3, DN_20K, DEEP, NF2), : PAD_NC(GPP_U4, NONE), : PAD_NC(GPP_U5, NONE), > Where did they go? Seems they are disappeared? Please do such changes in a separate commit. Missed them, re-added now https://review.coreboot.org/c/coreboot/+/60123/comment/4dc5a8aa_b05a76b2 PS11, Line 34: /* A7 --[ GPP_A7 ]-- WLAN_PCM_CLK */ > The first two columns seems redundant. […] Those comments match up to the schematic. https://review.coreboot.org/c/coreboot/+/60123/comment/e1948278_3668ab61 PS11, Line 60: /* A20 --[ GPP_A20 ]-- Not Connected */ > If a pad is NC, then this is apparent through the PAD_NC macro. […] I'd prefer to leave the "Not Connected" comments, as that just means it says it's not connected in the schematic. https://review.coreboot.org/c/coreboot/+/60123/comment/7a4b50cb_1b6bec04 PS11, Line 385: /* GPD0 --[ GPD0 ]-- PCH_BATLOW# */ : PAD_CFG_NF(GPD0, NONE, DEEP, NF1), : /* GPD1 --[ GPD1 ]-- AC_PRESENT */ : PAD_CFG_NF(GPD1, NONE, DEEP, NF1), : /* GPD2 --[ GPD2 ]-- LAN_WAKE# */ : PAD_NC(GPD2, NONE), : /* GPD3 --[ GPD3 ]-- SIO_PWRBTN# */ : PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), : /* GPD4 --[ GPD4 ]-- SIO_SLP_S3# */ : PAD_CFG_NF(GPD4, NONE, DEEP, NF1), : /* GPD5 --[ GPD5 ]-- SIO_SLP_S4# */ : PAD_CFG_NF(GPD5, NONE, DEEP, NF1), : /* GPD6 --[ GPD6 ]-- SIO_SLP_A# */ : PAD_CFG_NF(GPD6, NONE, DEEP, NF1), : /* GPD7 --[ GPD7 ]-- PCH_TBT_PERST# */ : PAD_CFG_GPO(GPD7, 0, PLTRST), : /* GPD8 --[ GPD8 ]-- SUSCLK */ : PAD_CFG_NF(GPD8, NONE, DEEP, NF1), : /* GPD9 --[ GPD9 ]-- SIO_SLP_WLAN# */ : PAD_CFG_NF(GPD9, NONE, DEEP, NF1), : /* GPD10--[ GPD10 ]-- SIO_SLP_S5# */ : PAD_CFG_NF(GPD10, NONE, DEEP, NF1), : /* GPD11--[ GPD11 ]-- PM_LANPHY_EN */ : PAD_CFG_NF(GPD11, NONE, DEEP, NF1), > These were at the beginning before. Move them in a separate commit. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia3678274dcd52285019fb3cf8ccd22617268ce1a Gerrit-Change-Number: 60123 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 08:26:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021