coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v247...
by Nick Vaccaro (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Ronak Kanabar, Zhuohao Lee, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Ronak Kanabar, Zhuohao Lee, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60262 to look at the new patch set (#2). Change subject: Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v2471_02" ...................................................................... Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v2471_02" This reverts commit ae0ea32c52905d6bcb527b04727463bc2d1b9e09. This change should not have merged until the 2471_02 FSP change is ready. BUG=b:211481222 TEST='emerge-brya coreboot chromeos-bootimage', flash and boot brya0 to kernel. Change-Id: Iae5b0c53ace196053e1e155efd2e08f438979ba7 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/vendorcode/intel/fsp/fsp2_0/alderlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/60262/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae5b0c53ace196053e1e155efd2e08f438979ba7 Gerrit-Change-Number: 60262 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Jakub Czapiga, Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 ) Change subject: libpayload: Implement new CBFS access API ...................................................................... Patch Set 10: (3 comments) File payloads/libpayload/Kconfig: https://review.coreboot.org/c/coreboot/+/59497/comment/ce24f562_d16bb0bc PS8, Line 211: config CBFS > As you suggested in CB:60080, I moved VBOOT_LIB here. […] I mean they're still in the same menu in menuconfig (since you're including libcbfs/Kconfig right here), it just means that all the CBFS stuff would be together. File payloads/libpayload/include/cbfs_glue.h: https://review.coreboot.org/c/coreboot/+/59497/comment/4949e8c7_d86203ba PS3, Line 38: { > Thanks for explaining it. I didn't look at it that way. […] Well they are unsigned so this should work, right? Not quite sure what you mean by "before". I think those two checks should be enough to catch problems, do you see a specific issue with dev->offset that needs to be checked separately? Specifically, I think you have to assume that dev->offset and dev->size are "valid" (i.e. any offset smaller than dev->size is a legal offset), because those are just given here from elsewhere, we don't have any further way to check them. The functions generating the cbfs_dev_t have to make sure those are correct. The reason offset and size need to be checked is that they can come from (potentially malicious) metadata in the CBFS and the CBFS device implementation needs to make sure it's not possible to read over the end of the device it defines (see also the requirements of cbfs_dev_read() documented in <commonlib/bsd/cbfs_private.h>). File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/23b08105_7f8ae88f PS10, Line 17: static struct cbfs_boot_device rw; nit: Don't really see why you moved these out of the function? I mean it works this way, but it worked the other way too. (Hiding it in there makes for a bit better isolation, because cbfs_get_boot_device() only returns a const pointer.) -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 10 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 00:16:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/poppy: Drop unnecessary Kconfig options
by 9elements QA (Code Review) 21 Dec '21

21 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60189 ) Change subject: mb/google/poppy: Drop unnecessary Kconfig options ...................................................................... Patch Set 5: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/85427 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/85426 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85425 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/85424 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85423 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/85422 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/85421 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/85420 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0eb3fdc4fd7306e76d5479494e3ab80bbdb984fe Gerrit-Change-Number: 60189 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 00:13:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add commonlib/bsd include path to lpgcc
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Patrick Georgi, Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60171 ) Change subject: libpayload: Add commonlib/bsd include path to lpgcc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60171 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d1fe9e5dc3e7c1c1ba825a1bf19972722b42778 Gerrit-Change-Number: 60171 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:57:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Avoid duplicate ntohll/htonll definitions
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Avoid duplicate ntohll/htonll definitions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > bsd/sysincludes.h in commonlib already defines byteswapping functions (from endian(3)). […] Yes, please just do that, this file is obsolete (at least for those functions). -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:52:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/generic: Print error when using _CRS and PowerResource
by Karthik Ramasubramanian (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Tim Crawford, Raul Rangel. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60174 ) Change subject: drivers/i2c/generic: Print error when using _CRS and PowerResource ...................................................................... Patch Set 2: (1 comment) File src/drivers/i2c/generic/generic.c: https://review.coreboot.org/c/coreboot/+/60174/comment/5f178ec4_942ddd85 PS2, Line 74: printk(BIOS_ERR, "%s: ERROR: Exposing GPIOs in Power Resource and _CRS\n", : dev_path(dev)); I think both ELAN and Goodix Touchscreens used across multiple mainboards might hit this error. This might impact some downstream testing utilities(eg. suspend_stress_test) on firmware errors. We might want to fix the use-case before marking this as an error. -- To view, visit https://review.coreboot.org/c/coreboot/+/60174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcc42ed81fff295fb168a0b343e96b3a650b1c84 Gerrit-Change-Number: 60174 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:50:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Avoid defining _XOPEN_SOURCE on macOS
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60232 ) Change subject: cbfstool: Avoid defining _XOPEN_SOURCE on macOS ...................................................................... Patch Set 1: (1 comment) File util/cbfstool/Makefile.inc: https://review.coreboot.org/c/coreboot/+/60232/comment/ff52145d_e01fa0a5 PS1, Line 137: ifneq ($(OS_ARCH),$(filter $(OS_ARCH), Darwin FreeBSD)) This file can be included by either util/cbfstool/Makefile or the toplevel coreboot Makefile.inc, so you can't just rely on things only set in the former here. I'd suggest to just leave the shell expand where it is. -- To view, visit https://review.coreboot.org/c/coreboot/+/60232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Gerrit-Change-Number: 60232 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:48:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Remove redundant endian.h include
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60228 ) Change subject: util/cbfstool: Remove redundant endian.h include ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60228 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cb17eacd253605b75db8cf734e71ca3fe24ad6c Gerrit-Change-Number: 60228 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:46:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Enable PIXA touchpad
by Karthik Ramasubramanian (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Henry Sun, Teddy Shih, Paul Fagerburg, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60246 ) Change subject: mb/google/dedede/var/beadrix: Enable PIXA touchpad ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60246 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b551554c69d52f0559ace4ad9c1335270dacea9 Gerrit-Change-Number: 60246 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:42:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib: Add endian definitions for macOS
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel, Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60219 ) Change subject: commonlib: Add endian definitions for macOS ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > I could define these as preprocessor macros if that would be preferred. If that works, yeah, I think that would be nice just to keep the visual space taken up by this a bit smaller. (Alternatively, if this gets too big you could add a separate sysincludes_macos.h here where you put all that stuff in which you then chain-include for defined(__APPLE__).) PS2: I'm surprised that MacOS doesn't have these... I don't have a MacBook at hand right now, but I found some suggestions online that there's a <machine/endian.h> which has these. Can you try to see if that works? Would be a little easier. -- To view, visit https://review.coreboot.org/c/coreboot/+/60219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44d59869a4420030f3ce26118175304c680d57a1 Gerrit-Change-Number: 60219 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021