coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: commonlib: Add endian definitions for macOS
by Alex James (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel, Julius Werner. Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60219 ) Change subject: commonlib: Add endian definitions for macOS ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > If that works, yeah, I think that would be nice just to keep the visual space taken up by this a bit […] Thanks! I've updated the change to use macros. PS2: > I'm surprised that MacOS doesn't have these... […] As far as I know, machine/endian.h simply includes the architecture-specific header [1]. On x86/x86-64, this file defines LITTLE_ENDIAN/BIG_ENDIAN/BYTE_ORDER and includes another header (sys/_endian.h) [2]. sys/_endian.h defines ntohl and friends, but not htole32/etc [3]. I couldn't find existing definitions of these functions anywhere. [1]: https://github.com/apple-oss-distributions/xnu/blob/main/bsd/machine/endian… [2]: https://github.com/apple-oss-distributions/xnu/blob/main/bsd/i386/endian.h [3]: https://github.com/apple-oss-distributions/xnu/blob/main/bsd/sys/_endian.h -- To view, visit https://review.coreboot.org/c/coreboot/+/60219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44d59869a4420030f3ce26118175304c680d57a1 Gerrit-Change-Number: 60219 Gerrit-PatchSet: 3 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 01:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: Avoid defining _XOPEN_SOURCE on macOS
by Alex James (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Julius Werner. Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60232 ) Change subject: cbfstool: Avoid defining _XOPEN_SOURCE on macOS ...................................................................... Patch Set 2: (1 comment) File util/cbfstool/Makefile.inc: https://review.coreboot.org/c/coreboot/+/60232/comment/aa1e557c_f14cbe72 PS1, Line 137: ifneq ($(OS_ARCH),$(filter $(OS_ARCH), Darwin FreeBSD)) > This file can be included by either util/cbfstool/Makefile or the toplevel coreboot Makefile. […] Thanks! I removed the addition of $(OS_ARCH) in the Makefile and limited the changes to Makefile.inc. -- To view, visit https://review.coreboot.org/c/coreboot/+/60232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Gerrit-Change-Number: 60232 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 01:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
by Alex James (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Alex James. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60233 to look at the new patch set (#2). Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h Instead of maintaining another set of byteswapping functions in cbfstool, this change removes swab.h and replaces it with bsd/sysincludes.h from commonlib. Callers have been updated to use ntohl/ntohll instead be32toh/be64toh (respectively). Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M util/cbfstool/cbfs_image.c M util/cbfstool/cbfstool.c M util/cbfstool/common.c M util/cbfstool/common.h M util/cbfstool/ifittool.c D util/cbfstool/swab.h 6 files changed, 74 insertions(+), 142 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/60233/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cbfstool: Avoid defining _XOPEN_SOURCE on macOS
by Alex James (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Alex James. Hello build bot (Jenkins), Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60232 to look at the new patch set (#2). Change subject: cbfstool: Avoid defining _XOPEN_SOURCE on macOS ...................................................................... cbfstool: Avoid defining _XOPEN_SOURCE on macOS Similar to FreeBSD, defining _XOPEN_SOURCE on macOS restricts availability of non-standard functions, including memmem. Remove it to resolve a compilation error on macOS 10.15.7. Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M util/cbfstool/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/60232/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60232 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaee1ce7304c89f128a35a385032fce16a2772b13 Gerrit-Change-Number: 60232 Gerrit-PatchSet: 2 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: commonlib: Add endian definitions for macOS
by Alex James (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel, Alex James. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60219 to look at the new patch set (#3). Change subject: commonlib: Add endian definitions for macOS ...................................................................... commonlib: Add endian definitions for macOS macOS has never defined the usual endian(3)/byteorder(9) byte-swapping functions. This change implements these byte-swapping functions using the OSSwap functions, which provide identical functionality. This was tested on macOS 10.15.7. Change-Id: I44d59869a4420030f3ce26118175304c680d57a1 Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M src/commonlib/bsd/include/commonlib/bsd/sysincludes.h 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/60219/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44d59869a4420030f3ce26118175304c680d57a1 Gerrit-Change-Number: 60219 Gerrit-PatchSet: 3 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: turn on WLAN ASPM L1.2/L1.2
by Kevin Chiu (Code Review) 21 Dec '21

21 Dec '21

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60265 ) Change subject: mb/google/guybrush/var/nipperkin: turn on WLAN ASPM L1.2/L1.2 ...................................................................... mb/google/guybrush/var/nipperkin: turn on WLAN ASPM L1.2/L1.2 BUG=b:198258604 BRANCH=guybrush TEST=emerge-guybrush coreboot Change-Id: Ie1f295eaa57af7c2942e1807b3a0c4dcd89cd696 Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> --- M src/mainboard/google/guybrush/variants/nipperkin/variant.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/60265/1 diff --git a/src/mainboard/google/guybrush/variants/nipperkin/variant.c b/src/mainboard/google/guybrush/variants/nipperkin/variant.c index c53d691..658632b 100644 --- a/src/mainboard/google/guybrush/variants/nipperkin/variant.c +++ b/src/mainboard/google/guybrush/variants/nipperkin/variant.c @@ -7,6 +7,6 @@ void variant_update_dxio_descriptors(fsp_dxio_descriptor *dxio_descriptors) { - dxio_descriptors[WLAN].link_aspm_L1_1 = false; - dxio_descriptors[WLAN].link_aspm_L1_2 = false; + dxio_descriptors[WLAN].link_aspm_L1_1 = true; + dxio_descriptors[WLAN].link_aspm_L1_2 = true; } -- To view, visit https://review.coreboot.org/c/coreboot/+/60265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1f295eaa57af7c2942e1807b3a0c4dcd89cd696 Gerrit-Change-Number: 60265 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/intel/adlrvp_n: Add support for ADL-N LP5 RVP
by Kangheui Won (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Anilkumar N, Maulik V Vaghela, Tim Wawrzynczak, Reka Norman, Krishna P Bhat D, Usha P. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60193 ) Change subject: mb/intel/adlrvp_n: Add support for ADL-N LP5 RVP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2f53e65f75e23793d8c85ee924827446fd9fea7 Gerrit-Change-Number: 60193 Gerrit-PatchSet: 2 Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anilkumar N <anilkumar.n(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 00:41:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jsl: Add CdClock config
by Simon Yang (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Jamie Chen, Henry Sun, Paul Menzel, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian. Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60009 ) Change subject: soc/intel/jsl: Add CdClock config ...................................................................... Patch Set 14: (1 comment) File src/mainboard/google/dedede/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/60009/comment/7547d2a5_3d3bd667 PS14, Line 209: register "CdClock" = "0xff" > Is this the default config in FSP? Are you planning to upload a follow-up change for Magolor? => Is this the default config in FSP? Yes, 0xff is the default value of setting CdClock. => Are you planning to upload a follow-up change for Magolor? No, I will leave it for ODM to adjust it. -- To view, visit https://review.coreboot.org/c/coreboot/+/60009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97 Gerrit-Change-Number: 60009 Gerrit-PatchSet: 14 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kane Chen <kane.chen(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 00:38:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v247...
by Nick Vaccaro (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Ronak Kanabar, Zhuohao Lee, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Ronak Kanabar, Zhuohao Lee, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60262 to look at the new patch set (#3). Change subject: Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v2471_02" ...................................................................... Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v2471_02" This reverts commit ae0ea32c52905d6bcb527b04727463bc2d1b9e09. This change should not have merged until the 2471_02 FSP change is ready for merge. BUG=b:211481222 TEST='emerge-brya coreboot chromeos-bootimage', flash and boot brya0 to kernel. Change-Id: Iae5b0c53ace196053e1e155efd2e08f438979ba7 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/vendorcode/intel/fsp/fsp2_0/alderlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/alderlake/FspsUpd.h 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/60262/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae5b0c53ace196053e1e155efd2e08f438979ba7 Gerrit-Change-Number: 60262 Gerrit-PatchSet: 3 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v247...
by Nick Vaccaro (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Ronak Kanabar, Zhuohao Lee, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60262 ) Change subject: Revert "vendorcode/intel/fsp: Add Alder Lake FSP headers for FSP v2471_02" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60262/comment/db0f654d_651df03f PS1, Line 10: > Reason for revert? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae5b0c53ace196053e1e155efd2e08f438979ba7 Gerrit-Change-Number: 60262 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 00:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021