coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/intel/alderlake: Rename ADL_P_482_CORE to ADL_P_482_28W_CORE
by Curtis Chen (Code Review) 21 Dec '21

21 Dec '21

Curtis Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60267 ) Change subject: soc/intel/alderlake: Rename ADL_P_482_CORE to ADL_P_482_28W_CORE ...................................................................... soc/intel/alderlake: Rename ADL_P_482_CORE to ADL_P_482_28W_CORE Every VR config items are not the same between ADL-P 4+8+2 28 & 45W. Now the exist setting is only for ADL-P 4+8+2 28W, so we rename it. BUG=b:211365920 TEST=Build and check fsp log to confirm the settings are set properly. Signed-off-by: Curtis Chen <curtis.chen(a)intel.com> Change-Id: I863023eba5fda3b6d45059383d6030427913ca9a --- M src/soc/intel/alderlake/chip.h M src/soc/intel/alderlake/chipset.cb 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/60267/1 diff --git a/src/soc/intel/alderlake/chip.h b/src/soc/intel/alderlake/chip.h index 771fc5a..1003894 100644 --- a/src/soc/intel/alderlake/chip.h +++ b/src/soc/intel/alderlake/chip.h @@ -22,7 +22,7 @@ /* Types of different SKUs */ enum soc_intel_alderlake_power_limits { ADL_P_282_CORE, - ADL_P_482_CORE, + ADL_P_482_28W_CORE, ADL_P_682_28W_CORE, ADL_P_682_45W_CORE, ADL_M_282_12W_CORE, @@ -50,7 +50,7 @@ } cpuid_to_adl[] = { { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, ADL_P_282_CORE, TDP_15W }, { PCI_DEVICE_ID_INTEL_ADL_P_ID_6, ADL_P_242_CORE, TDP_15W }, - { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, ADL_P_482_CORE, TDP_28W }, + { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, ADL_P_482_28W_CORE, TDP_28W }, { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, ADL_P_682_28W_CORE, TDP_28W }, { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, ADL_P_682_45W_CORE, TDP_45W }, { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, ADL_P_442_45W_CORE, TDP_45W }, diff --git a/src/soc/intel/alderlake/chipset.cb b/src/soc/intel/alderlake/chipset.cb index 60c149a..bacc025 100644 --- a/src/soc/intel/alderlake/chipset.cb +++ b/src/soc/intel/alderlake/chipset.cb @@ -8,7 +8,7 @@ .tdp_pl4 = 123, }" - register "power_limits_config[ADL_P_482_CORE]" = "{ + register "power_limits_config[ADL_P_482_28W_CORE]" = "{ .tdp_pl1_override = 28, .tdp_pl2_override = 64, .tdp_pl4 = 90, -- To view, visit https://review.coreboot.org/c/coreboot/+/60267 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I863023eba5fda3b6d45059383d6030427913ca9a Gerrit-Change-Number: 60267 Gerrit-PatchSet: 1 Gerrit-Owner: Curtis Chen <curtis.chen(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Configure GPIO settings
by Teddy Shih (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Henry Sun, Paul Menzel, Aseda Aboagye, Paul Fagerburg, Karthik Ramasubramanian, Felix Held. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60245 ) Change subject: mb/google/dedede/var/beadrix: Configure GPIO settings ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/mainboard/google/dedede/variants/beadrix/gpio.c: https://review.coreboot.org/c/coreboot/+/60245/comment/03037849_9dc00796 PS2, Line 60: PAD_NC(GPP_H1, NONE), > It seems SD Card is not going to be supported. […] I have created a new CL. https://review.coreboot.org/c/coreboot/+/60266 https://review.coreboot.org/c/coreboot/+/60245/comment/128533b4_ee507536 PS2, Line 63: /* TODO; static const struct pad_config lte_disable_pads[] = { : PAD_NC(GPP_A10, NONE), : PAD_NC(GPP_D0, NONE), : PAD_NC(GPP_H17, NONE), : }; */ > Remove the TODO. Same comment for line 75 - 81. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53fc8088ff8ebb2790ac8cd68186cf9de908b414 Gerrit-Change-Number: 60245 Gerrit-PatchSet: 3 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 21 Dec 2021 02:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Remove SD controller
by Teddy Shih (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Paul Fagerburg, Karthik Ramasubramanian, Felix Held. Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60266 ) Change subject: mb/google/dedede/var/beadrix: Remove SD controller ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba6f5cbbe90d9307e5e8080d7063a1881acd7ed9 Gerrit-Change-Number: 60266 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 21 Dec 2021 02:45:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Remove SD controller
by Teddy Shih (Code Review) 21 Dec '21

21 Dec '21

Teddy Shih has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60266 ) Change subject: mb/google/dedede/var/beadrix: Remove SD controller ...................................................................... mb/google/dedede/var/beadrix: Remove SD controller Remove SD controller configurations based on the beadrix's schematic. BUG=b:204882915 BRANCH=None TEST=Built test coreboot image Signed-off-by: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Change-Id: Iba6f5cbbe90d9307e5e8080d7063a1881acd7ed9 --- M src/mainboard/google/dedede/variants/beadrix/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/60266/1 diff --git a/src/mainboard/google/dedede/variants/beadrix/overridetree.cb b/src/mainboard/google/dedede/variants/beadrix/overridetree.cb index 97e77439..c64765b 100644 --- a/src/mainboard/google/dedede/variants/beadrix/overridetree.cb +++ b/src/mainboard/google/dedede/variants/beadrix/overridetree.cb @@ -52,6 +52,7 @@ end end end # USB xHCI + device pci 14.5 off end # SDCard device pci 15.0 on chip drivers/i2c/hid register "generic.hid" = ""PIXA2635"" -- To view, visit https://review.coreboot.org/c/coreboot/+/60266 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba6f5cbbe90d9307e5e8080d7063a1881acd7ed9 Gerrit-Change-Number: 60266 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
by SH Kim (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: shkim, Henry Sun, Evan Green, Paul Menzel, Tim Wawrzynczak, Simon Yang, Edward Doan, Karthik Ramasubramanian. SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 ) Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode ...................................................................... Patch Set 11: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60190/comment/690ec20c_b627cd37 PS9, Line 14: It takes about 100 ms delay on booting time. > Is it alright to increase the overall boottime? Why can’t the operating system do it? After removing the last 60ms delay, the delay amount is reduced to under 30 ms. And we had a lot of discussions in the issue tracker for it but we couldn't find perfect solution on OS phase. File src/mainboard/google/dedede/variants/bugzzy/ramstage.c: https://review.coreboot.org/c/coreboot/+/60190/comment/191c3ca7_4b4cd9d1 PS9, Line 64: mdelay(60); > maybe try to remove this delay to speed up post time? or record timestamp by "timestamp_add_now" and […] Just verified TSP works w/o this delay. And saw the 'cbmem -t' log we have enough time before jumping to kernel from the WA. (about 300 ms) 75:cbmem post 732,149 (353) 80:write tables 732,251 (102) 85:finalize chips 738,828 (6,576) 90:starting to load payload 749,498 (10,669) 15:starting LZMA decompress (ignore for x86) 751,096 (1,598) 16:finished LZMA decompress (ignore for x86) 805,555 (54,459) 958:calling FspNotify(ReadyToBoot) 810,024 (4,468) 959:returning from FspNotify(ReadyToBoot) 825,449 (15,425) 960:calling FspNotify(EndOfFirmware) 825,510 (61) 961:returning from FspNotify(EndOfFirmware) 844,311 (18,801) 99:selfboot jump 844,689 (377) 1000:depthcharge start 845,727 (1,037) 1002:RO vboot init 845,874 (147) 1020:vboot select&load kernel 845,876 (1) 1040:finished storage device initialization 879,998 (34,122) 1050:finished reading kernel from disk 995,845 (115,846) 1100:finished vboot kernel verification 1,073,437 (77,591) 1101:jumping to kernel 1,082,259 (8,821) -- To view, visit https://review.coreboot.org/c/coreboot/+/60190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa4d16deb932f43ae1ab33ff5b4e74120ab670db Gerrit-Change-Number: 60190 Gerrit-PatchSet: 11 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Edward Doan <edoan(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Edward Doan <edoan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 02:24:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Simon Yang <simon1.yang(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload/i8042: Use 'WARNING' instead of 'ERROR' when probing failed
by Zhuohao Lee (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Hello build bot (Jenkins), Nico Huber, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60129 to look at the new patch set (#4). Change subject: libpayload/i8042: Use 'WARNING' instead of 'ERROR' when probing failed ...................................................................... libpayload/i8042: Use 'WARNING' instead of 'ERROR' when probing failed The probe should output the 'WARNING' instead of 'ERROR' when the i8042 module can't be probed. For the x86 device, which enables the PC_I8042 by default, the 'ERROR' message will be outputted if the device doesn't connect to an i8042 keyboard controller. This is an unexpected error when doing the autotest. BUG=b:207077409 TEST=`test_that f:.*power_Resume/control` pass Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> --- M payloads/libpayload/drivers/i8042/i8042.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60129/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Gerrit-Change-Number: 60129 Gerrit-PatchSet: 4 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
by Zhuohao Lee (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Hello build bot (Jenkins), Nico Huber, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60129 to look at the new patch set (#3). Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed ...................................................................... libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed The probe should output the 'INFO' instead of 'ERROR' when the i8042 module can't be probed. For the x86 device, which enables the PC_I8042 by default, the 'ERROR' message will be outputted if the device doesn't connect to an i8042 keyboard controller. This is an unexpected error when doing the autotest. BUG=b:207077409 TEST=`test_that f:.*power_Resume/control` pass Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Signed-off-by: Zhuohao Lee <zhuohao(a)chromium.org> --- M payloads/libpayload/drivers/i8042/i8042.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60129/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Gerrit-Change-Number: 60129 Gerrit-PatchSet: 3 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed
by Zhuohao Lee (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Nico Huber, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee. Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60129 ) Change subject: libpayload/i8042: Use 'INFO' instead of 'ERROR' when probing failed ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60129/comment/2e96d041_770258d8 PS2, Line 13: when doing the autotest. > PC_I8042 is selected by default for x86 devices (through PC_KEYBOARD) ... […] Yeah, the option is turned on for the x86 by default. Maybe we can use the WARNING instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/60129 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2880c854b873a2a00aa0d8b1cbb4f86fa8139255 Gerrit-Change-Number: 60129 Gerrit-PatchSet: 2 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 02:02:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/nipperkin: update telemetry settings
by Rob Barnes (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Kevin Chiu, Martin Roth, Bhanu Prakash Maiya, Eric Peers, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60243 ) Change subject: mb/google/guybrush/var/nipperkin: update telemetry settings ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c9dd4883fd21a70a1e7a50f25a4f76df1e56bc6 Gerrit-Change-Number: 60243 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Eric Peers <epeers(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 21 Dec 2021 01:55:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: update DRAM ID table
by Kenneth Chan (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Paul Menzel. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60090 ) Change subject: mb/google/guybrush/var/dewatt: update DRAM ID table ...................................................................... Patch Set 6: (1 comment) File src/mainboard/google/guybrush/variants/guybrush/memory/mem_parts_used.txt: https://review.coreboot.org/c/coreboot/+/60090/comment/21f063d5_5929bb0e PS4, Line 13: H54G56CYRBX247 > Makes sense. Maybe amend the commit message nevertheless. Maybe: […] Ok. -- To view, visit https://review.coreboot.org/c/coreboot/+/60090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5ece849a86c75be5af9bc0393090b5f1e33bfed Gerrit-Change-Number: 60090 Gerrit-PatchSet: 6 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 21 Dec 2021 01:54:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021