coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/dedede/var/beadrix: Enable audio feature
by Karthik Ramasubramanian (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Teddy Shih, Paul Fagerburg, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60250 ) Change subject: mb/google/dedede/var/beadrix: Enable audio feature ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f12f71ec66acd420471ab9a7612b1821650ad54 Gerrit-Change-Number: 60250 Gerrit-PatchSet: 2 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add internal USB camera support
by Karthik Ramasubramanian (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Teddy Shih, Paul Fagerburg, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60252 ) Change subject: mb/google/dedede/var/beadrix: Add internal USB camera support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iddc58c0d27d5da0fa4652f503f15ebb308be18c7 Gerrit-Change-Number: 60252 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:41:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/acer/g43t-am3: Add documentation
by Angel Pons (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Felix Singer, Paul Menzel, Michael Büchler. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56838 ) Change subject: mb/acer/g43t-am3: Add documentation ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File Documentation/mainboard/acer/g43t-am3.md: https://review.coreboot.org/c/coreboot/+/56838/comment/76f73ab1_68728267 PS2, Line 108: flashrom -p internal -r backup.rom > You're right, my notes from 1 1/2 years ago are wrong and the ME_DISABLE jumper does trigger the fla […] Unless needed for some reason, it's best to *not* bypass the IFD restrictions and use `--noverify-all`. This avoids accidentally flashing an incomplete image if one forgets `--ifd -i bios`. However, if the IFD settings are unrestricted by default, I'm fine leaving it as-is. -- To view, visit https://review.coreboot.org/c/coreboot/+/56838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 Gerrit-Change-Number: 56838 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/futility: Ensure futility checks for flashrom as a dep
by Edward O'Callaghan (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Martin Roth, Hsuan-ting Chen, Julius Werner. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60236 ) Change subject: util/futility: Ensure futility checks for flashrom as a dep ...................................................................... Patch Set 4: Code-Review-1 (2 comments) Patchset: PS3: > I don't think this is the right approach, because the `tools` target is pretty must only used by Jen […] You are probably right Julius, I was just looking for a intermediate step as futility needs quite a bit of work. I suppose i'll just knuckle down today and push though more futility refactoring. File util/futility/Makefile.inc: https://review.coreboot.org/c/coreboot/+/60236/comment/595d830c_60f80e0c PS1, Line 7: | > There should be no veritical bar here? […] . -- To view, visit https://review.coreboot.org/c/coreboot/+/60236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Gerrit-Change-Number: 60236 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:28:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/futility: Ensure futility checks for flashrom as a dep
by Edward O'Callaghan (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Edward O'Callaghan. Hello Hsuan-ting Chen, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60236 to look at the new patch set (#4). Change subject: util/futility: Ensure futility checks for flashrom as a dep ...................................................................... util/futility: Ensure futility checks for flashrom as a dep futility actually depends on flashrom. Previously it was of the form of subprocess and now uses the libflashrom API directly. Due to the previous subprocess decoupling it was not obvious that the dependency existed however not the runtime requirement is also a strict buildtime requirement. Therefore update the Makefile accordingly. BUG=b:203715651,b:209702505 TEST=builds Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M Makefile.inc M util/futility/Makefile.inc M util/testing/Makefile.inc 3 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/60236/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Gerrit-Change-Number: 60236 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/acer/g43t-am3: Add documentation
by Michael Büchler (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Felix Singer, Paul Menzel, Angel Pons. Michael Büchler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56838 ) Change subject: mb/acer/g43t-am3: Add documentation ...................................................................... Patch Set 4: (1 comment) File Documentation/mainboard/acer/g43t-am3.md: https://review.coreboot.org/c/coreboot/+/56838/comment/fea805d5_e0ec1e02 PS2, Line 108: flashrom -p internal -r backup.rom > > I'm pretty sure I haven't, but I found the board in a dumpster so it might very well be that someb […] You're right, my notes from 1 1/2 years ago are wrong and the ME_DISABLE jumper does trigger the flashrom note. I can also see GPIO33 changing on `inteltool -g` (`GP_LVL2` bit 1). Thus I don't see why anyone who had this board before me would have modified the IFD if they could've just set the jumper.. the totally unrestricted settings in the IFD (all 0xff) must be how Acer shipped the board. I removed the `--noverify-all` hint for now, and described the jumper. What do you think? -- To view, visit https://review.coreboot.org/c/coreboot/+/56838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 Gerrit-Change-Number: 56838 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:08:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/acer/g43t-am3: Add documentation
by Michael Büchler (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Felix Singer, Paul Menzel, Michael Büchler. Hello Felix Singer, build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56838 to look at the new patch set (#4). Change subject: mb/acer/g43t-am3: Add documentation ...................................................................... mb/acer/g43t-am3: Add documentation Signed-off-by: Michael Büchler <michael.buechler(a)posteo.net> Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 --- A Documentation/mainboard/acer/g43t-am3.md M Documentation/mainboard/index.md 2 files changed, 182 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/56838/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56838 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e296b3efbff0260f32badc699f1062f9885fa53 Gerrit-Change-Number: 56838 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/futility: Ensure futility checks for flashrom as a dep
by Julius Werner (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Edward O'Callaghan. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60236 ) Change subject: util/futility: Ensure futility checks for flashrom as a dep ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I don't think this is the right approach, because the `tools` target is pretty must only used by Jenkins anyway. I don't think normal users build that. If we just want to fix Jenkins, the better option would be to just make sure it has the right libflashrom headers in its environment. Normal coreboot users may still want to use futility (minus the `update` command) though, so I think the better solution would be to make futility able to build without the dependency (disabling the affected commands). -- To view, visit https://review.coreboot.org/c/coreboot/+/60236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Gerrit-Change-Number: 60236 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Dec 2021 23:03:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/futility: Ensure futility checks for flashrom as a dep
by Edward O'Callaghan (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Julius Werner. Edward O'Callaghan has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/60236 ) Change subject: util/futility: Ensure futility checks for flashrom as a dep ...................................................................... Removed reviewer Martin Roth. -- To view, visit https://review.coreboot.org/c/coreboot/+/60236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Gerrit-Change-Number: 60236 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: util/futility: Ensure futility checks for flashrom as a dep
by Edward O'Callaghan (Code Review) 21 Dec '21

21 Dec '21

Attention is currently required from: Edward O'Callaghan, Julius Werner. Hello Hsuan-ting Chen, Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60236 to look at the new patch set (#3). Change subject: util/futility: Ensure futility checks for flashrom as a dep ...................................................................... util/futility: Ensure futility checks for flashrom as a dep futility actually depends on flashrom. Previously it was of the form of subprocess and now uses the libflashrom API directly. Due to the previous subprocess decoupling it was not obvious that the dependency existed however not the runtime requirement is also a strict buildtime requirement. Therefore update the Makefile accordingly. BUG=b:203715651,b:209702505 TEST=builds Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M Makefile.inc M util/futility/Makefile.inc 2 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/60236/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Gerrit-Change-Number: 60236 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021