coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/amd/cezanne/acpi: Add support for RTC workaround
by Raul Rangel (Code Review) 20 Dec '21

20 Dec '21

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60172 ) Change subject: soc/amd/cezanne/acpi: Add support for RTC workaround ...................................................................... Patch Set 2: (2 comments) File src/soc/amd/cezanne/acpi/rtc_workaround.asl: https://review.coreboot.org/c/coreboot/+/60172/comment/d1a86734_112b0d29 PS2, Line 23: _E2C > I am not seeing a documentation for this method. […] https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Sof… https://review.coreboot.org/c/coreboot/+/60172/comment/c0ca0ba8_43ec56de PS2, Line 24: \_SB_ > Is this extra underscore a typo? It wasn't intentional, but I think it's fine. I think ACPI names that are shorter than 4 characters have the _ suffix appended as padding. -- To view, visit https://review.coreboot.org/c/coreboot/+/60172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f14d14df5d30d48d244416f2ec8c10ac5c8040e Gerrit-Change-Number: 60172 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mario Limonciello <mario.limonciello(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 21:55:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: starlabs: Convert EC_GPE_SCI to Kconfig
by Angel Pons (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60229 ) Change subject: starlabs: Convert EC_GPE_SCI to Kconfig ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 Gerrit-Change-Number: 60229 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Mon, 20 Dec 2021 21:36:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/labtop: Enable I2C4
by Sean Rhodes (Code Review) 20 Dec '21

20 Dec '21

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60264 ) Change subject: mb/starlabs/labtop: Enable I2C4 ...................................................................... mb/starlabs/labtop: Enable I2C4 Enable I2C4 to allow for proper enumeration but avoid FSP configuring it. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I9c2c4f67672ba5667ebdae9ecc01054449dd3dfd --- M src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/60264/1 diff --git a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb index a3fc715..ed32afc 100644 --- a/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb @@ -28,6 +28,7 @@ # Serial I/O register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C4] = PchSerialIoSkipInit, }" register "SerialIoUartMode" = "{ @@ -165,7 +166,7 @@ register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[1]" = "1" end - device pci 19.0 off end # I2C4 + device pci 19.0 on end # I2C4 device pci 19.1 off end # I2C5 device pci 19.2 on end # UART #2 device pci 1c.0 off end # PCI Express Port 1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c2c4f67672ba5667ebdae9ecc01054449dd3dfd Gerrit-Change-Number: 60264 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: starlabs: Convert EC_GPE_SCI to Kconfig
by Sean Rhodes (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60229 ) Change subject: starlabs: Convert EC_GPE_SCI to Kconfig ...................................................................... Patch Set 4: (3 comments) File src/ec/starlabs/merlin/Kconfig: https://review.coreboot.org/c/coreboot/+/60229/comment/22b18903_6a7e47dd PS3, Line 59: GPI > GP*E* […] Done File src/mainboard/starlabs/labtop/Kconfig: https://review.coreboot.org/c/coreboot/+/60229/comment/13654fd8_5b9e4da7 PS3, Line 54: GPI > GP*E* Done File src/mainboard/starlabs/labtop/dsdt.asl: https://review.coreboot.org/c/coreboot/+/60229/comment/2996d01f_86768874 PS3, Line 3: #define EC_GPE_SCI CONFIG_EC_GPE_SCI > Please also drop the define. It's currently only used in one place in your EC code: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 Gerrit-Change-Number: 60229 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 21:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: starlabs: Convert EC_GPE_SCI to Kconfig
by Sean Rhodes (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60229 to look at the new patch set (#4). Change subject: starlabs: Convert EC_GPE_SCI to Kconfig ...................................................................... starlabs: Convert EC_GPE_SCI to Kconfig Convert EC_GPI_SCI to Kconfig option with default value of 0x50 that is used by most boards. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 --- M src/ec/starlabs/merlin/Kconfig M src/ec/starlabs/merlin/acpi/ec.asl M src/mainboard/starlabs/labtop/Kconfig M src/mainboard/starlabs/labtop/dsdt.asl 4 files changed, 8 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/60229/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d47ebe76394fe1bcb217e0c6211db1566f82189 Gerrit-Change-Number: 60229 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts
by Karthik Ramasubramanian (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Dtrain Hsu, Henry Sun. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58412 ) Change subject: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/58412 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03980858f89e56320ddff3a808110a5f1dd57784 Gerrit-Change-Number: 58412 Gerrit-PatchSet: 4 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 21:13:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Configure GPIO settings
by Karthik Ramasubramanian (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Paul Menzel, Aseda Aboagye, Teddy Shih, Paul Fagerburg, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60245 ) Change subject: mb/google/dedede/var/beadrix: Configure GPIO settings ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/dedede/variants/beadrix/gpio.c: https://review.coreboot.org/c/coreboot/+/60245/comment/569488c8_e646b40c PS2, Line 60: PAD_NC(GPP_H1, NONE), It seems SD Card is not going to be supported. If so, SD Controller can be disabled in beadrix overridetree.cb? device pci 14.5 off end # SDCard https://review.coreboot.org/c/coreboot/+/60245/comment/a25e0e2d_73d2c05a PS2, Line 63: /* TODO; static const struct pad_config lte_disable_pads[] = { : PAD_NC(GPP_A10, NONE), : PAD_NC(GPP_D0, NONE), : PAD_NC(GPP_H17, NONE), : }; */ Remove the TODO. Same comment for line 75 - 81. -- To view, visit https://review.coreboot.org/c/coreboot/+/60245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53fc8088ff8ebb2790ac8cd68186cf9de908b414 Gerrit-Change-Number: 60245 Gerrit-PatchSet: 2 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 21:12:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Correct memory settings
by Karthik Ramasubramanian (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Teddy Shih, Paul Fagerburg, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60244 ) Change subject: mb/google/dedede/var/beadrix: Correct memory settings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I935581fbf21be4820b03a608ea5bd60b1c000baa Gerrit-Change-Number: 60244 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 21:00:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add memory part and generate DRAM ID
by Karthik Ramasubramanian (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Henry Sun, Aseda Aboagye, Teddy Shih, Paul Fagerburg, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60242 ) Change subject: mb/google/dedede/var/beadrix: Add memory part and generate DRAM ID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60242 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibff150bb4e742f32641da661cfca6594d18c52e9 Gerrit-Change-Number: 60242 Gerrit-PatchSet: 1 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 20 Dec 2021 20:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Add stylus pen function
by Karthik Ramasubramanian (Code Review) 20 Dec '21

20 Dec '21

Attention is currently required from: Evan Green, Ren Kuo, Paul Menzel, Aseda Aboagye, Tyler Wang. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60185 ) Change subject: mb/google/dedede/var/magolor: Add stylus pen function ...................................................................... Patch Set 2: (3 comments) File src/mainboard/google/dedede/variants/magolor/gpio.c: https://review.coreboot.org/c/coreboot/+/60185/comment/c4a7232b_556cd9d1 PS2, Line 9: Nit: Remove the extra line https://review.coreboot.org/c/coreboot/+/60185/comment/74e31cf6_7ffa19ae PS2, Line 12: Nit: Remove the extra line https://review.coreboot.org/c/coreboot/+/60185/comment/a1c1d928_11a77a6a PS2, Line 17: *num = ARRAY_SIZE(gpio_table); This Firmware target is applied to Magolor/Maglia/Magma/Maglet etc. Is pen stuffed on all boards. I believe not. If so, can you please apply this configuration only on the boards where pen is stuffed and mark this GPIO as PAD_NC on other boards. Otherwise you might end up receiving spurious wakes due to this GPIO configuration. -- To view, visit https://review.coreboot.org/c/coreboot/+/60185 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62489bb289b18f9aa0823005224eda3ef5218e03 Gerrit-Change-Number: 60185 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Evan Green <evgreen(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 20:44:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021