coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60373 ) Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:25:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 2: (2 comments) File util/liveiso/build.sh: https://review.coreboot.org/c/coreboot/+/60372/comment/6f5f5158_be45ba99 PS1, Line 6: echo "No config given. Exiting." > maybe also print usage like this? "Usage: build.sh <graphical.nix|console.nix|... […] Done https://review.coreboot.org/c/coreboot/+/60372/comment/268b6385_a11450f8 PS1, Line 12: nixos-config=$config > could be `nixos-config=${config}. […] I also thought about that, but decided against it. It doesn't provide more advantages. -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:22:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60373 ) Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60373/comment/965bd21c_12d18985 PS2, Line 10: local > locally Done https://review.coreboot.org/c/coreboot/+/60373/comment/1788e43e_c96ca996 PS2, Line 11: a NixOS channel > `a specific`? Done https://review.coreboot.org/c/coreboot/+/60373/comment/bb3ef9e2_b6611e78 PS2, Line 11: and let `nixpkgs` point to a NixOS channel > nit: `but let ... […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60373 to look at the new patch set (#3). Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... util/liveiso: Ensure compatible NixOS channel is used Config options and package names might change from channel to channel. Thus, don't let nix-build depend on the locally configured NixOS channel, but instead let `nixpkgs` point to a specific channel to ensure that always a compatible channel is used. For now, let `nixpkgs` point to NixOS 21.11, which is currently the latest stable release. This needs to be updated after a new release. Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/build.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/60373/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60372 to look at the new patch set (#2). Change subject: util/liveiso: Merge build scripts ...................................................................... util/liveiso: Merge build scripts Merge build scripts to `build.sh`. The new one takes the desired NixOS config as an argument. Example: $ build.sh console.nix Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- D util/liveiso/build-console.sh D util/liveiso/build-graphical.sh A util/liveiso/build.sh 3 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60372/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60373 ) Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 10:32:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Disable write protection of the intel-spi driver
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60375 ) Change subject: util/liveiso: Disable write protection of the intel-spi driver ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib73d14eb4e7df6e29433b8dfbeb77dbab4a85f08 Gerrit-Change-Number: 60375 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 10:32:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Install mtdutils
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60376 ) Change subject: util/liveiso: Install mtdutils ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1416d8f783518eca0606efef4314a3d86837b016 Gerrit-Change-Number: 60376 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 10:32:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60373 ) Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60373/comment/401522df_d69fee79 PS2, Line 10: local locally https://review.coreboot.org/c/coreboot/+/60373/comment/6548b3a7_67862d22 PS2, Line 11: a NixOS channel `a specific`? https://review.coreboot.org/c/coreboot/+/60373/comment/ba2db866_b9c9f009 PS2, Line 11: and let `nixpkgs` point to a NixOS channel nit: `but let ... instead to ensure` -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 10:31:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021