coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by 9elements QA (Code Review) 26 Dec '21

26 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 7: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/85847 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/85846 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85845 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/85844 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85843 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/85842 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/85841 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/85840 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 26 Dec 2021 20:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 26 Dec '21

26 Dec '21

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig Current mainboard code supports different baseboard binding example: brya uses BOARD_GOOGLE_BASEBOARD_BRYA and brask uses BOARD_GOOGLE_BASEBOARD_BRASK Kconfig. This patch makes the `BOARD_GOOGLE_BRYA_COMMON` Kconfig default `n` and specific baseboard binding Kconfig can select this Kconfig. It would also avoid adding if clause for specific baseboard binding Kconfig everytime with introduction of newer mainboard in future. TEST=Verified CONFIG_BOARD_GOOGLE_BRYA_COMMON=y while building brya and brya coreboot.rom remains the same. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Reviewed-on: https://review.coreboot.org/c/coreboot/+/60379 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig 1 file changed, 22 insertions(+), 20 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved EricR Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 0e7651f..34e005d 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -1,23 +1,5 @@ -config BOARD_GOOGLE_BASEBOARD_BRYA - def_bool n - select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS - select HAVE_SPD_IN_CBFS - select SOC_INTEL_ALDERLAKE_PCH_P - select SYSTEM_TYPE_LAPTOP - -config BOARD_GOOGLE_BASEBOARD_BRASK - def_bool n - select SPD_CACHE_IN_FMAP - select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE - select RT8168_GEN_ACPI_POWER_RESOURCE - select SOC_INTEL_ALDERLAKE_PCH_P - -if BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK - config BOARD_GOOGLE_BRYA_COMMON - def_bool y + def_bool n select BOARD_ROMSIZE_KB_32768 select DRIVERS_GENERIC_ALC1015 select DRIVERS_GENERIC_GPIO_KEYS @@ -53,6 +35,26 @@ select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3 select SOC_INTEL_CSE_LITE_SKU +config BOARD_GOOGLE_BASEBOARD_BRYA + def_bool n + select BOARD_GOOGLE_BRYA_COMMON + select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS + select HAVE_SPD_IN_CBFS + select SOC_INTEL_ALDERLAKE_PCH_P + select SYSTEM_TYPE_LAPTOP + +config BOARD_GOOGLE_BASEBOARD_BRASK + def_bool n + select BOARD_GOOGLE_BRYA_COMMON + select SPD_CACHE_IN_FMAP + select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + select RT8168_GEN_ACPI_POWER_RESOURCE + select SOC_INTEL_ALDERLAKE_PCH_P + +if BOARD_GOOGLE_BRYA_COMMON + config BASEBOARD_DIR string default "brya" if BOARD_GOOGLE_BASEBOARD_BRYA @@ -187,4 +189,4 @@ endchoice -endif # BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK +endif # BOARD_GOOGLE_BRYA_COMMON 5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya: Move PCH selection to variant config
by Subrata Banik (Code Review) 26 Dec '21

26 Dec '21

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60378 ) Change subject: mb/google/brya: Move PCH selection to variant config ...................................................................... mb/google/brya: Move PCH selection to variant config This patch ensures ADL-P PCH can get selected by mainboard variants to accommodate mainboards with ADL-N PCH in future. TEST=Able to build and boot brya without any Kconfig change. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Reviewed-on: https://review.coreboot.org/c/coreboot/+/60378 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 02ca38f..0e7651f 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -2,6 +2,7 @@ def_bool n select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS select HAVE_SPD_IN_CBFS + select SOC_INTEL_ALDERLAKE_PCH_P select SYSTEM_TYPE_LAPTOP config BOARD_GOOGLE_BASEBOARD_BRASK @@ -11,6 +12,7 @@ select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE select RT8168_GEN_ACPI_POWER_RESOURCE + select SOC_INTEL_ALDERLAKE_PCH_P if BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK @@ -48,7 +50,6 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 - select SOC_INTEL_ALDERLAKE_PCH_P select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3 select SOC_INTEL_CSE_LITE_SKU -- To view, visit https://review.coreboot.org/c/coreboot/+/60378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Gerrit-Change-Number: 60378 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/brya: Make more brya variants to choose eNEM for CAR
by Subrata Banik (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer, David Wu, Tim Wawrzynczak, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 ) Change subject: mb/google/brya: Make more brya variants to choose eNEM for CAR ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60377/comment/a7a053b4_45d78ea6 PS2, Line 7: Make more brya variants to choose eNEM for CAR > Oh sure 😊 Thanks Felix -- To view, visit https://review.coreboot.org/c/coreboot/+/60377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f Gerrit-Change-Number: 60377 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sun, 26 Dec 2021 14:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/hp/kbc1126: Use Printf() for debug prints
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60383 ) Change subject: ec/hp/kbc1126: Use Printf() for debug prints ...................................................................... ec/hp/kbc1126: Use Printf() for debug prints Change-Id: Id343bde61706d4d1de2102c3567141e427d8126d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/hp/kbc1126/acpi/ac.asl M src/ec/hp/kbc1126/acpi/battery.asl M src/ec/hp/kbc1126/acpi/ec.asl M src/ec/hp/kbc1126/acpi/lid.asl 4 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/60383/1 diff --git a/src/ec/hp/kbc1126/acpi/ac.asl b/src/ec/hp/kbc1126/acpi/ac.asl index f9d346b..f058cef 100644 --- a/src/ec/hp/kbc1126/acpi/ac.asl +++ b/src/ec/hp/kbc1126/acpi/ac.asl @@ -65,7 +65,7 @@ Method (_Q06, 0, NotSerialized) { - Store ("EC: AC STATUS", Debug) + Printf ("EC: AC STATUS") PWUP (0x05, (0x02 | 0x01)) If (BTDR (0x02)) { diff --git a/src/ec/hp/kbc1126/acpi/battery.asl b/src/ec/hp/kbc1126/acpi/battery.asl index 6669726..003e58b 100644 --- a/src/ec/hp/kbc1126/acpi/battery.asl +++ b/src/ec/hp/kbc1126/acpi/battery.asl @@ -437,7 +437,7 @@ Method (_Q03, 0, NotSerialized) { - Store ("EC: _Q03", Debug) + Printf ("EC: _Q03") Acquire (BTMX, 0xFFFF) Local0 = NDCB Release (BTMX) @@ -447,7 +447,7 @@ Method (_Q08, 0, NotSerialized) { - Store ("EC: PRIMARY BATTERY ATTACHED/DETACHED", Debug) + Printf ("EC: PRIMARY BATTERY ATTACHED/DETACHED") PWUP (0x06, 0x01) Local0 = GBAP () If ((Local0 != 0x02)) @@ -467,7 +467,7 @@ Method (_Q09, 0, NotSerialized) { - Store ("EC: PRIMARY BATTERY STATUS", Debug) + Printf ("EC: PRIMARY BATTERY STATUS") PWUP (0x04, 0x01) If (BTDR (0x02)) { @@ -477,7 +477,7 @@ Method (_Q18, 0, NotSerialized) { - Store("EC: SECONDARY BATTERY ATTACHED/DETACHED", Debug) + Printf ("EC: SECONDARY BATTERY ATTACHED/DETACHED") PWUP (0x06, 0x02) Local0 = GBAP () If ((Local0 != 0x01)) @@ -497,7 +497,7 @@ Method (_Q19, 0, NotSerialized) { - Store ("EC: SECONDARY BATTERY STATUS", Debug) + Printf ("EC: SECONDARY BATTERY STATUS") PWUP (0x04, 0x02) If (BTDR (0x02)) { diff --git a/src/ec/hp/kbc1126/acpi/ec.asl b/src/ec/hp/kbc1126/acpi/ec.asl index 81bdff9..4c0056d 100644 --- a/src/ec/hp/kbc1126/acpi/ec.asl +++ b/src/ec/hp/kbc1126/acpi/ec.asl @@ -202,27 +202,27 @@ Method (_Q04, 0, NotSerialized) { - Store ("EC: _Q04", Debug) + Printf ("EC: _Q04") PNOT() } Method (_Q05, 0, NotSerialized) { - Store ("EC: _Q05", Debug) + Printf ("EC: _Q05") } Method (_Q0B, 0, NotSerialized) { - Store ("EC: _Q0B", Debug) + Printf ("EC: _Q0B") } Method (_Q0C, 0, NotSerialized) { - Store ("EC: _Q0C", Debug) + Printf ("EC: _Q0C") } Method (_Q0D, 0, NotSerialized) { - Store ("EC: _Q0D", Debug) + Printf ("EC: _Q0D") } } diff --git a/src/ec/hp/kbc1126/acpi/lid.asl b/src/ec/hp/kbc1126/acpi/lid.asl index 2494168..1a5134f 100644 --- a/src/ec/hp/kbc1126/acpi/lid.asl +++ b/src/ec/hp/kbc1126/acpi/lid.asl @@ -12,6 +12,6 @@ Method (_Q0A, 0, NotSerialized) { - Store ("EC: LID STATUS", Debug) + Printf ("EC: LID STATUS") Notify (LID, 0x80) } -- To view, visit https://review.coreboot.org/c/coreboot/+/60383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id343bde61706d4d1de2102c3567141e427d8126d Gerrit-Change-Number: 60383 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: ec/chromeec/ec: Use Printf() for debug prints
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60381 ) Change subject: ec/chromeec/ec: Use Printf() for debug prints ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b06f74be155e0c4053a38a1c5fd30ff6715111e Gerrit-Change-Number: 60381 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 14:30:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Use Printf() for debug prints
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60380 ) Change subject: ec/starlabs/merlin: Use Printf() for debug prints ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib59cba7bf553e8323c20fd9aa3474f3ecccf465a Gerrit-Change-Number: 60380 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 14:30:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/purism/librem-ec: Use Printf() for debug prints
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60382 ) Change subject: ec/purism/librem-ec: Use Printf() for debug prints ...................................................................... ec/purism/librem-ec: Use Printf() for debug prints Change-Id: Ic26c24d1246f8a40191e02229e66f6a893e488fa Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/ec/purism/librem-ec/acpi/ec.asl M src/ec/purism/librem-ec/acpi/librem-ec.asl 2 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/60382/1 diff --git a/src/ec/purism/librem-ec/acpi/ec.asl b/src/ec/purism/librem-ec/acpi/ec.asl index bc225e7..6195723 100644 --- a/src/ec/purism/librem-ec/acpi/ec.asl +++ b/src/ec/purism/librem-ec/acpi/ec.asl @@ -34,7 +34,7 @@ Name (ECOK, Zero) Method (_REG, 2, Serialized) // _REG: Region Availability { - Debug = Concatenate("EC: _REG", Concatenate(ToHexString(Arg0), Concatenate(" ", ToHexString(Arg1)))) + Printf (Concatenate("EC: _REG", Concatenate(ToHexString(Arg0), Concatenate(" ", ToHexString(Arg1))))) If ((Arg0 == 0x03) && (Arg1 == One)) { // Enable hardware touchpad lock, airplane mode, and keyboard backlight keys ECOS = 1 @@ -63,7 +63,7 @@ } Method (PTS, 1, Serialized) { - Debug = Concatenate("EC: PTS: ", ToHexString(Arg0)) + Printf (Concatenate("EC: PTS: ", ToHexString(Arg0))) If (ECOK) { // Clear wake cause WFNO = Zero @@ -71,7 +71,7 @@ } Method (WAK, 1, Serialized) { - Debug = Concatenate("EC: WAK: ", ToHexString(Arg0)) + Printf (Concatenate("EC: WAK: ", ToHexString(Arg0))) If (ECOK) { // Set current AC state ^^^^AC.ACFG = ADP @@ -91,42 +91,42 @@ Method (_Q0A, 0, NotSerialized) // Touchpad Toggle { - Debug = "EC: Touchpad Toggle" + Printf ("EC: Touchpad Toggle") } Method (_Q0B, 0, NotSerialized) // Screen Toggle { - Debug = "EC: Screen Toggle" + Printf ("EC: Screen Toggle") } Method (_Q0C, 0, NotSerialized) // Mute { - Debug = "EC: Mute" + Printf ("EC: Mute") } Method (_Q0D, 0, NotSerialized) // Keyboard Backlight { - Debug = "EC: Keyboard Backlight" + Printf ("EC: Keyboard Backlight") } Method (_Q0E, 0, NotSerialized) // Volume Down { - Debug = "EC: Volume Down" + Printf ("EC: Volume Down") } Method (_Q0F, 0, NotSerialized) // Volume Up { - Debug = "EC: Volume Up" + Printf ("EC: Volume Up") } Method (_Q10, 0, NotSerialized) // Switch Video Mode { - Debug = "EC: Switch Video Mode" + Printf ("EC: Switch Video Mode") } Method (_Q11, 0, NotSerialized) // Brightness Down { - Debug = "EC: Brightness Down" + Printf ("EC: Brightness Down") if (^^^^HIDD.HRDY) { ^^^^HIDD.HPEM (20) } @@ -134,7 +134,7 @@ Method (_Q12, 0, NotSerialized) // Brightness Up { - Debug = "EC: Brightness Up" + Printf ("EC: Brightness Up") if (^^^^HIDD.HRDY) { ^^^^HIDD.HPEM (19) } @@ -142,12 +142,12 @@ Method (_Q13, 0, NotSerialized) // Camera Toggle { - Debug = "EC: Camera Toggle" + Printf ("EC: Camera Toggle") } Method (_Q14, 0, NotSerialized) // Airplane Mode { - Debug = "EC: Airplane Mode" + Printf ("EC: Airplane Mode") if (^^^^HIDD.HRDY) { ^^^^HIDD.HPEM (8) } @@ -156,13 +156,13 @@ Method (_Q15, 0, NotSerialized) // Suspend Button { - Debug = "EC: Suspend Button" + Printf ("EC: Suspend Button") Notify (SLPB, 0x80) } Method (_Q16, 0, NotSerialized) // AC Detect { - Debug = "EC: AC Detect" + Printf ("EC: AC Detect") ^^^^AC.ACFG = ADP Notify (AC, 0x80) // Status Change If (BAT0) @@ -174,25 +174,25 @@ Method (_Q17, 0, NotSerialized) // BAT0 Update { - Debug = "EC: BAT0 Update (17)" + Printf ("EC: BAT0 Update (17)") Notify (^^^^BAT0, 0x81) // Information Change } Method (_Q19, 0, NotSerialized) // BAT0 Update { - Debug = "EC: BAT0 Update (19)" + Printf ("EC: BAT0 Update (19)") Notify (^^^^BAT0, 0x81) // Information Change } Method (_Q1B, 0, NotSerialized) // Lid Close { - Debug = "EC: Lid Close" + Printf ("EC: Lid Close") Notify (LID0, 0x80) } Method (_Q1C, 0, NotSerialized) // Thermal Trip { - Debug = "EC: Thermal Trip" + Printf ("EC: Thermal Trip") /* TODO Notify (\_TZ.TZ0, 0x81) // Thermal Trip Point Change Notify (\_TZ.TZ0, 0x80) // Thermal Status Change @@ -201,7 +201,7 @@ Method (_Q1D, 0, NotSerialized) // Power Button { - Debug = "EC: Power Button" + Printf ("EC: Power Button") Notify (PWRB, 0x80) } @@ -209,22 +209,22 @@ { Local0 = OEM4 If (Local0 == 0x8A) { - Debug = "EC: White Keyboard Backlight" + Printf ("EC: White Keyboard Backlight") Notify (^^^^LIEC, 0x80) } ElseIf (Local0 == 0x9F) { - Debug = "EC: Color Keyboard Toggle" + Printf ("EC: Color Keyboard Toggle") Notify (^^^^LIEC, 0x81) } ElseIf (Local0 == 0x81) { - Debug = "EC: Color Keyboard Down" + Printf ("EC: Color Keyboard Down") Notify (^^^^LIEC, 0x82) } ElseIf (Local0 == 0x82) { - Debug = "EC: Color Keyboard Up" + Printf ("EC: Color Keyboard Up") Notify (^^^^LIEC, 0x83) } ElseIf (Local0 == 0x80) { - Debug = "EC: Color Keyboard Color Change" + Printf ("EC: Color Keyboard Color Change") Notify (^^^^LIEC, 0x84) } Else { - Debug = Concatenate("EC: Other: ", ToHexString(Local0)) + Printf (Concatenate("EC: Other: ", ToHexString(Local0))) } } diff --git a/src/ec/purism/librem-ec/acpi/librem-ec.asl b/src/ec/purism/librem-ec/acpi/librem-ec.asl index 5914d17..ea227c7 100644 --- a/src/ec/purism/librem-ec/acpi/librem-ec.asl +++ b/src/ec/purism/librem-ec/acpi/librem-ec.asl @@ -11,13 +11,13 @@ Name (_UID, 0) Method (RSET, 0, Serialized) { - Debug = "LIEC: RSET" + Printf ("LIEC: RSET") SAPL(0) SKBL(0) } Method (INIT, 0, Serialized) { - Debug = "LIEC: INIT" + Printf ("LIEC: INIT") RSET() If (^^PCI0.LPCB.EC0.ECOK) { // Set flags to use software control @@ -29,7 +29,7 @@ } Method (FINI, 0, Serialized) { - Debug = "LIEC: FINI" + Printf ("LIEC: FINI") RSET() If (^^PCI0.LPCB.EC0.ECOK) { // Set flags to use hardware control -- To view, visit https://review.coreboot.org/c/coreboot/+/60382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic26c24d1246f8a40191e02229e66f6a893e488fa Gerrit-Change-Number: 60382 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/liveiso: Install mtdutils
by 9elements QA (Code Review) 26 Dec '21

26 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60376 ) Change subject: util/liveiso: Install mtdutils ...................................................................... Patch Set 7: Automatic boot test returned (PASS/FAIL/TOTAL): 7 / 1 / 8 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/85826 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/85825 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85824 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/85823 PASS: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/85822 FAIL: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/85821 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/85820 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/85819 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/60376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1416d8f783518eca0606efef4314a3d86837b016 Gerrit-Change-Number: 60376 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Sun, 26 Dec 2021 13:49:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Install mtdutils
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60376 ) Change subject: util/liveiso: Install mtdutils ...................................................................... util/liveiso: Install mtdutils Change-Id: I1416d8f783518eca0606efef4314a3d86837b016 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60376 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/liveiso/common.nix 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/util/liveiso/common.nix b/util/liveiso/common.nix index d0b7ba6..fefbe81 100644 --- a/util/liveiso/common.nix +++ b/util/liveiso/common.nix @@ -138,6 +138,7 @@ mkpasswd ms-sys msr-tools + mtdutils neovim nixos-install-tools ntfsprogs 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1416d8f783518eca0606efef4314a3d86837b016 Gerrit-Change-Number: 60376 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021