Attention is currently required from: Nico Huber, Jamie Chen, Subrata Banik, Henry Sun, Tim Wawrzynczak, Paul Menzel, Ren Kuo, Simon Yang, Kane Chen, Patrick Rudolph.
Hello build bot (Jenkins), Jamie Chen, Subrata Banik, Henry Sun, Tim Wawrzynczak, Angel Pons, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60009
to look at the new patch set (#18).
Change subject: soc/intel/jasperlake: Add CdClock frequency config
......................................................................
soc/intel/jasperlake: Add CdClock frequency config
Add a devicetree setting to configure the CdClock (Core Display Clock)
frequency through a FSP UPD. Because the value for this UPD's default
setting is non-zero and devicetree settings default to 0 if not set,
adapt the devicetree values so that the value for the UPD's default
setting is used when the devicetree setting is zero.
BUG=b:206557434
BRANCH=dedede
TEST=Build fw and confirm FSP setting are set properly by log
Signed-off-by: Simon Yang <simon1.yang(a)intel.com>
Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97
---
M src/soc/intel/jasperlake/chip.h
M src/soc/intel/jasperlake/fsp_params.c
M src/vendorcode/intel/fsp/fsp2_0/jasperlake/FspsUpd.h
3 files changed, 17 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60009/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/60009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I917c2f10b130b0cd54f60e2ba98eb971d5ec3c97
Gerrit-Change-Number: 60009
Gerrit-PatchSet: 18
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Rex-BC Chen, Paul Menzel, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS7:
> I think it's hard to remove this patch in separate commmit. […]
Number of commits is not a problem. Unless if there'll be compile error that can't be fixed, otherwise we should always do soc/ changes in one patch, and mb/ changes in another.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1a1e04da0cce9aaf86588a94c64d2242e7cb4b7
Gerrit-Change-Number: 60318
Gerrit-PatchSet: 8
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 27 Dec 2021 03:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/blobs/+/60339 )
Change subject: soc/mediatek/mt8186: Add SSPM firmware
......................................................................
soc/mediatek/mt8186: Add SSPM firmware
Add sspm.bin to support suspend/resume.
TEST=build pass
BUG=b:202871018
Signed-off-by: Allen-KH Cheng <allen-kh.cheng(a)mediatek.corp-partner.google.com>
Change-Id: Iae24878e1812c1e9e39ce8151c59e0ec2f234031
---
M soc/mediatek/mt8186/README.md
A soc/mediatek/mt8186/sspm.bin
A soc/mediatek/mt8186/sspm.bin.md5
A soc/mediatek/mt8186/sspm_release_notes.txt
4 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Rex-BC Chen: Looks good to me, but someone else must approve
Yu-Ping Wu: Verified; Looks good to me, approved
diff --git a/soc/mediatek/mt8186/README.md b/soc/mediatek/mt8186/README.md
index 160e49d..b535e83 100644
--- a/soc/mediatek/mt8186/README.md
+++ b/soc/mediatek/mt8186/README.md
@@ -19,3 +19,24 @@
`$ strings spm_firmware.bin | grep pcm_suspend`
--------------------------------------------------------------------------------
+# SSPM introduction
+SSPM is "Secure System Power Manager" that provides power control in secure domain.
+SSPM provides power related features, e.g. CPU DVFS, thermal control, to offload
+application processor for security reason.
+
+SSPM firmware is loaded into SSPM SRAM at system initialization.
+
+## Who uses it
+Coreboot will load sspm.bin to SSPM SRAM at ramstage.
+
+## How to load `sspm.bin`
+Use CBFS to load `sspm.bin`.
+No need to pass other parameters to SSPM.
+
+## Return value
+No return value.
+
+## Version
+`$ strings sspm.bin | grep "SSPM firmware"`
+
+--------------------------------------------------------------------------------
diff --git a/soc/mediatek/mt8186/sspm.bin b/soc/mediatek/mt8186/sspm.bin
new file mode 100644
index 0000000..cb71d57
--- /dev/null
+++ b/soc/mediatek/mt8186/sspm.bin
Binary files differ
diff --git a/soc/mediatek/mt8186/sspm.bin.md5 b/soc/mediatek/mt8186/sspm.bin.md5
new file mode 100644
index 0000000..974a48b
--- /dev/null
+++ b/soc/mediatek/mt8186/sspm.bin.md5
@@ -0,0 +1 @@
+1092f052c52ad94135fa1cdc3abbffe4 *sspm.bin
diff --git a/soc/mediatek/mt8186/sspm_release_notes.txt b/soc/mediatek/mt8186/sspm_release_notes.txt
new file mode 100644
index 0000000..d5e5158
--- /dev/null
+++ b/soc/mediatek/mt8186/sspm_release_notes.txt
@@ -0,0 +1,4 @@
+** Build from MediaTek Internal **
+
+# v1.0.0
+1. Add sspm.bin v1.0.0.
--
To view, visit https://review.coreboot.org/c/blobs/+/60339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Iae24878e1812c1e9e39ce8151c59e0ec2f234031
Gerrit-Change-Number: 60339
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: merged
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/blobs/+/60338 )
Change subject: soc/mediatek/mt8186: Add SPM firmware
......................................................................
soc/mediatek/mt8186: Add SPM firmware
SPM suspend can turn 26M clock off when system goes into suspend
to save power.
TEST=build pass
BUG=b:202871018
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I5a35f1c10886d31da9ba6dfec5ee2b3cf0664563
---
M soc/mediatek/mt8186/README.md
A soc/mediatek/mt8186/spm_firmware.bin
A soc/mediatek/mt8186/spm_firmware.bin.md5
A soc/mediatek/mt8186/spm_release_notes.txt
4 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Rex-BC Chen: Looks good to me, but someone else must approve
Yu-Ping Wu: Verified; Looks good to me, approved
diff --git a/soc/mediatek/mt8186/README.md b/soc/mediatek/mt8186/README.md
index 6582718..160e49d 100644
--- a/soc/mediatek/mt8186/README.md
+++ b/soc/mediatek/mt8186/README.md
@@ -1,3 +1,21 @@
# Firmware list
+- spm_firmware.bin
+
+--------------------------------------------------------------------------------
+# SPM introduction
+SPM is able to turn off more power such as DRAM self-refresh mode and 26M clock off
+when system is in suspend. Also, SPM helps support Vcore DVFS feature.
+
+## Who uses it
+Linux kernel system suspend and Vcore DVFS.
+
+## How to load `spm_fimware.bin`
+Use CBFS to load `spm_fimware.bin` to DRAM and SPM DMA loads it from dram to SPM SRAM.
+
+## Return values
+No return value.
+
+## Version
+`$ strings spm_firmware.bin | grep pcm_suspend`
--------------------------------------------------------------------------------
diff --git a/soc/mediatek/mt8186/spm_firmware.bin b/soc/mediatek/mt8186/spm_firmware.bin
new file mode 100644
index 0000000..7e0ca8d
--- /dev/null
+++ b/soc/mediatek/mt8186/spm_firmware.bin
Binary files differ
diff --git a/soc/mediatek/mt8186/spm_firmware.bin.md5 b/soc/mediatek/mt8186/spm_firmware.bin.md5
new file mode 100644
index 0000000..910cf06
--- /dev/null
+++ b/soc/mediatek/mt8186/spm_firmware.bin.md5
@@ -0,0 +1 @@
+7db456c2374b3a76daa9e6f0f2b4fd71 *spm_firmware.bin
diff --git a/soc/mediatek/mt8186/spm_release_notes.txt b/soc/mediatek/mt8186/spm_release_notes.txt
new file mode 100644
index 0000000..7d72463
--- /dev/null
+++ b/soc/mediatek/mt8186/spm_release_notes.txt
@@ -0,0 +1,4 @@
+** Build from MediaTek Internal **
+
+# pcm_suspend_mp_v1109
+1. SPM suspend can turn 26M clock off when system goes into suspend.
--
To view, visit https://review.coreboot.org/c/blobs/+/60338
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I5a35f1c10886d31da9ba6dfec5ee2b3cf0664563
Gerrit-Change-Number: 60338
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: merged
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, YH Lin.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60341 )
Change subject: mb/google/brya/var/taeko: Add judgement for PCIE signal switch
......................................................................
Patch Set 5:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4486f23ea02374c84a9b1ce04f568d78aeabd573
Gerrit-Change-Number: 60341
Gerrit-PatchSet: 5
Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Mon, 27 Dec 2021 02:51:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/blobs/+/60339 )
Change subject: soc/mediatek/mt8186: Add SSPM firmware
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@hung-te,
I think we can merge these two patches of SPM and SSPM blob?
Thanks!
--
To view, visit https://review.coreboot.org/c/blobs/+/60339
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: Iae24878e1812c1e9e39ce8151c59e0ec2f234031
Gerrit-Change-Number: 60339
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Mon, 27 Dec 2021 02:41:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60340 )
Change subject: soc/mediatek/mt8186: Enable VRF12 software control for MT6366
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60340/comment/7e625b9f_f61de6f6
PS1, Line 9: PS8640
> What kind of device is that exactly?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60340
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87d6a94b6fb343590d563ac1554ff87b11c01549
Gerrit-Change-Number: 60340
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 27 Dec 2021 02:41:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 )
Change subject: soc/mediatek/mt8186: Add DRAM full calibration support
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60318/comment/99ed97a0_e26e4be6
PS7, Line 10: We remove emi.h because emi.h is defined in common/include/soc.
> Please make that a separate commit.
I think it's hard to remove this patch in separate commmit.
There are some dependency for some configuration.
I think it will be proper to have all these changes in one patch.
Or the quantity of commits will be too much.
Patchset:
PS7:
> Please also split SOC and mainboard changes into separate commits.
I think it's hard to remove this patch in separate commmit.
There are some dependency for some configuration.
I think it will be proper to have all these changes in one patch.
Or the quantity of commits will be too much.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1a1e04da0cce9aaf86588a94c64d2242e7cb4b7
Gerrit-Change-Number: 60318
Gerrit-PatchSet: 8
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 27 Dec 2021 02:40:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/mt8186/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/60317/comment/8328d767_d1bf0af7
PS5, Line 17: AO_APC_CON = 0x0F00,
> add information at the beginning of this file.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5dad4f342eef3136c24c38259ad176dc86b7c0d7
Gerrit-Change-Number: 60317
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 27 Dec 2021 02:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment