coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: util/liveiso: Disable write protection of the intel-spi driver
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60375 ) Change subject: util/liveiso: Disable write protection of the intel-spi driver ...................................................................... util/liveiso: Disable write protection of the intel-spi driver The intel-spi driver maps the BIOS region of the flash as an mtd device at /dev/mtdX. Since this system is intended for development purposes, disable its write protection. Change-Id: Ib73d14eb4e7df6e29433b8dfbeb77dbab4a85f08 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60375 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/liveiso/common.nix 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/util/liveiso/common.nix b/util/liveiso/common.nix index 2ed4af5..d0b7ba6 100644 --- a/util/liveiso/common.nix +++ b/util/liveiso/common.nix @@ -33,6 +33,7 @@ "console=ttyS0,115200" "console=tty0" "iomem=relaxed" + "intel-spi.writeable=1" ]; # pkgs.linuxPackages == lts # pkgs.linuxPackages_latest == stable 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib73d14eb4e7df6e29433b8dfbeb77dbab4a85f08 Gerrit-Change-Number: 60375 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60373 ) Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... util/liveiso: Ensure compatible NixOS channel is used Config options and package names might change from channel to channel. Thus, don't let nix-build depend on the locally configured NixOS channel, but instead let `nixpkgs` point to a specific channel to ensure that always a compatible channel is used. For now, let `nixpkgs` point to NixOS 21.11, which is currently the latest stable release. This needs to be updated after a new release. Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60373 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/liveiso/build.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/util/liveiso/build.sh b/util/liveiso/build.sh index ee63bc5..702ace8 100755 --- a/util/liveiso/build.sh +++ b/util/liveiso/build.sh @@ -10,4 +10,5 @@ nix-build '<nixpkgs/nixos>' \ -A config.system.build.isoImage \ - -I nixos-config=$config + -I nixos-config=$config \ + -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-21.11.tar… 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... util/liveiso: Merge build scripts Merge build scripts to `build.sh`. The new one takes the desired NixOS config as an argument. Example: $ build.sh console.nix Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60372 Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- D util/liveiso/build-console.sh D util/liveiso/build-graphical.sh A util/liveiso/build.sh 3 files changed, 13 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/util/liveiso/build-console.sh b/util/liveiso/build-console.sh deleted file mode 100755 index ced2ca7..0000000 --- a/util/liveiso/build-console.sh +++ /dev/null @@ -1,3 +0,0 @@ -#!/usr/bin/env sh - -nix-build '<nixpkgs/nixos>' -A config.system.build.isoImage -I nixos-config=console.nix diff --git a/util/liveiso/build-graphical.sh b/util/liveiso/build-graphical.sh deleted file mode 100755 index 8e79478..0000000 --- a/util/liveiso/build-graphical.sh +++ /dev/null @@ -1,3 +0,0 @@ -#!/usr/bin/env sh - -nix-build '<nixpkgs/nixos>' -A config.system.build.isoImage -I nixos-config=graphical.nix diff --git a/util/liveiso/build.sh b/util/liveiso/build.sh new file mode 100755 index 0000000..ee63bc5 --- /dev/null +++ b/util/liveiso/build.sh @@ -0,0 +1,13 @@ +#!/usr/bin/env sh + +config=$1 + +if [ -z "$config" ] || [ ! -f "$config" ]; then + echo "Usage: $0 <config.nix>" + echo "No config given. Exiting." + exit 1 +fi + +nix-build '<nixpkgs/nixos>' \ + -A config.system.build.isoImage \ + -I nixos-config=$config -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 4: (1 comment) File util/crossgcc/getopt: PS3: > hm? Um, oops. Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60372 to look at the new patch set (#4). Change subject: util/liveiso: Merge build scripts ...................................................................... util/liveiso: Merge build scripts Merge build scripts to `build.sh`. The new one takes the desired NixOS config as an argument. Example: $ build.sh console.nix Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- D util/liveiso/build-console.sh D util/liveiso/build-graphical.sh A util/liveiso/build.sh 3 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60372/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 3: (1 comment) File util/crossgcc/getopt: PS3: hm? -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:31:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:31:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Michael Niewöhner (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sun, 26 Dec 2021 11:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 26 Dec '21

26 Dec '21

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60372 to look at the new patch set (#3). Change subject: util/liveiso: Merge build scripts ...................................................................... util/liveiso: Merge build scripts Merge build scripts to `build.sh`. The new one takes the desired NixOS config as an argument. Example: $ build.sh console.nix Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- A util/crossgcc/getopt D util/liveiso/build-console.sh D util/liveiso/build-graphical.sh A util/liveiso/build.sh 4 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60372/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021