coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60378 ) Change subject: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60378/comment/2a30e44f_89b02e35 PS2, Line 7: Move ADL-P PCH selection to respective mb Kconfig It's a bit long. How about this? Move SoC selection to variant config -- To view, visit https://review.coreboot.org/c/coreboot/+/60378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Gerrit-Change-Number: 60378 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 18:05:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60378 ) Change subject: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Gerrit-Change-Number: 60378 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:58:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/07a2d327_1b8b47b2 PS2, Line 25: def_bool y > Right, I would just use BOARD_GOOGLE_BRYA_COMMON, as also Eric suggested. […] Yes agree, I also felt it's the right way of doing things. Thanks Eric and Felix for your review and suggestion. Marking this comment as resolve now. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:56:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/19f55217_bd86b622 PS2, Line 25: def_bool y > Right, I would just use BOARD_GOOGLE_BRYA_COMMON, as also Eric suggested. […] That's what I meant :) Looks good. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:55:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/a09f735f_19999063 PS2, Line 25: def_bool y > > In case of you move it out, please have a look at CB:60371 before. […] Right, I would just use BOARD_GOOGLE_BRYA_COMMON, as also Eric suggested. That would align the Kconfig with other Google mainboards. See google/sarien for example. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:54:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 4: (2 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/0ee0c55c_14f800d3 PS2, Line 25: def_bool y > > In case of you move it out, please have a look at CB:60371 before. […] Finally I have address the CL as you and Eric might have suggested. Please take a look the newer patchset. https://review.coreboot.org/c/coreboot/+/60379/comment/f0a96db5_21f1a2d7 PS2, Line 60: > Ideally we wish to guard BOARD_GOOGLE_BRYA_COMMON (now BOARD_SPECIFIC_OPTIONS) using an if clause, I […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:53:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Hello build bot (Jenkins), Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60379 to look at the new patch set (#5). Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig Current mainboard code supports different baseboard binding example: brya uses BOARD_GOOGLE_BASEBOARD_BRYA and brask uses BOARD_GOOGLE_BASEBOARD_BRASK Kconfig. This patch makes the `BOARD_GOOGLE_BRYA_COMMON` Kconfig default `n` and specific baseboard binding Kconfig can select this Kconfig. It would also avoid adding if clause for specific baseboard binding Kconfig everytime with introduction of newer mainboard in future. TEST=Verified CONFIG_BOARD_GOOGLE_BRYA_COMMON=y while building brya and brya coreboot.rom remains the same. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e --- M src/mainboard/google/brya/Kconfig 1 file changed, 22 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/60379/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/6192610b_fbbba7c9 PS2, Line 25: def_bool y > In case of you move it out, please have a look at CB:60371 before. I reordered the selects alphabetically. Sorry Felix, I missed your point, are you also suggesting to drop new Kconfig and reuse the existing BOARD_GOOGLE_BRYA_COMMON to make it default n. This would further need to select from other mb Kconfig as Eric has suggested. Looks like I missed you point about `moving the whole things out here`. as we have 2 baseboards, we need a common Kconfig to select the common pieces rather moving things under individual baseboard kconfigs. btw, regarding your CL which makes things alphabetically LGTM. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:42:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/0386b510_c5f34381 PS2, Line 25: def_bool y > Can be just removed then. Another possibility would be moving the whole thing out here. […] In case of you move it out, please have a look at CB:60371 before. I reordered the selects alphabetically. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60379/comment/fa575b55_cd37b3a5 PS1, Line 17: brya remains identical > Hi Felix, do you mean deleting the .config and and auto generate the .config by menuconfig ? […] I'm blind, sorry. I thought you are adding a new config option, which would change the .config file. Done :) How about "coreboot.rom remains the same"? File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/34f8ad3f_1bd6e3af PS2, Line 25: def_bool y > default n here? Can be just removed then. Another possibility would be moving the whole thing out here. This would also align the Kconfig file with the other Google mainboards. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:31:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021