coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60378 ) Change subject: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60378/comment/a9c827b1_a3346d35 PS1, Line 10: accommodatemainboards > missing space Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/60378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Gerrit-Change-Number: 60378 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:30:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Make more brya variants to choose eNEM for CAR
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: David Wu, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 ) Change subject: mb/google/brya: Make more brya variants to choose eNEM for CAR ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > You and Tim may able talk to YH for this. […] Sure Eric. Tim also suggested the same offline to watchout that link (I have posted above) to ensure the parity. -- To view, visit https://review.coreboot.org/c/coreboot/+/60377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f Gerrit-Change-Number: 60377 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:30:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Hello build bot (Jenkins), Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60379 to look at the new patch set (#4). Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig Current mainboard code supports different baseboard binding example: brya uses BOARD_GOOGLE_BASEBOARD_BRYA and brask uses BOARD_GOOGLE_BASEBOARD_BRASK Kconfig. This patch introduces the `BOARD_GOOGLE_BRYA_COMMON` Kconfig option so if clause don't need to add specific baseboard binding Kconfig everytime with introduction of newer mainboard in future. Renamed BOARD_GOOGLE_BRYA_COMMON to BOARD_SPECIFIC_OPTIONS. TEST=Verified CONFIG_BOARD_GOOGLE_BRYA_COMMON=y while building brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e --- M src/mainboard/google/brya/Kconfig 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/60379/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Hello build bot (Jenkins), Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60378 to look at the new patch set (#2). Change subject: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig ...................................................................... mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig This patch ensures ADL-P PCH can get selected by respective mainboards to accommodate mainboards with ADL-N PCH in future. TEST=Able to build and boot brya without any Kconfig change. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 --- M src/mainboard/google/brya/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/60378/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Gerrit-Change-Number: 60378 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Make more brya variants to choose eNEM for CAR
by EricR Lai (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: David Wu, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 ) Change subject: mb/google/brya: Make more brya variants to choose eNEM for CAR ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: You and Tim may able talk to YH for this. I'am fine with it :p That's why I don't like felwinter support ES, will confuse some people. -- To view, visit https://review.coreboot.org/c/coreboot/+/60377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f Gerrit-Change-Number: 60377 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:26:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/60379/comment/a275877c_8c359f65 PS2, Line 25: def_bool y > default n here? Looking at other mainboard Kconfig, it appear to me that we always had a if clause to guard this Board Specific Kconfig selection. Hence, I have kept it in that way. I understood the changes that you are suggesting, will wait for more feedback if we want to pursue the same. https://review.coreboot.org/c/coreboot/+/60379/comment/c19a87e6_810ab740 PS2, Line 60: > add if BOARD_GOOGLE_BRYA_COMMON should be fine. Ideally we wish to guard BOARD_GOOGLE_BRYA_COMMON (now BOARD_SPECIFIC_OPTIONS) using an if clause, I don't think we can move it later. But as I have mentioned, will wait for open feedback to see if thats the correct way to do. I have just follow the way its been done for other Kconfigs. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:26:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Hello build bot (Jenkins), Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60379 to look at the new patch set (#3). Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig Current mainboard code supports different baseboard binding example: brya uses BOARD_GOOGLE_BASEBOARD_BRYA and brask uses BOARD_GOOGLE_BASEBOARD_BRASK Kconfig. This patch introduces the `BOARD_GOOGLE_BRYA_COMMON` Kconfig option so if clause don't need to add specific baseboard binding Kconfig everytime with introduction of newer mainboard in future. Renamed BOARD_GOOGLE_BRYA_COMMON to BOARD_SPECIFIC_OPTIONS. TEST=CONFIG_BOARD_GOOGLE_BRYA_COMMON=y while building brya. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e --- M src/mainboard/google/brya/Kconfig 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/60379/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Make more brya variants to choose eNEM for CAR
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: David Wu, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, EricR Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60377 ) Change subject: mb/google/brya: Make more brya variants to choose eNEM for CAR ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > The board with XXX_4ES is use the ES CPU, others is target QS CPU. […] Yes Eric, but I was waiting for assert generation to include target variant, it would make things earlier to track and enable. hope thats fine with you ? https://chrome-internal.googlesource.com/chromeos/overlays/baseboard-brya-p… -- To view, visit https://review.coreboot.org/c/coreboot/+/60377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f Gerrit-Change-Number: 60377 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:16:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Felix Singer, Reka Norman, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60379 ) Change subject: mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60379/comment/7fa2fe91_d6ae39f9 PS1, Line 17: brya remains identical > Did you exclude the config file from the coreboot. […] Hi Felix, do you mean deleting the .config and and auto generate the .config by menuconfig ? I think i need to update the commit msg, `Brya remains identical` is not very clear here. -- To view, visit https://review.coreboot.org/c/coreboot/+/60379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e Gerrit-Change-Number: 60379 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 17:08:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Reka Norman, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60378 ) Change subject: mb/google/brya: Move ADL-P PCH selection to respective mb Kconfig ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60378/comment/87fae693_97936d38 PS1, Line 10: accommodatemainboards missing space -- To view, visit https://review.coreboot.org/c/coreboot/+/60378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifbcd1cd7f8ecafee22d50c3f3f20decc4cc62797 Gerrit-Change-Number: 60378 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 16:51:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021