coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/brya: Make more brya variants to choose eNEM for CAR
by Subrata Banik (Code Review) 25 Dec '21

25 Dec '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60377 ) Change subject: mb/google/brya: Make more brya variants to choose eNEM for CAR ...................................................................... mb/google/brya: Make more brya variants to choose eNEM for CAR Gimble to drop INTEL_CAR_NEM Kconfig select and choose eNEM. BUG=b:168820083 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Ie5734606e58410545a5f5421837080680664707f --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/60377/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 02ca38f..3c8cd9b 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -173,7 +173,7 @@ choice prompt "Cache as RAM (CAR) setup configuration to use" - default USE_ADL_ENEM if BOARD_GOOGLE_KANO || BOARD_GOOGLE_FELWINTER || BOARD_GOOGLE_REDRIX + default USE_ADL_ENEM if BOARD_GOOGLE_KANO || BOARD_GOOGLE_FELWINTER || BOARD_GOOGLE_REDRIX || BOARD_GOOGLE_GIMBLE default USE_ADL_NEM config USE_ADL_ENEM -- To view, visit https://review.coreboot.org/c/coreboot/+/60377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5734606e58410545a5f5421837080680664707f Gerrit-Change-Number: 60377 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/liveiso: Install mtdutils
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60376 ) Change subject: util/liveiso: Install mtdutils ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60376 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1416d8f783518eca0606efef4314a3d86837b016 Gerrit-Change-Number: 60376 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Dec 2021 12:12:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Disable write protection of the intel-spi driver
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60375 ) Change subject: util/liveiso: Disable write protection of the intel-spi driver ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib73d14eb4e7df6e29433b8dfbeb77dbab4a85f08 Gerrit-Change-Number: 60375 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Dec 2021 12:11:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Ensure compatible NixOS channel is used
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60373 ) Change subject: util/liveiso: Ensure compatible NixOS channel is used ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia77c34f93f0e2c3d351ae229830adfce75a56ae4 Gerrit-Change-Number: 60373 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 25 Dec 2021 12:11:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/futility: Ensure futility checks for flashrom as a dep
by Edward O'Callaghan (Code Review) 25 Dec '21

25 Dec '21

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60236 ) Change subject: util/futility: Ensure futility checks for flashrom as a dep ...................................................................... util/futility: Ensure futility checks for flashrom as a dep futility actually depends on flashrom. Previously it was of the form of subprocess and now uses the libflashrom API directly. Due to the previous subprocess decoupling it was not obvious that the dependency existed however not the runtime requirement is also a strict buildtime requirement. Therefore update the Makefile accordingly. BUG=b:203715651,b:209702505 TEST=builds Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60236 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Reviewed-by: Hsuan-ting Chen <roccochen(a)google.com> --- M util/futility/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Hsuan-ting Chen: Looks good to me, but someone else must approve diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.inc index 9890339..45627a9 100644 --- a/util/futility/Makefile.inc +++ b/util/futility/Makefile.inc @@ -11,6 +11,7 @@ CC="$(HOSTCC)" \ PKG_CONFIG="$(HOSTPKGCONFIG)" \ V=$(V) \ + USE_FLASHROM=0 \ $@ .PHONY: check-openssl-presence -- To view, visit https://review.coreboot.org/c/coreboot/+/60236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9744424f75299eb8335c1c0c2aca2808bde829d Gerrit-Change-Number: 60236 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Makefile.inc: Enable iasl multiple types warning
by HAOUAS Elyes (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Martin Roth - Personal, Paul Menzel, Angel Pons. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59415 ) Change subject: Makefile.inc: Enable iasl multiple types warning ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59415/comment/d5c253ed_c86de12c PS3, Line 9: Lynxpoint > Lynx Point Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/59415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9398879a76ad3d36454772a1c23da083af14b59 Gerrit-Change-Number: 59415 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth - Personal <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 25 Dec 2021 05:42:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/asus/p2b: Add acpi/ path for ASL sources and mainboard-specific SC...
by Keith Hui (Code Review) 25 Dec '21

25 Dec '21

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60374 ) Change subject: mb/asus/p2b: Add acpi/ path for ASL sources and mainboard-specific SCMI info ...................................................................... mb/asus/p2b: Add acpi/ path for ASL sources and mainboard-specific SCMI info Adds mainboard-specific SMBus device listing information for the SCMI implementation provided by CB:41735 into an acpi/ subfolder, following the convention used by all other mainboards. This patch must be applied together with [41735]; on its own it does nothing. This content, although mainboard-specific, applies to the entire P2B family. [41735] https://review.coreboot.org/c/coreboot/+/41735 Change-Id: I9c445bd795ca78316de7c0cb63ad8d62d248a8ef Signed-off-by: Keith Hui <buurin(a)gmail.com> --- A src/mainboard/asus/p2b/acpi/scmi.asl 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60374/1 diff --git a/src/mainboard/asus/p2b/acpi/scmi.asl b/src/mainboard/asus/p2b/acpi/scmi.asl new file mode 100644 index 0000000..067dd37 --- /dev/null +++ b/src/mainboard/asus/p2b/acpi/scmi.asl @@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +/** + * SCMI: SMBus Information + * NOTE: The device list applies to the ASUS P2B family with a W83781D (or compatible) hardware + * monitor with three SMBus addresses. It may need editing when replicating to your board. + * + * @return SMBus information buffer + */ +Method (_SBI, 0) +{ + Local0 = Package(2) {0x10, Buffer() + { + 0x10, 0x10, /* SCMI and SMBus versions, both 1.0 */ + 0, 0, + 3, /* Device count */ + 0x2d, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0x48, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0x49, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0 + } + }; + return (Local0) +} -- To view, visit https://review.coreboot.org/c/coreboot/+/60374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9c445bd795ca78316de7c0cb63ad8d62d248a8ef Gerrit-Change-Number: 60374 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/liveiso: Merge build scripts
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60372 ) Change subject: util/liveiso: Merge build scripts ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60372 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49360a5c57954a205c697a4ae07361779db2aa83 Gerrit-Change-Number: 60372 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Sat, 25 Dec 2021 02:07:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Reorder selects alphabetically
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Attention is currently required from: Tim Wawrzynczak. Hello Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60371 to look at the new patch set (#2). Change subject: mb/google/brya: Reorder selects alphabetically ...................................................................... mb/google/brya: Reorder selects alphabetically Change-Id: Ie03f7049b013648372b002ce9b731589b1fffabd Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/60371/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03f7049b013648372b002ce9b731589b1fffabd Gerrit-Change-Number: 60371 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: reorder selects
by Felix Singer (Code Review) 25 Dec '21

25 Dec '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60371 ) Change subject: mb/google/brya: reorder selects ...................................................................... mb/google/brya: reorder selects Change-Id: Ie03f7049b013648372b002ce9b731589b1fffabd Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/60371/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 02ca38f..91e08c8 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -6,11 +6,11 @@ config BOARD_GOOGLE_BASEBOARD_BRASK def_bool n - select SPD_CACHE_IN_FMAP select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP + select RT8168_GEN_ACPI_POWER_RESOURCE select RT8168_GET_MAC_FROM_VPD select RT8168_SET_LED_MODE - select RT8168_GEN_ACPI_POWER_RESOURCE + select SPD_CACHE_IN_FMAP if BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK @@ -25,7 +25,6 @@ select DRIVERS_I2C_NAU8825 select DRIVERS_I2C_SX9324 select DRIVERS_INTEL_DPTF - select PMC_IPC_ACPI_INTERFACE select DRIVERS_INTEL_DPTF_SUPPORTS_TPCH select DRIVERS_INTEL_PMC select DRIVERS_INTEL_SOUNDWIRE @@ -48,6 +47,7 @@ select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_I2C_TPM_CR50 select MAINBOARD_HAS_TPM2 + select PMC_IPC_ACPI_INTERFACE select SOC_INTEL_ALDERLAKE_PCH_P select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3 select SOC_INTEL_CSE_LITE_SKU diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index bf1f5f9..794bfe7 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -7,8 +7,8 @@ select DRIVERS_INTEL_MIPI_CAMERA select HAVE_WWAN_POWER_SEQUENCE select SOC_INTEL_COMMON_BLOCK_IPU - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SOC_INTEL_CRASHLOG + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_BRYA4ES bool "-> Brya4ES" @@ -17,8 +17,8 @@ select DRIVERS_INTEL_MIPI_CAMERA select HAVE_WWAN_POWER_SEQUENCE select SOC_INTEL_COMMON_BLOCK_IPU - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SOC_INTEL_CRASHLOG + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_BRASK bool "-> Brask" @@ -31,15 +31,15 @@ bool "-> Primus" select BOARD_GOOGLE_BASEBOARD_BRYA select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select HAVE_WWAN_POWER_SEQUENCE + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_PRIMUS4ES bool "-> Primus4ES" select BOARD_GOOGLE_BASEBOARD_BRYA select DRIVERS_GENESYSLOGIC_GL9755 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select HAVE_WWAN_POWER_SEQUENCE + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_GIMBLE bool "-> Gimble" @@ -62,43 +62,43 @@ select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_DSM_CALIB if CHROMEOS select CHROMEOS_DSM_PARAM_FILE_NAME if CHROMEOS + select DRIVERS_GENESYSLOGIC_GL9755 + select DRIVERS_GFX_GENERIC select DRIVERS_I2C_MAX98390 select DRIVERS_INTEL_MIPI_CAMERA select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG - select SOC_INTEL_COMMON_BLOCK_IPU - select DRIVERS_GENESYSLOGIC_GL9755 - select DRIVERS_GFX_GENERIC - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select HAVE_WWAN_POWER_SEQUENCE + select SOC_INTEL_COMMON_BLOCK_IPU + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_REDRIX4ES bool "-> Redrix4ES" select BOARD_GOOGLE_BASEBOARD_BRYA select CHROMEOS_DSM_CALIB if CHROMEOS select CHROMEOS_DSM_PARAM_FILE_NAME if CHROMEOS + select DRIVERS_GENESYSLOGIC_GL9755 + select DRIVERS_GFX_GENERIC select DRIVERS_I2C_MAX98390 select DRIVERS_INTEL_MIPI_CAMERA select EC_GOOGLE_CHROMEEC_INCLUDE_SSFC_IN_FW_CONFIG - select SOC_INTEL_COMMON_BLOCK_IPU - select DRIVERS_GENESYSLOGIC_GL9755 - select DRIVERS_GFX_GENERIC - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select HAVE_WWAN_POWER_SEQUENCE + select SOC_INTEL_COMMON_BLOCK_IPU + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_KANO bool "-> Kano" select BOARD_GOOGLE_BASEBOARD_BRYA select DRIVERS_I2C_MAX98373 select DRIVERS_I2C_NAU8825 - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select DRIVERS_INTEL_MIPI_CAMERA select SOC_INTEL_COMMON_BLOCK_IPU + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES config BOARD_GOOGLE_TAEKO bool "-> Taeko" select BOARD_GOOGLE_BASEBOARD_BRYA - select DRIVERS_GENESYSLOGIC_GL9763E select DRIVERS_GENERIC_BAYHUB_LV2 + select DRIVERS_GENESYSLOGIC_GL9763E config BOARD_GOOGLE_TAEKO4ES bool "-> Taeko4ES" @@ -108,8 +108,8 @@ config BOARD_GOOGLE_FELWINTER bool "-> Felwinter" select BOARD_GOOGLE_BASEBOARD_BRYA - select DRIVERS_GENERIC_GPIO_KEYS select CHROMEOS_WIFI_SAR if CHROMEOS + select DRIVERS_GENERIC_GPIO_KEYS config BOARD_GOOGLE_ANAHERA bool "-> Anahera" -- To view, visit https://review.coreboot.org/c/coreboot/+/60371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie03f7049b013648372b002ce9b731589b1fffabd Gerrit-Change-Number: 60371 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021