coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: soc/mediatek/mt8186: Add DRAM full calibration support
by Paul Menzel (Code Review) 24 Dec '21

24 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Ryan Chuang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60318 ) Change subject: soc/mediatek/mt8186: Add DRAM full calibration support ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/60318/comment/8a7c4349_58feb0d3 PS7, Line 10: We remove emi.h because emi.h is defined in common/include/soc. Please make that a separate commit. Patchset: PS7: Please also split SOC and mainboard changes into separate commits. -- To view, visit https://review.coreboot.org/c/coreboot/+/60318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1a1e04da0cce9aaf86588a94c64d2242e7cb4b7 Gerrit-Change-Number: 60318 Gerrit-PatchSet: 7 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:51:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Add devapc basic drivers
by Paul Menzel (Code Review) 24 Dec '21

24 Dec '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 ) Change subject: soc/mediatek/mt8186: Add devapc basic drivers ...................................................................... Patch Set 5: (4 comments) File src/soc/mediatek/mt8186/devapc.c: https://review.coreboot.org/c/coreboot/+/60317/comment/62bdb580_491d4844 PS5, Line 6: static const struct apc_infra_peri_dom_8 infra_ao_sys0_devices[] = { How did you create this? Copied from datasheet? https://review.coreboot.org/c/coreboot/+/60317/comment/70c2efc1_cdf2e67a PS5, Line 1252: int unsigned int https://review.coreboot.org/c/coreboot/+/60317/comment/711c9079_c5da169a PS5, Line 1306: int unsigned int File src/soc/mediatek/mt8186/include/soc/devapc.h: https://review.coreboot.org/c/coreboot/+/60317/comment/3ba7b369_887c5f3d PS5, Line 17: AO_APC_CON = 0x0F00, Please add the datasheet name, revision and section, where you got the offsets from. -- To view, visit https://review.coreboot.org/c/coreboot/+/60317 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5dad4f342eef3136c24c38259ad176dc86b7c0d7 Gerrit-Change-Number: 60317 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:50:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/beltino/Kconfig: Reorder selects alphabetically
by build bot (Jenkins) (Code Review) 24 Dec '21

24 Dec '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60356 ) Change subject: mb/google/beltino/Kconfig: Reorder selects alphabetically ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/beltino/Kconfig: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136193): https://review.coreboot.org/c/coreboot/+/60356/comment/a0583e69_bcdc4901 PS2, Line 15: select SUPERIO_ITE_IT8772F 'SUPERIO' may be misspelled - perhaps ''? -- To view, visit https://review.coreboot.org/c/coreboot/+/60356 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4ba4b2a7a358ad86b547b16a12593b912f9bd8f Gerrit-Change-Number: 60356 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:49:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/jecht/Kconfig: Reorder selects alphabetically
by build bot (Jenkins) (Code Review) 24 Dec '21

24 Dec '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60354 ) Change subject: mb/google/jecht/Kconfig: Reorder selects alphabetically ...................................................................... Patch Set 2: Verified+1 (1 comment) File src/mainboard/google/jecht/Kconfig: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136192): https://review.coreboot.org/c/coreboot/+/60354/comment/23ee735f_375bf734 PS2, Line 13: select SUPERIO_ITE_IT8772F 'SUPERIO' may be misspelled - perhaps ''? -- To view, visit https://review.coreboot.org/c/coreboot/+/60354 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2287ae1357e0f02a42ebd770ee799613fd29c033 Gerrit-Change-Number: 60354 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:41:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cyan: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60362 ) Change subject: mb/google/cyan: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcdfd9fff197391ca0da083e7f6151c2dffe3374 Gerrit-Change-Number: 60362 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:29:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cyan/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60361 ) Change subject: mb/google/cyan/Kconfig: Reorder selects alphabetically ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60361 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I445dbe5d1f744c6512d618efdc927509d5ba291f Gerrit-Change-Number: 60361 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:29:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/auron: Select board-specific options per board
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60360 ) Change subject: mb/google/auron: Select board-specific options per board ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60360 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c437ee2d62415f9048a24ad4a517fc33eec3cf1 Gerrit-Change-Number: 60360 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:28:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/auron: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60359 ) Change subject: mb/google/auron: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60359 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9e001721baa7b7df89204eed03375e872c93e28 Gerrit-Change-Number: 60359 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:27:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/auron/Kconfig: Reorder selects alphabetically
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60358 ) Change subject: mb/google/auron/Kconfig: Reorder selects alphabetically ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1c438e53adc835df0a3f9436f94e0f5341cf79dd Gerrit-Change-Number: 60358 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:27:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/beltino: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 24 Dec '21

24 Dec '21

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60357 ) Change subject: mb/google/beltino: Move selects from Kconfig.name to Kconfig ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/60357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1bbe7d68d9eace3f54e9decbd02f8b2b50d6867 Gerrit-Change-Number: 60357 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 24 Dec 2021 21:26:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021