Attention is currently required from: Reka Norman, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee.
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60326 )
Change subject: mb/google/brya: fix taniks' and vell's override.cb
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/60326
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie69a143ea2a43a1ee5a3c9f79975e1831e88c4b4
Gerrit-Change-Number: 60326
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Comment-Date: Fri, 24 Dec 2021 19:03:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60157 )
Change subject: mb/google/drallion: Move selects from Kconfig.name to Kconfig
......................................................................
mb/google/drallion: Move selects from Kconfig.name to Kconfig
Move selects from Kconfig.name to Kconfig so that the configuration is
at one place and not distributed over two files.
Change-Id: I4de9bc426b92d57d6aabe17cceddf6b6aa444327
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60157
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/drallion/Kconfig.name
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/Kconfig b/src/mainboard/google/drallion/Kconfig
index 6e3dbad..b0b0a5c 100644
--- a/src/mainboard/google/drallion/Kconfig
+++ b/src/mainboard/google/drallion/Kconfig
@@ -24,6 +24,9 @@
select SOC_INTEL_COMMON_BLOCK_SMM_ESPI_DISABLE
select SYSTEM_TYPE_LAPTOP
+config BOARD_GOOGLE_DRALLION
+ select BOARD_GOOGLE_BASEBOARD_DRALLION
+
if BOARD_GOOGLE_BASEBOARD_DRALLION
config CHROMEOS
diff --git a/src/mainboard/google/drallion/Kconfig.name b/src/mainboard/google/drallion/Kconfig.name
index bd5d903..5870571 100644
--- a/src/mainboard/google/drallion/Kconfig.name
+++ b/src/mainboard/google/drallion/Kconfig.name
@@ -2,4 +2,3 @@
config BOARD_GOOGLE_DRALLION
bool "-> Drallion"
- select BOARD_GOOGLE_BASEBOARD_DRALLION
--
To view, visit https://review.coreboot.org/c/coreboot/+/60157
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de9bc426b92d57d6aabe17cceddf6b6aa444327
Gerrit-Change-Number: 60157
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged